Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0032160
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2016-02-08 15:382016-02-24 13:35
ReporterairaceburuView Statuspublic 
Assigned Tojorge-garcia 
PriorityimmediateResolutionfixedFixed in VersionRR16Q2
StatusclosedFix in branchFixed in SCM revisionf5a5d93bff22
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toguilleaer
Regression levelQA functional test
Regression date
Regression introduced in releasemain
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0032160: [RR16Q1] Scanning focus on main menu closing

DescriptionThe scanning focus is not set to true again after the main menu closes, and barcode scanning stops working.
Steps To Reproduce1.-Open main menu
2.-Close main menu
3.-Enter a number
4.-Press enter (physical keyboard)

(Uses external input has to be enabled)

The message "UPC/EAN code not found: XX" is not shown. If a barcode scanner is configured, at this point products will no longer be added to the ticket anymore. (This is just a message to notice the issue. Under no circumstances is the real problem)
Proposed SolutionThe scanMode should not be changed to false on main menu opening, or it should be reset to to true when the menu is closed.

It make sense to review all the calls to scanningFocus.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0032163RR16Q1 closedguilleaer [RR16Q1] Scanning focus on main menu closing 
related to defect 0032311 closedranjith_qualiantech_com Test I31747_ConfirmationPopUpWithDefaultAction is failing in try-retail 

-  Notes
(0084010)
Orekaria (administrator)
2016-02-08 17:34
edited on: 2016-02-08 17:36

 The issue cannot be reproduced in a pristine RR16Q1

Also changed to minor
(0084016)
airaceburu (reporter)
2016-02-08 18:08

 After talking about it, it is reproducible in RR16Q1
(0084056)
airaceburu (reporter)
2016-02-09 14:51

 On ob-menu.js this code disables the scanningFocus when the menu is shown:

 onButtonTap: function () {
    // disable focus keeper while showing the menu
    this.originalSanMode = OB.MobileApp.view.scanMode;
    OB.MobileApp.view.scanningFocus(false, true);
(...)

(BTW scanningFocus function only accept one parameter)

When the menu is closed the scanningFocus is not reenabled.

This prevent us from controlling things based on the scanningFocus. This issue is even bigger when those things also have a button to control them in the main menu.
(0084381)
hgbot (developer)
2016-02-20 21:40

 Repository: tools/automation/pi-mobile
Changeset: 1916e056400d17aa07044df1ae3b53913ccb9363
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Feb 12 12:52:36 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/1916e056400d17aa07044df1ae3b53913ccb9363 [^]

Verifies issue 32160: [RR16Q1] Scanning focus on main menu closing

Added test I32160_ScaningFocusAvailableWithMenuOpen.

---
A src-test/org/openbravo/test/mobile/quarantine/JGA/pack/system/externalinput/I32160_ScaningFocusAvailableWithMenuOpen.java
---
(0084456)
hgbot (developer)
2016-02-24 11:27

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: f5a5d93bff22c751905ddae374dc082d5238e719
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Feb 12 12:32:32 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/f5a5d93bff22c751905ddae374dc082d5238e719 [^]

Fixed issue 32160: [RR16Q1] Scanning focus on main menu closing

The problem was that the scanningFocus was set to false when the menu button is
tapped, but the scanningFocus is not set to true when the menu is closed.

---
M web/org.openbravo.mobile.core/source/component/ob-menu.js
---
(0084457)
hgbot (developer)
2016-02-24 11:27

 Repository: tools/automation/pi-mobile
Changeset: fb3f31a12968125751c863b17dc99c9f95ab33fc
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Feb 24 11:26:33 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/fb3f31a12968125751c863b17dc99c9f95ab33fc [^]

Verifies issue issue 32160: [RR16Q1] Scanning focus on main menu closing

Added test I32160_DefaultActionAfterOpenMenu

Some test requires some changes:
* I31747_ConfirmationPopUpWithDefaultAction
* I31765_DisableNewTicketInPayOpen
* I31171_CheckReceiptLabelForPaidreturn

---
M src-test/org/openbravo/test/mobile/quarantine/pack/RAN/receipts/I31171_CheckReceiptLabelForPaidreturn.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I31765_DisableNewTicketInPayOpen.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/externalInput/I31747_ConfirmationPopUpWithDefaultAction.java
A src-test/org/openbravo/test/mobile/quarantine/pack/JGA/system/externalinput/I32160_DefaultActionAfterOpenMenu.java
---

- Issue History
Date Modified Username Field Change
2016-02-08 15:38 airaceburu New Issue
2016-02-08 15:38 airaceburu Assigned To => Retail
2016-02-08 15:38 airaceburu Resolution time => 1455058800
2016-02-08 15:38 airaceburu Regression level => QA functional test
2016-02-08 15:38 airaceburu Regression introduced in release => main
2016-02-08 15:38 airaceburu Triggers an Emergency Pack => No
2016-02-08 16:02 airaceburu Steps to Reproduce Updated View Revisions
2016-02-08 17:30 airaceburu Proposed Solution updated
2016-02-08 17:34 Orekaria Note Added: 0084010
2016-02-08 17:34 Orekaria Status new => feedback
2016-02-08 17:36 Orekaria Severity major => minor
2016-02-08 17:36 Orekaria Note Edited: 0084010 View Revisions
2016-02-08 18:05 airaceburu Steps to Reproduce Updated View Revisions
2016-02-08 18:06 airaceburu Steps to Reproduce Updated View Revisions
2016-02-08 18:08 airaceburu Note Added: 0084016
2016-02-08 18:09 Orekaria Assigned To Retail => Orekaria
2016-02-08 18:10 Orekaria Assigned To Orekaria => Retail
2016-02-08 18:10 Orekaria Status feedback => scheduled
2016-02-08 18:10 Orekaria Status scheduled => acknowledged
2016-02-08 18:38 marvintm Description Updated View Revisions
2016-02-08 18:38 marvintm Steps to Reproduce Updated View Revisions
2016-02-08 18:38 marvintm Severity minor => major
2016-02-09 09:24 guillermogil Description Updated View Revisions
2016-02-09 09:24 guillermogil Proposed Solution updated
2016-02-09 09:47 airaceburu Proposed Solution updated
2016-02-09 14:11 guillermogil Issue Monitored: guillermogil
2016-02-09 14:51 airaceburu Note Added: 0084056
2016-02-09 14:51 airaceburu Steps to Reproduce Updated View Revisions
2016-02-09 14:51 airaceburu Proposed Solution updated
2016-02-10 15:37 jorge-garcia Status acknowledged => scheduled
2016-02-10 15:37 jorge-garcia Assigned To Retail => jorge-garcia
2016-02-20 21:40 hgbot Checkin
2016-02-20 21:40 hgbot Note Added: 0084381
2016-02-23 11:18 jorge-garcia Relationship added related to 0032311
2016-02-24 11:27 hgbot Checkin
2016-02-24 11:27 hgbot Note Added: 0084456
2016-02-24 11:27 hgbot Status scheduled => resolved
2016-02-24 11:27 hgbot Resolution open => fixed
2016-02-24 11:27 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/f5a5d93bff22c751905ddae374dc082d5238e719 [^]
2016-02-24 11:27 hgbot Checkin
2016-02-24 11:27 hgbot Note Added: 0084457
2016-02-24 13:35 guilleaer Review Assigned To => guilleaer
2016-02-24 13:35 guilleaer Status resolved => closed
2016-02-24 13:35 guilleaer Fixed in Version => RR16Q2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker