Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032160Retail ModulesWeb POSpublic2016-02-08 15:382016-02-24 13:35
Reporterairaceburu 
Assigned Tojorge-garcia 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q2 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerOBPS
Support ticket
Regression levelQA functional test
Regression date
Regression introduced in releasemain
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032160: [RR16Q1] Scanning focus on main menu closing
DescriptionThe scanning focus is not set to true again after the main menu closes, and barcode scanning stops working.
Steps To Reproduce1.-Open main menu
2.-Close main menu
3.-Enter a number
4.-Press enter (physical keyboard)

(Uses external input has to be enabled)

The message "UPC/EAN code not found: XX" is not shown. If a barcode scanner is configured, at this point products will no longer be added to the ticket anymore. (This is just a message to notice the issue. Under no circumstances is the real problem)
Proposed SolutionThe scanMode should not be changed to false on main menu opening, or it should be reset to to true when the menu is closed.

It make sense to review all the calls to scanningFocus.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0032163RR16Q1 closed guilleaer [RR16Q1] Scanning focus on main menu closing 
related to defect 0032311 closed ranjith_qualiantech_com Test I31747_ConfirmationPopUpWithDefaultAction is failing in try-retail 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-02-08 15:38airaceburuNew Issue
2016-02-08 15:38airaceburuAssigned To => Retail
2016-02-08 15:38airaceburuOBNetwork customer => Yes
2016-02-08 15:38airaceburuResolution time => 1455058800
2016-02-08 15:38airaceburuRegression level => QA functional test
2016-02-08 15:38airaceburuRegression introduced in release => main
2016-02-08 15:38airaceburuTriggers an Emergency Pack => No
2016-02-08 16:02airaceburuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=10996#r10996
2016-02-08 17:30airaceburuProposed Solution updated
2016-02-08 17:34OrekariaNote Added: 0084010
2016-02-08 17:34OrekariaStatusnew => feedback
2016-02-08 17:36OrekariaSeveritymajor => minor
2016-02-08 17:36OrekariaNote Edited: 0084010bug_revision_view_page.php?bugnote_id=0084010#r11004
2016-02-08 18:05airaceburuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=11005#r11005
2016-02-08 18:06airaceburuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=11006#r11006
2016-02-08 18:08airaceburuNote Added: 0084016
2016-02-08 18:09OrekariaAssigned ToRetail => Orekaria
2016-02-08 18:10OrekariaAssigned ToOrekaria => Retail
2016-02-08 18:10OrekariaStatusfeedback => scheduled
2016-02-08 18:10OrekariaStatusscheduled => acknowledged
2016-02-08 18:38marvintmDescription Updatedbug_revision_view_page.php?rev_id=11008#r11008
2016-02-08 18:38marvintmSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=11009#r11009
2016-02-08 18:38marvintmSeverityminor => major
2016-02-09 09:24guillermogilDescription Updatedbug_revision_view_page.php?rev_id=11016#r11016
2016-02-09 09:24guillermogilProposed Solution updated
2016-02-09 09:47airaceburuProposed Solution updated
2016-02-09 14:11guillermogilIssue Monitored: guillermogil
2016-02-09 14:51airaceburuNote Added: 0084056
2016-02-09 14:51airaceburuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=11039#r11039
2016-02-09 14:51airaceburuProposed Solution updated
2016-02-10 15:37jorge-garciaStatusacknowledged => scheduled
2016-02-10 15:37jorge-garciaAssigned ToRetail => jorge-garcia
2016-02-20 21:40hgbotCheckin
2016-02-20 21:40hgbotNote Added: 0084381
2016-02-23 11:18jorge-garciaRelationship addedrelated to 0032311
2016-02-24 11:27hgbotCheckin
2016-02-24 11:27hgbotNote Added: 0084456
2016-02-24 11:27hgbotStatusscheduled => resolved
2016-02-24 11:27hgbotResolutionopen => fixed
2016-02-24 11:27hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/f5a5d93bff22c751905ddae374dc082d5238e719 [^]
2016-02-24 11:27hgbotCheckin
2016-02-24 11:27hgbotNote Added: 0084457
2016-02-24 13:35guilleaerReview Assigned To => guilleaer
2016-02-24 13:35guilleaerStatusresolved => closed
2016-02-24 13:35guilleaerFixed in Version => RR16Q2

Notes
(0084010)
Orekaria   
2016-02-08 17:34   
(edited on: 2016-02-08 17:36)
The issue cannot be reproduced in a pristine RR16Q1

Also changed to minor
(0084016)
airaceburu   
2016-02-08 18:08   
After talking about it, it is reproducible in RR16Q1
(0084056)
airaceburu   
2016-02-09 14:51   
On ob-menu.js this code disables the scanningFocus when the menu is shown:

 onButtonTap: function () {
    // disable focus keeper while showing the menu
    this.originalSanMode = OB.MobileApp.view.scanMode;
    OB.MobileApp.view.scanningFocus(false, true);
(...)

(BTW scanningFocus function only accept one parameter)

When the menu is closed the scanningFocus is not reenabled.

This prevent us from controlling things based on the scanningFocus. This issue is even bigger when those things also have a button to control them in the main menu.
(0084381)
hgbot   
2016-02-20 21:40   
Repository: tools/automation/pi-mobile
Changeset: 1916e056400d17aa07044df1ae3b53913ccb9363
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Feb 12 12:52:36 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/1916e056400d17aa07044df1ae3b53913ccb9363 [^]

Verifies issue 32160: [RR16Q1] Scanning focus on main menu closing

Added test I32160_ScaningFocusAvailableWithMenuOpen.

---
A src-test/org/openbravo/test/mobile/quarantine/JGA/pack/system/externalinput/I32160_ScaningFocusAvailableWithMenuOpen.java
---
(0084456)
hgbot   
2016-02-24 11:27   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: f5a5d93bff22c751905ddae374dc082d5238e719
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Feb 12 12:32:32 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/f5a5d93bff22c751905ddae374dc082d5238e719 [^]

Fixed issue 32160: [RR16Q1] Scanning focus on main menu closing

The problem was that the scanningFocus was set to false when the menu button is
tapped, but the scanningFocus is not set to true when the menu is closed.

---
M web/org.openbravo.mobile.core/source/component/ob-menu.js
---
(0084457)
hgbot   
2016-02-24 11:27   
Repository: tools/automation/pi-mobile
Changeset: fb3f31a12968125751c863b17dc99c9f95ab33fc
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Feb 24 11:26:33 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/fb3f31a12968125751c863b17dc99c9f95ab33fc [^]

Verifies issue issue 32160: [RR16Q1] Scanning focus on main menu closing

Added test I32160_DefaultActionAfterOpenMenu

Some test requires some changes:
* I31747_ConfirmationPopUpWithDefaultAction
* I31765_DisableNewTicketInPayOpen
* I31171_CheckReceiptLabelForPaidreturn

---
M src-test/org/openbravo/test/mobile/quarantine/pack/RAN/receipts/I31171_CheckReceiptLabelForPaidreturn.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I31765_DisableNewTicketInPayOpen.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/externalInput/I31747_ConfirmationPopUpWithDefaultAction.java
A src-test/org/openbravo/test/mobile/quarantine/pack/JGA/system/externalinput/I32160_DefaultActionAfterOpenMenu.java
---