Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0031847
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Retail Modules] Web POSmajorhave not tried2016-01-08 12:422016-02-03 08:40
ReporteradrianromeroView Statuspublic 
Assigned ToRetail 
PrioritynormalResolutionfixedFixed in VersionRR15Q4.2
StatusclosedFix in branchFixed in SCM revision4ead149ae913
ProjectionnoneETAnoneTarget VersionRR15Q4.2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toguilleaer
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0031847: Confusing fields: 'Allow overpayment' and 'Overpayment limit'

DescriptionThese two fields were defined for the feature request: 29868: Define change limit for cash methods but its meaning are confusing.

Steps To ReproduceJust open the Terminal type windows and go to the tab "Payment Methods" where these fields are defined and to make it visible select a payment method of type "Cash".

1.- Allow overpayment is redundant. Basically if the overpayment limit is zero has the same behaviour as unchecking this field
2.- Overpayment limit actually means "Change limit" the maximum change allowed to be returned to a customer.
Proposed Solution1.- "Allow overpayment". It is redundant and can be simulated setting the limit to zero.
     RR15Q4, RR16Q1: Hide the field from the backend UI. Change WebPOS to ignore this value, assume true
     RR16Q2: Remove the field and clean up code

2.- Rename "Overpayment limit" to "Change limit"

3.- ModuleScript:
    In order to avoid garbage in the database and also protect any potential implementation that has a modified "Allow overpayment" value it must be considered to remove completely this field from the database, adjust the functionality and create an script that sets the change limit to zero in case "Allow overpayment" is unchecked.

Test cases:
- create a sale with cash and pay more. same with a non-cash payment method
- see related issue 31792. create that test
- verify that change limit is working
- adjust existing tests
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0031842 closedranjith_qualiantech_com Confusing fields: 'Allow overpayment' and 'Overpayment limit' 

-  Notes
(0083862)
hgbot (developer)
2016-02-02 21:21

 Repository: retail/backports/3.0RR15Q4.2/org.openbravo.retail.posterminal
Changeset: 4ead149ae9135550e65c8f126fa6a70031dc9cc4
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Feb 02 21:21:00 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR15Q4.2/org.openbravo.retail.posterminal/rev/4ead149ae9135550e65c8f126fa6a70031dc9cc4 [^]

Fixed issue 31847, Backport of 31842: Allow overpayment field removed

starting from this issue functionality is defined by overpayment limit field value:
- null: Overpayment is allowed without any restriction
- 0: Overpayment is not allowed
- Number: Overpayment is allowed if it not reach the limit

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
A build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue31842.class
A build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue31842Data.class
A src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/FixDataIssue31842.java
A src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/FixDataIssue31842_Data.xsql
---
(0083875)
hgbot (developer)
2016-02-03 08:40

 Repository: retail/backports/3.0RR15Q4.2/org.openbravo.retail.posterminal
Changeset: 007ef1bde66798cca9a82592eb8edb47b3dcbea7
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Feb 03 08:39:30 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR15Q4.2/org.openbravo.retail.posterminal/rev/007ef1bde66798cca9a82592eb8edb47b3dcbea7 [^]

Related to issue 31847: fix license files

---
M src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/FixDataIssue31842.java
M src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/FixDataIssue31842_Data.xsql
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---

- Issue History
Date Modified Username Field Change
2016-01-08 14:32 Orekaria Type defect => backport
2016-01-08 14:32 Orekaria Target Version => RR15Q4.2
2016-02-02 21:21 hgbot Checkin
2016-02-02 21:21 hgbot Note Added: 0083862
2016-02-02 21:21 hgbot Status scheduled => resolved
2016-02-02 21:21 hgbot Resolution open => fixed
2016-02-02 21:21 hgbot Fixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR15Q4.2/org.openbravo.retail.posterminal/rev/4ead149ae9135550e65c8f126fa6a70031dc9cc4 [^]
2016-02-02 21:28 guilleaer Review Assigned To => guilleaer
2016-02-02 21:28 guilleaer Status resolved => closed
2016-02-02 21:28 guilleaer Fixed in Version => RR15Q4.2
2016-02-03 08:40 hgbot Checkin
2016-02-03 08:40 hgbot Note Added: 0083875

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker