Openbravo Issue Tracking System - Retail Modules | ||||||||||||
| View Issue Details | ||||||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | |||||||
| 0031847 | Retail Modules | Web POS | public | 2016-01-08 12:42 | 2016-02-03 08:40 | |||||||
| Reporter | adrianromero | |||||||||||
| Assigned To | Retail | |||||||||||
| Priority | normal | Severity | major | Reproducibility | have not tried | |||||||
| Status | closed | Resolution | fixed | |||||||||
| Platform | OS | 5 | OS Version | |||||||||
| Product Version | ||||||||||||
| Target Version | RR15Q4.2 | Fixed in Version | RR15Q4.2 | |||||||||
| Merge Request Status | ||||||||||||
| Review Assigned To | guilleaer | |||||||||||
| OBNetwork customer | ||||||||||||
| Support ticket | ||||||||||||
| Regression level | ||||||||||||
| Regression date | ||||||||||||
| Regression introduced in release | ||||||||||||
| Regression introduced by commit | ||||||||||||
| Triggers an Emergency Pack | No | |||||||||||
| Summary | 0031847: Confusing fields: 'Allow overpayment' and 'Overpayment limit' | |||||||||||
| Description | These two fields were defined for the feature request: 29868: Define change limit for cash methods but its meaning are confusing. | |||||||||||
| Steps To Reproduce | Just open the Terminal type windows and go to the tab "Payment Methods" where these fields are defined and to make it visible select a payment method of type "Cash". 1.- Allow overpayment is redundant. Basically if the overpayment limit is zero has the same behaviour as unchecking this field 2.- Overpayment limit actually means "Change limit" the maximum change allowed to be returned to a customer. | |||||||||||
| Proposed Solution | 1.- "Allow overpayment". It is redundant and can be simulated setting the limit to zero. RR15Q4, RR16Q1: Hide the field from the backend UI. Change WebPOS to ignore this value, assume true RR16Q2: Remove the field and clean up code 2.- Rename "Overpayment limit" to "Change limit" 3.- ModuleScript: In order to avoid garbage in the database and also protect any potential implementation that has a modified "Allow overpayment" value it must be considered to remove completely this field from the database, adjust the functionality and create an script that sets the change limit to zero in case "Allow overpayment" is unchecked. Test cases: - create a sale with cash and pay more. same with a non-cash payment method - see related issue 31792. create that test - verify that change limit is working - adjust existing tests | |||||||||||
| Additional Information | ||||||||||||
| Tags | No tags attached. | |||||||||||
| Relationships |
| |||||||||||
| Attached Files | ||||||||||||
| Issue History | ||||||||||||
| Date Modified | Username | Field | Change | |||||||||
| 2016-01-08 14:32 | Orekaria | Type | defect => backport | |||||||||
| 2016-01-08 14:32 | Orekaria | Target Version | => RR15Q4.2 | |||||||||
| 2016-02-02 21:21 | hgbot | Checkin | ||||||||||
| 2016-02-02 21:21 | hgbot | Note Added: 0083862 | ||||||||||
| 2016-02-02 21:21 | hgbot | Status | scheduled => resolved | |||||||||
| 2016-02-02 21:21 | hgbot | Resolution | open => fixed | |||||||||
| 2016-02-02 21:21 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/retail/backports/3.0RR15Q4.2/org.openbravo.retail.posterminal/rev/4ead149ae9135550e65c8f126fa6a70031dc9cc4 [^] | |||||||||
| 2016-02-02 21:28 | guilleaer | Review Assigned To | => guilleaer | |||||||||
| 2016-02-02 21:28 | guilleaer | Status | resolved => closed | |||||||||
| 2016-02-02 21:28 | guilleaer | Fixed in Version | => RR15Q4.2 | |||||||||
| 2016-02-03 08:40 | hgbot | Checkin | ||||||||||
| 2016-02-03 08:40 | hgbot | Note Added: 0083875 | ||||||||||
| Notes | |||||
|
|
|||||
|
|
||||
|
|
|||||
|
|
||||