Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0031846 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Retail Modules] Web POS | major | have not tried | 2016-01-08 12:42 | 2016-03-08 17:07 | |||
| Reporter | adrianromero | View Status | public | |||||
| Assigned To | ranjith_qualiantech_com | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR16Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | ba0181d97e19 | ||||
| Projection | none | ETA | none | Target Version | RR16Q1 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | marvintm | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0031846: Confusing fields: 'Allow overpayment' and 'Overpayment limit' | |||||||
| Description | These two fields were defined for the feature request: 29868: Define change limit for cash methods but its meaning are confusing. | |||||||
| Steps To Reproduce | Just open the Terminal type windows and go to the tab "Payment Methods" where these fields are defined and to make it visible select a payment method of type "Cash". 1.- Allow overpayment is redundant. Basically if the overpayment limit is zero has the same behaviour as unchecking this field 2.- Overpayment limit actually means "Change limit" the maximum change allowed to be returned to a customer. | |||||||
| Proposed Solution | 1.- "Allow overpayment". It is redundant and can be simulated setting the limit to zero. RR15Q4, RR16Q1: Hide the field from the backend UI. Change WebPOS to ignore this value, assume true RR16Q2: Remove the field and clean up code 2.- Rename "Overpayment limit" to "Change limit" 3.- ModuleScript: In order to avoid garbage in the database and also protect any potential implementation that has a modified "Allow overpayment" value it must be considered to remove completely this field from the database, adjust the functionality and create an script that sets the change limit to zero in case "Allow overpayment" is unchecked. Test cases: - create a sale with cash and pay more. same with a non-cash payment method - see related issue 31792. create that test - verify that change limit is working - adjust existing tests | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0084193) hgbot (developer) 2016-02-15 16:08 |
Repository: retail/backports/3.0RR16Q1/org.openbravo.retail.posterminal Changeset: b350c4ba460ff8e446de614b543830e6723c90f7 Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com> Date: Tue Feb 02 00:03:43 2016 +0100 URL: http://code.openbravo.com/retail/backports/3.0RR16Q1/org.openbravo.retail.posterminal/rev/b350c4ba460ff8e446de614b543830e6723c90f7 [^] Fixes issue 31846 backport of issue 31842: Hide field "Allow overpayment" in POS Terminal Type - Payment Method Added Module script to update overpayment limit Hide "Allow Overpayment" field from POS Terminal Type starting from this issue functionality is defined by overpayment limit field value: - null: Overpayment is allowed without any restriction - 0: Overpayment is not allowed - Number: Overpayment is allowed if it not reach the limit --- M src-db/database/sourcedata/AD_COLUMN.xml M src-db/database/sourcedata/AD_ELEMENT.xml M src-db/database/sourcedata/AD_FIELD.xml M src-db/database/sourcedata/AD_MESSAGE.xml M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js A build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue31842.class A build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue31842Data.class A src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/FixDataIssue31842.java A src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/FixDataIssue31842_Data.xsql --- |
|
(0084194) hgbot (developer) 2016-02-15 16:08 |
Repository: retail/backports/3.0RR16Q1/org.openbravo.retail.posterminal Changeset: 481fdc5cfa088202a93945fbaf1ec6a3ade88690 Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com> Date: Wed Feb 03 08:44:47 2016 +0100 URL: http://code.openbravo.com/retail/backports/3.0RR16Q1/org.openbravo.retail.posterminal/rev/481fdc5cfa088202a93945fbaf1ec6a3ade88690 [^] Related to issue 31846 backport of issue 31842: Fix license in affected files --- M src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/FixDataIssue31842.java M src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/FixDataIssue31842_Data.xsql M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js --- |
|
(0084196) hgbot (developer) 2016-02-15 16:08 |
Repository: retail/backports/3.0RR16Q1/org.openbravo.retail.posterminal Changeset: 2cbfb08264a0dfaf4daffecb9a98b04b7846ee4e Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com> Date: Thu Feb 04 20:17:44 2016 +0100 URL: http://code.openbravo.com/retail/backports/3.0RR16Q1/org.openbravo.retail.posterminal/rev/2cbfb08264a0dfaf4daffecb9a98b04b7846ee4e [^] Related to issue 31846 backport of issue 31842: Module Script has been compiled using java6 --- M build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue31842.class M build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue31842Data.class --- |
|
(0084696) marvintm (manager) 2016-03-03 17:48 |
After this fix, there is a way to reproduce a problem with the error messages in the payment tab: - Configure the Cash payment to have a change limit of 10 - Create several tickets for value greater than 10 (so that we ensure that we have enough cash in the till for the test). - Create a new ticket for value 150.5. - Add payments in cash until the change is a little bit greater than 10, but less than the total cash we have in the till. - Verify that the message "Overpayment exceeded limit" is shown. This is correct. - However, the message "There is not enough cash available" is also shown, even though we have enough cash in the till, and this is not correct. |
|
(0084728) hgbot (developer) 2016-03-04 12:40 |
Repository: retail/backports/3.0RR16Q1/org.openbravo.retail.posterminal Changeset: ba0181d97e19abb8839106816e8f14d28bddbe02 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Fri Mar 04 17:09:06 2016 +0530 URL: http://code.openbravo.com/retail/backports/3.0RR16Q1/org.openbravo.retail.posterminal/rev/ba0181d97e19abb8839106816e8f14d28bddbe02 [^] Fixes issue 31846 : Verify Not enough cash available label based on payments --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2016-01-08 14:32 | Orekaria | Type | defect => backport |
| 2016-01-08 14:32 | Orekaria | Target Version | => RR16Q1.1 |
| 2016-01-15 12:50 | Orekaria | Target Version | RR16Q1.1 => RR16Q1 |
| 2016-02-09 14:12 | guillermogil | Issue Monitored: guillermogil | |
| 2016-02-15 16:08 | hgbot | Checkin | |
| 2016-02-15 16:08 | hgbot | Note Added: 0084193 | |
| 2016-02-15 16:08 | hgbot | Status | scheduled => resolved |
| 2016-02-15 16:08 | hgbot | Resolution | open => fixed |
| 2016-02-15 16:08 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/retail/backports/3.0RR16Q1/org.openbravo.retail.posterminal/rev/b350c4ba460ff8e446de614b543830e6723c90f7 [^] |
| 2016-02-15 16:08 | hgbot | Checkin | |
| 2016-02-15 16:08 | hgbot | Note Added: 0084194 | |
| 2016-02-15 16:08 | hgbot | Checkin | |
| 2016-02-15 16:08 | hgbot | Note Added: 0084196 | |
| 2016-03-03 17:48 | marvintm | Note Added: 0084696 | |
| 2016-03-03 17:48 | marvintm | Status | resolved => new |
| 2016-03-03 17:48 | marvintm | Resolution | fixed => open |
| 2016-03-03 17:48 | marvintm | Status | new => scheduled |
| 2016-03-03 17:48 | marvintm | Assigned To | Retail => guilleaer |
| 2016-03-04 10:14 | Orekaria | Status | scheduled => acknowledged |
| 2016-03-04 10:14 | Orekaria | Status | acknowledged => scheduled |
| 2016-03-04 10:14 | Orekaria | Assigned To | guilleaer => ranjith_qualiantech_com |
| 2016-03-04 12:40 | hgbot | Checkin | |
| 2016-03-04 12:40 | hgbot | Note Added: 0084728 | |
| 2016-03-04 12:40 | hgbot | Status | scheduled => resolved |
| 2016-03-04 12:40 | hgbot | Resolution | open => fixed |
| 2016-03-04 12:40 | hgbot | Fixed in SCM revision | http://code.openbravo.com/retail/backports/3.0RR16Q1/org.openbravo.retail.posterminal/rev/b350c4ba460ff8e446de614b543830e6723c90f7 [^] => http://code.openbravo.com/retail/backports/3.0RR16Q1/org.openbravo.retail.posterminal/rev/ba0181d97e19abb8839106816e8f14d28bddbe02 [^] |
| 2016-03-08 17:07 | marvintm | Review Assigned To | => marvintm |
| 2016-03-08 17:07 | marvintm | Status | resolved => closed |
| 2016-03-08 17:07 | marvintm | Fixed in Version | => RR16Q1 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |