Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031846Retail ModulesWeb POSpublic2016-01-08 12:422016-03-08 17:07
Reporteradrianromero 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q1Fixed in VersionRR16Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031846: Confusing fields: 'Allow overpayment' and 'Overpayment limit'
DescriptionThese two fields were defined for the feature request: 29868: Define change limit for cash methods but its meaning are confusing.

Steps To ReproduceJust open the Terminal type windows and go to the tab "Payment Methods" where these fields are defined and to make it visible select a payment method of type "Cash".

1.- Allow overpayment is redundant. Basically if the overpayment limit is zero has the same behaviour as unchecking this field
2.- Overpayment limit actually means "Change limit" the maximum change allowed to be returned to a customer.
Proposed Solution1.- "Allow overpayment". It is redundant and can be simulated setting the limit to zero.
     RR15Q4, RR16Q1: Hide the field from the backend UI. Change WebPOS to ignore this value, assume true
     RR16Q2: Remove the field and clean up code

2.- Rename "Overpayment limit" to "Change limit"

3.- ModuleScript:
    In order to avoid garbage in the database and also protect any potential implementation that has a modified "Allow overpayment" value it must be considered to remove completely this field from the database, adjust the functionality and create an script that sets the change limit to zero in case "Allow overpayment" is unchecked.

Test cases:
- create a sale with cash and pay more. same with a non-cash payment method
- see related issue 31792. create that test
- verify that change limit is working
- adjust existing tests
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0031842 closed ranjith_qualiantech_com Confusing fields: 'Allow overpayment' and 'Overpayment limit' 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-01-08 14:32OrekariaTypedefect => backport
2016-01-08 14:32OrekariaTarget Version => RR16Q1.1
2016-01-15 12:50OrekariaTarget VersionRR16Q1.1 => RR16Q1
2016-02-09 14:12guillermogilIssue Monitored: guillermogil
2016-02-15 16:08hgbotCheckin
2016-02-15 16:08hgbotNote Added: 0084193
2016-02-15 16:08hgbotStatusscheduled => resolved
2016-02-15 16:08hgbotResolutionopen => fixed
2016-02-15 16:08hgbotFixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR16Q1/org.openbravo.retail.posterminal/rev/b350c4ba460ff8e446de614b543830e6723c90f7 [^]
2016-02-15 16:08hgbotCheckin
2016-02-15 16:08hgbotNote Added: 0084194
2016-02-15 16:08hgbotCheckin
2016-02-15 16:08hgbotNote Added: 0084196
2016-03-03 17:48marvintmNote Added: 0084696
2016-03-03 17:48marvintmStatusresolved => new
2016-03-03 17:48marvintmResolutionfixed => open
2016-03-03 17:48marvintmStatusnew => scheduled
2016-03-03 17:48marvintmAssigned ToRetail => guilleaer
2016-03-04 10:14OrekariaStatusscheduled => acknowledged
2016-03-04 10:14OrekariaStatusacknowledged => scheduled
2016-03-04 10:14OrekariaAssigned Toguilleaer => ranjith_qualiantech_com
2016-03-04 12:40hgbotCheckin
2016-03-04 12:40hgbotNote Added: 0084728
2016-03-04 12:40hgbotStatusscheduled => resolved
2016-03-04 12:40hgbotResolutionopen => fixed
2016-03-04 12:40hgbotFixed in SCM revisionhttp://code.openbravo.com/retail/backports/3.0RR16Q1/org.openbravo.retail.posterminal/rev/b350c4ba460ff8e446de614b543830e6723c90f7 [^] => http://code.openbravo.com/retail/backports/3.0RR16Q1/org.openbravo.retail.posterminal/rev/ba0181d97e19abb8839106816e8f14d28bddbe02 [^]
2016-03-08 17:07marvintmReview Assigned To => marvintm
2016-03-08 17:07marvintmStatusresolved => closed
2016-03-08 17:07marvintmFixed in Version => RR16Q1

Notes
(0084193)
hgbot   
2016-02-15 16:08   
Repository: retail/backports/3.0RR16Q1/org.openbravo.retail.posterminal
Changeset: b350c4ba460ff8e446de614b543830e6723c90f7
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Feb 02 00:03:43 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q1/org.openbravo.retail.posterminal/rev/b350c4ba460ff8e446de614b543830e6723c90f7 [^]

Fixes issue 31846 backport of issue 31842: Hide field "Allow overpayment" in POS Terminal Type - Payment Method

Added Module script to update overpayment limit
Hide "Allow Overpayment" field from POS Terminal Type

starting from this issue functionality is defined by overpayment limit field value:
- null: Overpayment is allowed without any restriction
- 0: Overpayment is not allowed
- Number: Overpayment is allowed if it not reach the limit

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
A build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue31842.class
A build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue31842Data.class
A src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/FixDataIssue31842.java
A src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/FixDataIssue31842_Data.xsql
---
(0084194)
hgbot   
2016-02-15 16:08   
Repository: retail/backports/3.0RR16Q1/org.openbravo.retail.posterminal
Changeset: 481fdc5cfa088202a93945fbaf1ec6a3ade88690
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Feb 03 08:44:47 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q1/org.openbravo.retail.posterminal/rev/481fdc5cfa088202a93945fbaf1ec6a3ade88690 [^]

Related to issue 31846 backport of issue 31842: Fix license in affected files

---
M src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/FixDataIssue31842.java
M src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/FixDataIssue31842_Data.xsql
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0084196)
hgbot   
2016-02-15 16:08   
Repository: retail/backports/3.0RR16Q1/org.openbravo.retail.posterminal
Changeset: 2cbfb08264a0dfaf4daffecb9a98b04b7846ee4e
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Thu Feb 04 20:17:44 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q1/org.openbravo.retail.posterminal/rev/2cbfb08264a0dfaf4daffecb9a98b04b7846ee4e [^]

Related to issue 31846 backport of issue 31842: Module Script has been compiled using java6

---
M build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue31842.class
M build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue31842Data.class
---
(0084696)
marvintm   
2016-03-03 17:48   
After this fix, there is a way to reproduce a problem with the error messages in the payment tab:
- Configure the Cash payment to have a change limit of 10
- Create several tickets for value greater than 10 (so that we ensure that we have enough cash in the till for the test).
- Create a new ticket for value 150.5.
- Add payments in cash until the change is a little bit greater than 10, but less than the total cash we have in the till.
- Verify that the message "Overpayment exceeded limit" is shown. This is correct.
- However, the message "There is not enough cash available" is also shown, even though we have enough cash in the till, and this is not correct.
(0084728)
hgbot   
2016-03-04 12:40   
Repository: retail/backports/3.0RR16Q1/org.openbravo.retail.posterminal
Changeset: ba0181d97e19abb8839106816e8f14d28bddbe02
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Mar 04 17:09:06 2016 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR16Q1/org.openbravo.retail.posterminal/rev/ba0181d97e19abb8839106816e8f14d28bddbe02 [^]

Fixes issue 31846 : Verify Not enough cash available label based on payments

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---