Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0031819
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2016-01-04 18:372016-02-18 15:14
ReporterageteView Statuspublic 
Assigned Tomario_castello 
PriorityhighResolutionfixedFixed in VersionRR16Q2
StatusclosedFix in branchFixed in SCM revision0b74422c5204
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0031819: [SERQA 523] Generate invoices for orders is not shown when a layaway is partially paid

DescriptionIf you check the flag "generate invoices for orders" in POS terminal type, when you create a document in POS you see the flag "invoice" checked.

The problem is when you make a layaway, this flag is checked, and you do not pay it or pay it parctially, This layaways goes to the backoffice and then
you look for it in POS to finish to pay it, in this case the flag to invoice it is not checked, so if you forget to check it to be invoiced, you loose the chance to invoice it.
Steps To Reproduce1. check the flag "generate invoices for orders" in POS terminal type
2. create a layaway and pay it partially
3. recover it and see the flag to invoice is not shown
TagsSER-QA
Attached Filesdiff file icon issuePosterminal.diff [^] (1,677 bytes) 2016-01-11 18:07 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0083197)
Osmany (developer)
2016-01-11 18:08

Proposed Soluction (attached file - issuePosterminal.diff )
(0083216)
hgbot (developer)
2016-01-13 00:11

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 933ac5493f0f820bf897efa5ba4d2ebb8d2a5aa7
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Tue Jan 12 17:10:47 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/933ac5493f0f820bf897efa5ba4d2ebb8d2a5aa7 [^]

Fixed issue 31819: Added validation to load receipt

---
M src/org/openbravo/retail/posterminal/PaidReceipts.java
---
(0083357)
hgbot (developer)
2016-01-15 23:17

Repository: tools/automation/pi-mobile
Changeset: 126d071a6d835f39a1a32b69a35fbfe068a3fac7
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Fri Jan 15 16:16:58 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/126d071a6d835f39a1a32b69a35fbfe068a3fac7 [^]

Related to issue 31819: Added automated test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I31819_LayawayGenerateInvoiceOnPay.java
---
(0083420)
guilleaer (manager)
2016-01-19 21:50

Backout of this test because it is creating issues in try:

https://code.openbravo.com/tools/automation/pi-mobile/rev/ef34062e4436 [^]
(0083841)
marvintm (manager)
2016-02-02 12:31

The fix of this issue is not correct.

It's not right to use the property posTerminal.getObposTerminaltype() .isGenerateInvoice() to infer if a receipt was invoiced or not, because even if the default is to invoice all receipts, the user can always change it by clicking on the cancel button. Only the previous condition (if there is an invoice associated with the receipt) should be used to infer this.
(0084224)
hgbot (developer)
2016-02-15 20:54

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 0b74422c520413af74e3af4d05cd4bd103d92387
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Mon Feb 15 08:58:52 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0b74422c520413af74e3af4d05cd4bd103d92387 [^]

Fixed issue 31819: Restore previous changes and added validation to load layaways

---
M src/org/openbravo/retail/posterminal/PaidReceipts.java
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0084325)
hgbot (developer)
2016-02-18 15:14

Repository: tools/automation/pi-mobile
Changeset: ddae541c9de1cf137528a8b74122a50a9fc7c3d3
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Wed Feb 17 08:02:57 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/ddae541c9de1cf137528a8b74122a50a9fc7c3d3 [^]

Related to issue 31819: Added new automated test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I31819_LayawayGenerateInvoiceOnPay.java
---

- Issue History
Date Modified Username Field Change
2016-01-04 18:37 agete New Issue
2016-01-04 18:37 agete Assigned To => Retail
2016-01-04 18:37 agete Resolution time => 1453676400
2016-01-04 18:37 agete Triggers an Emergency Pack => No
2016-01-04 18:38 agete Tag Attached: SER-QA
2016-01-05 16:10 Orekaria Status new => acknowledged
2016-01-11 18:07 Osmany File Added: issuePosterminal.diff
2016-01-11 18:08 Osmany Note Added: 0083197
2016-01-11 19:18 mario_castello Assigned To Retail => mario_castello
2016-01-11 19:20 mario_castello Status acknowledged => scheduled
2016-01-13 00:11 hgbot Checkin
2016-01-13 00:11 hgbot Note Added: 0083216
2016-01-13 00:11 hgbot Status scheduled => resolved
2016-01-13 00:11 hgbot Resolution open => fixed
2016-01-13 00:11 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/933ac5493f0f820bf897efa5ba4d2ebb8d2a5aa7 [^]
2016-01-15 23:17 hgbot Checkin
2016-01-15 23:17 hgbot Note Added: 0083357
2016-01-19 21:50 guilleaer Note Added: 0083420
2016-01-20 08:41 jorge-garcia Status resolved => new
2016-01-20 08:41 jorge-garcia Resolution fixed => open
2016-01-20 08:41 jorge-garcia Status new => scheduled
2016-02-02 12:31 umartirena Issue Monitored: umartirena
2016-02-02 12:31 marvintm Note Added: 0083841
2016-02-15 20:54 hgbot Checkin
2016-02-15 20:54 hgbot Note Added: 0084224
2016-02-15 20:54 hgbot Status scheduled => resolved
2016-02-15 20:54 hgbot Resolution open => fixed
2016-02-15 20:54 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/933ac5493f0f820bf897efa5ba4d2ebb8d2a5aa7 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0b74422c520413af74e3af4d05cd4bd103d92387 [^]
2016-02-18 11:06 marvintm Review Assigned To => marvintm
2016-02-18 11:06 marvintm Status resolved => closed
2016-02-18 11:06 marvintm Fixed in Version => RR16Q2
2016-02-18 15:14 hgbot Checkin
2016-02-18 15:14 hgbot Note Added: 0084325


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker