Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031819Retail ModulesWeb POSpublic2016-01-04 18:372016-02-18 15:14
Reporteragete 
Assigned Tomario_castello 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031819: [SERQA 523] Generate invoices for orders is not shown when a layaway is partially paid
DescriptionIf you check the flag "generate invoices for orders" in POS terminal type, when you create a document in POS you see the flag "invoice" checked.

The problem is when you make a layaway, this flag is checked, and you do not pay it or pay it parctially, This layaways goes to the backoffice and then
you look for it in POS to finish to pay it, in this case the flag to invoice it is not checked, so if you forget to check it to be invoiced, you loose the chance to invoice it.
Steps To Reproduce1. check the flag "generate invoices for orders" in POS terminal type
2. create a layaway and pay it partially
3. recover it and see the flag to invoice is not shown
Proposed Solution
Additional Information
TagsSER-QA
Relationships
Attached Filesdiff issuePosterminal.diff (1,677) 2016-01-11 18:07
https://issues.openbravo.com/file_download.php?file_id=8907&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-01-04 18:37ageteNew Issue
2016-01-04 18:37ageteAssigned To => Retail
2016-01-04 18:37ageteResolution time => 1453676400
2016-01-04 18:37ageteTriggers an Emergency Pack => No
2016-01-04 18:38ageteTag Attached: SER-QA
2016-01-05 16:10OrekariaStatusnew => acknowledged
2016-01-11 18:07OsmanyFile Added: issuePosterminal.diff
2016-01-11 18:08OsmanyNote Added: 0083197
2016-01-11 19:18mario_castelloAssigned ToRetail => mario_castello
2016-01-11 19:20mario_castelloStatusacknowledged => scheduled
2016-01-13 00:11hgbotCheckin
2016-01-13 00:11hgbotNote Added: 0083216
2016-01-13 00:11hgbotStatusscheduled => resolved
2016-01-13 00:11hgbotResolutionopen => fixed
2016-01-13 00:11hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/933ac5493f0f820bf897efa5ba4d2ebb8d2a5aa7 [^]
2016-01-15 23:17hgbotCheckin
2016-01-15 23:17hgbotNote Added: 0083357
2016-01-19 21:50guilleaerNote Added: 0083420
2016-01-20 08:41jorge-garciaStatusresolved => new
2016-01-20 08:41jorge-garciaResolutionfixed => open
2016-01-20 08:41jorge-garciaStatusnew => scheduled
2016-02-02 12:31umartirenaIssue Monitored: umartirena
2016-02-02 12:31marvintmNote Added: 0083841
2016-02-15 20:54hgbotCheckin
2016-02-15 20:54hgbotNote Added: 0084224
2016-02-15 20:54hgbotStatusscheduled => resolved
2016-02-15 20:54hgbotResolutionopen => fixed
2016-02-15 20:54hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/933ac5493f0f820bf897efa5ba4d2ebb8d2a5aa7 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0b74422c520413af74e3af4d05cd4bd103d92387 [^]
2016-02-18 11:06marvintmReview Assigned To => marvintm
2016-02-18 11:06marvintmStatusresolved => closed
2016-02-18 11:06marvintmFixed in Version => RR16Q2
2016-02-18 15:14hgbotCheckin
2016-02-18 15:14hgbotNote Added: 0084325

Notes
(0083197)
Osmany   
2016-01-11 18:08   
Proposed Soluction (attached file - issuePosterminal.diff )
(0083216)
hgbot   
2016-01-13 00:11   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 933ac5493f0f820bf897efa5ba4d2ebb8d2a5aa7
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Tue Jan 12 17:10:47 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/933ac5493f0f820bf897efa5ba4d2ebb8d2a5aa7 [^]

Fixed issue 31819: Added validation to load receipt

---
M src/org/openbravo/retail/posterminal/PaidReceipts.java
---
(0083357)
hgbot   
2016-01-15 23:17   
Repository: tools/automation/pi-mobile
Changeset: 126d071a6d835f39a1a32b69a35fbfe068a3fac7
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Fri Jan 15 16:16:58 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/126d071a6d835f39a1a32b69a35fbfe068a3fac7 [^]

Related to issue 31819: Added automated test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I31819_LayawayGenerateInvoiceOnPay.java
---
(0083420)
guilleaer   
2016-01-19 21:50   
Backout of this test because it is creating issues in try:

https://code.openbravo.com/tools/automation/pi-mobile/rev/ef34062e4436 [^]
(0083841)
marvintm   
2016-02-02 12:31   
The fix of this issue is not correct.

It's not right to use the property posTerminal.getObposTerminaltype() .isGenerateInvoice() to infer if a receipt was invoiced or not, because even if the default is to invoice all receipts, the user can always change it by clicking on the cancel button. Only the previous condition (if there is an invoice associated with the receipt) should be used to infer this.
(0084224)
hgbot   
2016-02-15 20:54   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 0b74422c520413af74e3af4d05cd4bd103d92387
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Mon Feb 15 08:58:52 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0b74422c520413af74e3af4d05cd4bd103d92387 [^]

Fixed issue 31819: Restore previous changes and added validation to load layaways

---
M src/org/openbravo/retail/posterminal/PaidReceipts.java
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0084325)
hgbot   
2016-02-18 15:14   
Repository: tools/automation/pi-mobile
Changeset: ddae541c9de1cf137528a8b74122a50a9fc7c3d3
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Wed Feb 17 08:02:57 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/ddae541c9de1cf137528a8b74122a50a9fc7c3d3 [^]

Related to issue 31819: Added new automated test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I31819_LayawayGenerateInvoiceOnPay.java
---