Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0031654
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Retail Modules] Web POSminorhave not tried2015-12-07 14:512016-03-04 11:22
ReportermtaalView Statuspublic 
Assigned Tomigueldejuana 
PrioritynormalResolutionfixedFixed in VersionRR16Q2
StatusclosedFix in branchFixed in SCM revision99df6a31c9e9
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomtaal
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0031654: Ensure stable ids in docs send from WebPOS to the server

DescriptionSee wiki page:
http://wiki.openbravo.com/wiki/Projects:WebPOS_Store_Server_ensure_Same_Ids [^]
Steps To ReproduceSee wiki page.
Proposed SolutionAssign ids in webpos clients to tax lines and payments. In the OrderLoader on the server ensure stable ids for the payment and shipment headers.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0032044 closedmigueldejuana Ensure stable ids in docs send from WebPOS to the server (Payment API) 
related to defect 0032045 closedmtaal Ensure stable ids in docs send from WebPOS to the server (External Modules) 
related to defect 0032317RR16Q3 closedadrianromero Ensure stable ids in docs send from WebPOS to the server 

-  Notes
(0083410)
hgbot (developer)
2016-01-19 17:15

 Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: f5a9eaeabf4175516084760441fba74f48a677e1
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Jan 19 17:15:12 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/f5a9eaeabf4175516084760441fba74f48a677e1 [^]

related to issue 0031654: Ensure stable ids in docs send from WebPOS to the server

-Set id for terminal sessions

---
M src/org/openbravo/retail/sessions/OpenSessionPOS.java
M src/org/openbravo/retail/sessions/SessionModel.java
---
(0083764)
hgbot (developer)
2016-02-01 09:06

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 0e7024a265ffb1a6a40ff927d041d695543786b4
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Feb 01 09:05:25 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0e7024a265ffb1a6a40ff927d041d695543786b4 [^]

Fixed issue 0031654: Ensure stable ids in docs send from WebPOS to the server

Set ids of the entities before saving them. Order loader process and Cashup process.

---
M src/org/openbravo/retail/posterminal/CashCloseProcessor.java
M src/org/openbravo/retail/posterminal/OrderLoader.java
M src/org/openbravo/retail/posterminal/ProcessCashClose.java
M web/org.openbravo.retail.posterminal/js/closecash/model/cashup-model.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0084237)
dmitry_mezentsev (developer)
2016-02-16 12:22

 Not closed for 15 days!
(0084535)
mtaal (manager)
2016-02-26 08:35

 Hey,
Code reviewing, some questions come up:
- why is line.getSalesOrderLine().getId() + lineNo not enough, why add the ((ind + 1) * 10))
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0e7024a265ffb1a6a40ff927d041d695543786b4#l2.16 [^]
- Same here:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0e7024a265ffb1a6a40ff927d041d695543786b4#l2.26 [^]
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0e7024a265ffb1a6a40ff927d041d695543786b4#l2.103 [^]

- where in the client is the id of the approval set:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0e7024a265ffb1a6a40ff927d041d695543786b4#l2.183 [^]

gr. Martin
(0084555)
dmitry_mezentsev (developer)
2016-02-26 10:05

 Not closed for 25 days!
I see that some things are ongoing but do not delay any longer, please.
(0084583)
mtaal (manager)
2016-02-29 09:40

 Tested and checked in multi-server environment. Ids are indeed the same for central and store, checked with queries as shown below.

select m_inout_id from m_inout order by updated desc limit 1
--"DF9D107ACDB9F691F39F8470F6E18CD0"

select C_OrderLine_Offer_id from C_OrderLine_Offer order by updated desc limit 1
-- "8D56B79C06E83A8B8D71CA1E587F8CD5"

select C_OrderLineTax_id from C_OrderLineTax order by updated desc limit 1
-- "13DCB802F5A03D019D289B51E3756FE0"

select c_orderline_id from c_orderline order by updated desc limit 1
-- "CCC9D5D01B4231FEDBB49844558451E4"

select C_Order_id from C_Order order by updated desc limit 1
-- "DF9D107ACDB9F691F39F8470F6E18CD0"

select FIN_Payment_Schedule_id from FIN_Payment_Schedule order by updated desc limit 1
-- "DF9D107ACDB9F691F39F8470F6E18CD0"

select FIN_Payment_ScheduleDetail_id from FIN_Payment_ScheduleDetail order by updated desc limit 1
-- "002109C2020F13FF976F6C1A86098ABA"

select poss_terminalsessions_id from poss_terminalsessions order by updated desc limit 1
-- "E7A91F3B4435309AA7CAFA2874791678"
(0084601)
mtaal (manager)
2016-02-29 16:04

 Additional queries to check results:
select OBPOS_App_Cashup_id from OBPOS_App_Cashup order by updated desc limit 1
-- "9860B6AE9436DC6D44F71A64F5B664EA"

select FIN_Reconciliation_id from FIN_Reconciliation order by updated desc limit 1
(0084686)
hgbot (developer)
2016-03-03 15:17

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 99df6a31c9e935556ab2beaef8bd71a952ab9c1a
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Feb 26 11:09:18 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/99df6a31c9e935556ab2beaef8bd71a952ab9c1a [^]

Fixed issue 0031654: Ensure stable ids in docs send from WebPOS to the server

-Get rid of unnecessary code

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0084721)
mtaal (manager)
2016-03-04 11:21

 Retested with query:
select * from C_OrderLine_Offer order by updated desc limit 1
--- "38CDF8C68D06356C8E9BDE42B44A370E"
(0084722)
mtaal (manager)
2016-03-04 11:22

 Reviewed and tested

- Issue History
Date Modified Username Field Change
2015-12-07 14:51 mtaal New Issue
2015-12-07 14:51 mtaal Assigned To => migueldejuana
2015-12-07 14:51 mtaal Triggers an Emergency Pack => No
2016-01-19 17:15 hgbot Checkin
2016-01-19 17:15 hgbot Note Added: 0083410
2016-01-28 18:02 migueldejuana Relationship added related to 0032044
2016-01-28 18:04 migueldejuana Relationship added related to 0032045
2016-02-01 09:06 hgbot Checkin
2016-02-01 09:06 hgbot Note Added: 0083764
2016-02-01 09:06 hgbot Status new => resolved
2016-02-01 09:06 hgbot Resolution open => fixed
2016-02-01 09:06 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0e7024a265ffb1a6a40ff927d041d695543786b4 [^]
2016-02-01 11:56 mtaal Review Assigned To => mtaal
2016-02-16 12:22 dmitry_mezentsev Note Added: 0084237
2016-02-23 13:04 migueldejuana Relationship added related to 0032317
2016-02-26 08:35 mtaal Note Added: 0084535
2016-02-26 10:05 dmitry_mezentsev Note Added: 0084555
2016-02-29 09:40 mtaal Note Added: 0084583
2016-02-29 16:04 mtaal Note Added: 0084601
2016-03-03 15:17 hgbot Checkin
2016-03-03 15:17 hgbot Note Added: 0084686
2016-03-03 15:17 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0e7024a265ffb1a6a40ff927d041d695543786b4 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/99df6a31c9e935556ab2beaef8bd71a952ab9c1a [^]
2016-03-04 11:21 mtaal Note Added: 0084721
2016-03-04 11:22 mtaal Note Added: 0084722
2016-03-04 11:22 mtaal Status resolved => closed
2016-03-04 11:22 mtaal Fixed in Version => RR16Q2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker