Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031654Retail ModulesWeb POSpublic2015-12-07 14:512016-03-04 11:22
Reportermtaal 
Assigned Tomigueldejuana 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q2 
Merge Request Status
Review Assigned Tomtaal
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031654: Ensure stable ids in docs send from WebPOS to the server
DescriptionSee wiki page:
http://wiki.openbravo.com/wiki/Projects:WebPOS_Store_Server_ensure_Same_Ids [^]
Steps To ReproduceSee wiki page.
Proposed SolutionAssign ids in webpos clients to tax lines and payments. In the OrderLoader on the server ensure stable ids for the payment and shipment headers.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0032044 closed migueldejuana Ensure stable ids in docs send from WebPOS to the server (Payment API) 
related to defect 0032045 closed mtaal Ensure stable ids in docs send from WebPOS to the server (External Modules) 
related to defect 0032317RR16Q3 closed adrianromero Ensure stable ids in docs send from WebPOS to the server 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-12-07 14:51mtaalNew Issue
2015-12-07 14:51mtaalAssigned To => migueldejuana
2015-12-07 14:51mtaalTriggers an Emergency Pack => No
2016-01-19 17:15hgbotCheckin
2016-01-19 17:15hgbotNote Added: 0083410
2016-01-28 18:02migueldejuanaRelationship addedrelated to 0032044
2016-01-28 18:04migueldejuanaRelationship addedrelated to 0032045
2016-02-01 09:06hgbotCheckin
2016-02-01 09:06hgbotNote Added: 0083764
2016-02-01 09:06hgbotStatusnew => resolved
2016-02-01 09:06hgbotResolutionopen => fixed
2016-02-01 09:06hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0e7024a265ffb1a6a40ff927d041d695543786b4 [^]
2016-02-01 11:56mtaalReview Assigned To => mtaal
2016-02-16 12:22dmitry_mezentsevNote Added: 0084237
2016-02-23 13:04migueldejuanaRelationship addedrelated to 0032317
2016-02-26 08:35mtaalNote Added: 0084535
2016-02-26 10:05dmitry_mezentsevNote Added: 0084555
2016-02-29 09:40mtaalNote Added: 0084583
2016-02-29 16:04mtaalNote Added: 0084601
2016-03-03 15:17hgbotCheckin
2016-03-03 15:17hgbotNote Added: 0084686
2016-03-03 15:17hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0e7024a265ffb1a6a40ff927d041d695543786b4 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/99df6a31c9e935556ab2beaef8bd71a952ab9c1a [^]
2016-03-04 11:21mtaalNote Added: 0084721
2016-03-04 11:22mtaalNote Added: 0084722
2016-03-04 11:22mtaalStatusresolved => closed
2016-03-04 11:22mtaalFixed in Version => RR16Q2

Notes
(0083410)
hgbot   
2016-01-19 17:15   
Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: f5a9eaeabf4175516084760441fba74f48a677e1
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Jan 19 17:15:12 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/f5a9eaeabf4175516084760441fba74f48a677e1 [^]

related to issue 0031654: Ensure stable ids in docs send from WebPOS to the server

-Set id for terminal sessions

---
M src/org/openbravo/retail/sessions/OpenSessionPOS.java
M src/org/openbravo/retail/sessions/SessionModel.java
---
(0083764)
hgbot   
2016-02-01 09:06   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 0e7024a265ffb1a6a40ff927d041d695543786b4
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Feb 01 09:05:25 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0e7024a265ffb1a6a40ff927d041d695543786b4 [^]

Fixed issue 0031654: Ensure stable ids in docs send from WebPOS to the server

Set ids of the entities before saving them. Order loader process and Cashup process.

---
M src/org/openbravo/retail/posterminal/CashCloseProcessor.java
M src/org/openbravo/retail/posterminal/OrderLoader.java
M src/org/openbravo/retail/posterminal/ProcessCashClose.java
M web/org.openbravo.retail.posterminal/js/closecash/model/cashup-model.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0084237)
dmitry_mezentsev   
2016-02-16 12:22   
Not closed for 15 days!
(0084535)
mtaal   
2016-02-26 08:35   
Hey,
Code reviewing, some questions come up:
- why is line.getSalesOrderLine().getId() + lineNo not enough, why add the ((ind + 1) * 10))
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0e7024a265ffb1a6a40ff927d041d695543786b4#l2.16 [^]
- Same here:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0e7024a265ffb1a6a40ff927d041d695543786b4#l2.26 [^]
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0e7024a265ffb1a6a40ff927d041d695543786b4#l2.103 [^]

- where in the client is the id of the approval set:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0e7024a265ffb1a6a40ff927d041d695543786b4#l2.183 [^]

gr. Martin
(0084555)
dmitry_mezentsev   
2016-02-26 10:05   
Not closed for 25 days!
I see that some things are ongoing but do not delay any longer, please.
(0084583)
mtaal   
2016-02-29 09:40   
Tested and checked in multi-server environment. Ids are indeed the same for central and store, checked with queries as shown below.

select m_inout_id from m_inout order by updated desc limit 1
--"DF9D107ACDB9F691F39F8470F6E18CD0"

select C_OrderLine_Offer_id from C_OrderLine_Offer order by updated desc limit 1
-- "8D56B79C06E83A8B8D71CA1E587F8CD5"

select C_OrderLineTax_id from C_OrderLineTax order by updated desc limit 1
-- "13DCB802F5A03D019D289B51E3756FE0"

select c_orderline_id from c_orderline order by updated desc limit 1
-- "CCC9D5D01B4231FEDBB49844558451E4"

select C_Order_id from C_Order order by updated desc limit 1
-- "DF9D107ACDB9F691F39F8470F6E18CD0"

select FIN_Payment_Schedule_id from FIN_Payment_Schedule order by updated desc limit 1
-- "DF9D107ACDB9F691F39F8470F6E18CD0"

select FIN_Payment_ScheduleDetail_id from FIN_Payment_ScheduleDetail order by updated desc limit 1
-- "002109C2020F13FF976F6C1A86098ABA"

select poss_terminalsessions_id from poss_terminalsessions order by updated desc limit 1
-- "E7A91F3B4435309AA7CAFA2874791678"
(0084601)
mtaal   
2016-02-29 16:04   
Additional queries to check results:
select OBPOS_App_Cashup_id from OBPOS_App_Cashup order by updated desc limit 1
-- "9860B6AE9436DC6D44F71A64F5B664EA"

select FIN_Reconciliation_id from FIN_Reconciliation order by updated desc limit 1
(0084686)
hgbot   
2016-03-03 15:17   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 99df6a31c9e935556ab2beaef8bd71a952ab9c1a
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Feb 26 11:09:18 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/99df6a31c9e935556ab2beaef8bd71a952ab9c1a [^]

Fixed issue 0031654: Ensure stable ids in docs send from WebPOS to the server

-Get rid of unnecessary code

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0084721)
mtaal   
2016-03-04 11:21   
Retested with query:
select * from C_OrderLine_Offer order by updated desc limit 1
--- "38CDF8C68D06356C8E9BDE42B44A370E"
(0084722)
mtaal   
2016-03-04 11:22   
Reviewed and tested