Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0031525 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | minor | have not tried | 2015-11-18 17:52 | 2015-11-23 15:54 | |||
| Reporter | mtaal | View Status | public | |||||
| Assigned To | mtaal | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 24486a95dc59 | ||||
| Projection | none | ETA | none | Target Version | RR16Q1 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | migueldejuana | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0031525: Mobile server controller: code review comments & add trigger | |||||||
| Description | The following code review comments were received for the mobile server controller changes. They need to be visited and followed up. In addition we need to add a trigger to mobile services table for checking in-development of related module. | |||||||
| Steps To Reproduce | Things todo/change: https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/aec490774ae764d37620b2920e42c992f59c7f50 [^] Check src/org/openbravo/mobile/core/login/ContextInformation.java for hql injection Check methods of new classes in org/openbravo/mobile/core/servercontroller to see which methods can be public Enable test existing javadoc in code, to check for javadoc on new code Check usage of flush and related remarks //clean up, if the comment is needed (line marker 15.70 in changeset) Add a todo in adding http:// before localserverurl (line marker 15.52), todo to possibly add validation rule Check usage of hql query build with string concatenation instead of using hql parameters (line marker: 17.44 and 17.63 in changeset) Check usage of OBContext.setAdminMode should use the version with parameter on true | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0082047) hgbot (developer) 2015-11-22 15:49 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: 1f86d08c2174dbb8a9049c551489e78eb11b9038 Author: Martin Taal <martin.taal <at> openbravo.com> Date: Sat Nov 21 22:14:22 2015 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/1f86d08c2174dbb8a9049c551489e78eb11b9038 [^] Related to issue 31525: Mobile server controller: code review comments & add trigger Various changes covering the code review comments --- M src/org/openbravo/mobile/core/servercontroller/MobileMainServerCheck.java M src/org/openbravo/mobile/core/servercontroller/MobileServerController.java M src/org/openbravo/mobile/core/servercontroller/MobileServerJSONProcess.java M src/org/openbravo/mobile/core/servercontroller/MobileServerMessageProcessor.java M src/org/openbravo/mobile/core/servercontroller/MobileServerRequestExecutor.java M src/org/openbravo/mobile/core/servercontroller/MobileServerStatusInformation.java M src/org/openbravo/mobile/core/servercontroller/MobileServerUtils.java --- |
|
(0082048) hgbot (developer) 2015-11-22 15:49 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: 24486a95dc59dae0a567716e6791c783043877c9 Author: Martin Taal <martin.taal <at> openbravo.com> Date: Sat Nov 21 23:28:39 2015 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/24486a95dc59dae0a567716e6791c783043877c9 [^] Fixes issue 31525: Mobile server controller: code review comments & add trigger Adding module trigger --- A src-db/database/model/triggers/OBMOBC_SERVICES_MOD_TRG.xml --- |
|
(0082100) migueldejuana (developer) 2015-11-23 15:54 |
Tested and reviewed in 4881004e9775 |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2015-11-18 17:52 | mtaal | New Issue | |
| 2015-11-18 17:52 | mtaal | Assigned To | => mtaal |
| 2015-11-18 17:52 | mtaal | Triggers an Emergency Pack | => No |
| 2015-11-19 12:10 | mtaal | Relationship added | related to 0030319 |
| 2015-11-20 10:40 | mtaal | Status | new => scheduled |
| 2015-11-20 11:57 | mtaal | Review Assigned To | => migueldejuana |
| 2015-11-22 15:49 | hgbot | Checkin | |
| 2015-11-22 15:49 | hgbot | Note Added: 0082047 | |
| 2015-11-22 15:49 | hgbot | Checkin | |
| 2015-11-22 15:49 | hgbot | Note Added: 0082048 | |
| 2015-11-22 15:49 | hgbot | Status | scheduled => resolved |
| 2015-11-22 15:49 | hgbot | Resolution | open => fixed |
| 2015-11-22 15:49 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/24486a95dc59dae0a567716e6791c783043877c9 [^] |
| 2015-11-23 15:54 | migueldejuana | Note Added: 0082100 | |
| 2015-11-23 15:54 | migueldejuana | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |