Openbravo Issue Tracking System - Retail Modules | ||||||||||||
| View Issue Details | ||||||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | |||||||
| 0031525 | Retail Modules | Web POS | public | 2015-11-18 17:52 | 2015-11-23 15:54 | |||||||
| Reporter | mtaal | |||||||||||
| Assigned To | mtaal | |||||||||||
| Priority | normal | Severity | minor | Reproducibility | have not tried | |||||||
| Status | closed | Resolution | fixed | |||||||||
| Platform | OS | 5 | OS Version | |||||||||
| Product Version | ||||||||||||
| Target Version | RR16Q1 | Fixed in Version | ||||||||||
| Merge Request Status | ||||||||||||
| Review Assigned To | migueldejuana | |||||||||||
| OBNetwork customer | ||||||||||||
| Support ticket | ||||||||||||
| Regression level | ||||||||||||
| Regression date | ||||||||||||
| Regression introduced in release | ||||||||||||
| Regression introduced by commit | ||||||||||||
| Triggers an Emergency Pack | No | |||||||||||
| Summary | 0031525: Mobile server controller: code review comments & add trigger | |||||||||||
| Description | The following code review comments were received for the mobile server controller changes. They need to be visited and followed up. In addition we need to add a trigger to mobile services table for checking in-development of related module. | |||||||||||
| Steps To Reproduce | Things todo/change: https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/aec490774ae764d37620b2920e42c992f59c7f50 [^] Check src/org/openbravo/mobile/core/login/ContextInformation.java for hql injection Check methods of new classes in org/openbravo/mobile/core/servercontroller to see which methods can be public Enable test existing javadoc in code, to check for javadoc on new code Check usage of flush and related remarks //clean up, if the comment is needed (line marker 15.70 in changeset) Add a todo in adding http:// before localserverurl (line marker 15.52), todo to possibly add validation rule Check usage of hql query build with string concatenation instead of using hql parameters (line marker: 17.44 and 17.63 in changeset) Check usage of OBContext.setAdminMode should use the version with parameter on true | |||||||||||
| Proposed Solution | ||||||||||||
| Additional Information | ||||||||||||
| Tags | No tags attached. | |||||||||||
| Relationships |
| |||||||||||
| Attached Files | ||||||||||||
| Issue History | ||||||||||||
| Date Modified | Username | Field | Change | |||||||||
| 2015-11-18 17:52 | mtaal | New Issue | ||||||||||
| 2015-11-18 17:52 | mtaal | Assigned To | => mtaal | |||||||||
| 2015-11-18 17:52 | mtaal | Triggers an Emergency Pack | => No | |||||||||
| 2015-11-19 12:10 | mtaal | Relationship added | related to 0030319 | |||||||||
| 2015-11-20 10:40 | mtaal | Status | new => scheduled | |||||||||
| 2015-11-20 11:57 | mtaal | Review Assigned To | => migueldejuana | |||||||||
| 2015-11-22 15:49 | hgbot | Checkin | ||||||||||
| 2015-11-22 15:49 | hgbot | Note Added: 0082047 | ||||||||||
| 2015-11-22 15:49 | hgbot | Checkin | ||||||||||
| 2015-11-22 15:49 | hgbot | Note Added: 0082048 | ||||||||||
| 2015-11-22 15:49 | hgbot | Status | scheduled => resolved | |||||||||
| 2015-11-22 15:49 | hgbot | Resolution | open => fixed | |||||||||
| 2015-11-22 15:49 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/24486a95dc59dae0a567716e6791c783043877c9 [^] | |||||||||
| 2015-11-23 15:54 | migueldejuana | Note Added: 0082100 | ||||||||||
| 2015-11-23 15:54 | migueldejuana | Status | resolved => closed | |||||||||
| Notes | |||||
|
|
|||||
|
|
||||
|
|
|||||
|
|
||||
|
|
|||||
|
|
||||