Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0031478
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] Z. Othersminorhave not tried2015-11-14 13:112015-11-23 08:21
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in Version3.0PR16Q1
StatusclosedFix in branchFixed in SCM revisiona4983b22fd9f
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toalostale
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0031478: Cleanup warnings in code 'access static fields in a static way'

DescriptionWarnings cleanup:
Fixes up all code like the following:

with NULL being a static constant in JSONOBject class

JSONObject json = ...
json.NULL

replace by
JsonObject.NULL

to make it obvious that this is not an instance member but a static field
Steps To ReproduceAs shown by eclipse warnings of type:
Static fields should be accessed in a static way.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks feature request 0031477 newshuehner Tracking issue to reduce the huge number of eclipse warnings in pi 

-  Notes
(0081906)
hgbot (developer)
2015-11-16 19:18

Repository: erp/devel/pi
Changeset: a4983b22fd9f0ece7c8761f2bd03f390b944b321
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Sat Nov 14 13:12:53 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/a4983b22fd9f0ece7c8761f2bd03f390b944b321 [^]

Fixed 31478: Fix all warnings to access static fields in a static way.

i.e. json.NULL -> JSONObject.NULL
with NULL being a static constant in that class

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/Reconciliation.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_ReconciliationProcess.java
M modules/org.openbravo.financial.paymentreport/src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReportDao.java
M modules/org.openbravo.service.json/src/org/openbravo/service/json/DataToJsonConverter.java
---
(0082052)
alostale (manager)
2015-11-23 08:21

code reviewed

- Issue History
Date Modified Username Field Change
2015-11-14 13:11 shuehner New Issue
2015-11-14 13:11 shuehner Assigned To => shuehner
2015-11-14 13:11 shuehner Modules => Core
2015-11-14 13:11 shuehner Triggers an Emergency Pack => No
2015-11-14 13:12 shuehner Relationship added blocks 0031477
2015-11-16 14:00 shuehner Review Assigned To => alostale
2015-11-16 19:18 hgbot Checkin
2015-11-16 19:18 hgbot Note Added: 0081906
2015-11-16 19:18 hgbot Status new => resolved
2015-11-16 19:18 hgbot Resolution open => fixed
2015-11-16 19:18 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a4983b22fd9f0ece7c8761f2bd03f390b944b321 [^]
2015-11-23 08:21 alostale Note Added: 0082052
2015-11-23 08:21 alostale Status resolved => closed
2015-11-23 08:21 alostale Fixed in Version => 3.0PR16Q1


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker