Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031478Openbravo ERPZ. Otherspublic2015-11-14 13:112015-11-23 08:21
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031478: Cleanup warnings in code 'access static fields in a static way'
DescriptionWarnings cleanup:
Fixes up all code like the following:

with NULL being a static constant in JSONOBject class

JSONObject json = ...
json.NULL

replace by
JsonObject.NULL

to make it obvious that this is not an instance member but a static field
Steps To ReproduceAs shown by eclipse warnings of type:
Static fields should be accessed in a static way.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks feature request 0031477 new shuehner Tracking issue to reduce the huge number of eclipse warnings in pi 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-11-14 13:11shuehnerNew Issue
2015-11-14 13:11shuehnerAssigned To => shuehner
2015-11-14 13:11shuehnerModules => Core
2015-11-14 13:11shuehnerTriggers an Emergency Pack => No
2015-11-14 13:12shuehnerRelationship addedblocks 0031477
2015-11-16 14:00shuehnerReview Assigned To => alostale
2015-11-16 19:18hgbotCheckin
2015-11-16 19:18hgbotNote Added: 0081906
2015-11-16 19:18hgbotStatusnew => resolved
2015-11-16 19:18hgbotResolutionopen => fixed
2015-11-16 19:18hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a4983b22fd9f0ece7c8761f2bd03f390b944b321 [^]
2015-11-23 08:21alostaleNote Added: 0082052
2015-11-23 08:21alostaleStatusresolved => closed
2015-11-23 08:21alostaleFixed in Version => 3.0PR16Q1

Notes
(0081906)
hgbot   
2015-11-16 19:18   
Repository: erp/devel/pi
Changeset: a4983b22fd9f0ece7c8761f2bd03f390b944b321
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Sat Nov 14 13:12:53 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/a4983b22fd9f0ece7c8761f2bd03f390b944b321 [^]

Fixed 31478: Fix all warnings to access static fields in a static way.

i.e. json.NULL -> JSONObject.NULL
with NULL being a static constant in that class

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/Reconciliation.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_ReconciliationProcess.java
M modules/org.openbravo.financial.paymentreport/src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReportDao.java
M modules/org.openbravo.service.json/src/org/openbravo/service/json/DataToJsonConverter.java
---
(0082052)
alostale   
2015-11-23 08:21   
code reviewed