Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0031476
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminorhave not tried2015-11-13 19:352015-11-18 16:12
ReportermtaalView Statuspublic 
Assigned Tomtaal 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision9a3cdbc358a8
ProjectionnoneETAnoneTarget VersionRR16Q1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomigueldejuana
Regression levelAutomated tests
Regression date2015-11-04
Regression introduced in release
Regression introduced by commit4dc7b52e6cfa726273b469fec4eef24a022acce3
Triggers an Emergency PackNo
Summary

0031476: NPE when login request does not contain appname

DescriptionA code change was done for the related issue which caused a null value to be put in the parameters hashmap for the key _appName. This caused then a NPE later in the logic.

See the attached file.

Caused by this change:
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4dc7b52e6cfa726273b469fec4eef24a022acce3#l1.7 [^]
Steps To ReproduceSee the code change, revert it and run the orderloader.jmx from the performance project.
https://code.openbravo.com/retail/tools/ci-perf-regressiontest [^]
Proposed Solutionif the parameter _appName is not passed then don't add it to the parameters map.

No automated test needed for this, it is already covered (accidentally) by the performance test.
TagsNo tags attached.
Attached Filestxt file icon NPE.txt [^] (46,379 bytes) 2015-11-13 19:41 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
caused by defect 0031309 closedmigueldejuana [Multiserver] When Store server is up again code changed pop up is shown. 

-  Notes
(0081840)
hgbot (developer)
2015-11-13 19:41

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 9a3cdbc358a8d6dacd65bdcde7205f929e98aaed
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Nov 13 19:40:41 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/9a3cdbc358a8d6dacd65bdcde7205f929e98aaed [^]

Fixes issue 31476: NPE when login request does not contain appname
Check if parameter is passed, if so then prevent adding to a map

---
M src/org/openbravo/mobile/core/login/MobileCoreLoginHandler.java
---
(0081959)
migueldejuana (developer)
2015-11-18 16:12

Tested and reviewed in c174b1eb5637

- Issue History
Date Modified Username Field Change
2015-11-13 19:35 mtaal New Issue
2015-11-13 19:35 mtaal Assigned To => mtaal
2015-11-13 19:35 mtaal Regression level => Automated tests
2015-11-13 19:35 mtaal Regression date => 2015-11-04
2015-11-13 19:35 mtaal Regression introduced by commit => 4dc7b52e6cfa726273b469fec4eef24a022acce3
2015-11-13 19:35 mtaal Triggers an Emergency Pack => No
2015-11-13 19:36 mtaal Relationship added caused by 0031309
2015-11-13 19:36 mtaal Review Assigned To => migueldejuana
2015-11-13 19:41 hgbot Checkin
2015-11-13 19:41 hgbot Note Added: 0081840
2015-11-13 19:41 hgbot Status new => resolved
2015-11-13 19:41 hgbot Resolution open => fixed
2015-11-13 19:41 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/9a3cdbc358a8d6dacd65bdcde7205f929e98aaed [^]
2015-11-13 19:41 mtaal File Added: NPE.txt
2015-11-18 16:12 migueldejuana Note Added: 0081959
2015-11-18 16:12 migueldejuana Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker