Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031476Retail ModulesWeb POSpublic2015-11-13 19:352015-11-18 16:12
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q1Fixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerNo
Support ticket
Regression levelAutomated tests
Regression date2015-11-04
Regression introduced in release
Regression introduced by commit4dc7b52e6cfa726273b469fec4eef24a022acce3
Triggers an Emergency PackNo
Summary0031476: NPE when login request does not contain appname
DescriptionA code change was done for the related issue which caused a null value to be put in the parameters hashmap for the key _appName. This caused then a NPE later in the logic.

See the attached file.

Caused by this change:
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4dc7b52e6cfa726273b469fec4eef24a022acce3#l1.7 [^]
Steps To ReproduceSee the code change, revert it and run the orderloader.jmx from the performance project.
https://code.openbravo.com/retail/tools/ci-perf-regressiontest [^]
Proposed Solutionif the parameter _appName is not passed then don't add it to the parameters map.

No automated test needed for this, it is already covered (accidentally) by the performance test.
Additional Information
TagsNo tags attached.
Relationships
caused by defect 0031309 closed migueldejuana [Multiserver] When Store server is up again code changed pop up is shown. 
Attached Filestxt NPE.txt (46,379) 2015-11-13 19:41
https://issues.openbravo.com/file_download.php?file_id=8720&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-11-13 19:35mtaalNew Issue
2015-11-13 19:35mtaalAssigned To => mtaal
2015-11-13 19:35mtaalOBNetwork customer => No
2015-11-13 19:35mtaalRegression level => Automated tests
2015-11-13 19:35mtaalRegression date => 2015-11-04
2015-11-13 19:35mtaalRegression introduced by commit => 4dc7b52e6cfa726273b469fec4eef24a022acce3
2015-11-13 19:35mtaalTriggers an Emergency Pack => No
2015-11-13 19:36mtaalRelationship addedcaused by 0031309
2015-11-13 19:36mtaalReview Assigned To => migueldejuana
2015-11-13 19:41hgbotCheckin
2015-11-13 19:41hgbotNote Added: 0081840
2015-11-13 19:41hgbotStatusnew => resolved
2015-11-13 19:41hgbotResolutionopen => fixed
2015-11-13 19:41hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/9a3cdbc358a8d6dacd65bdcde7205f929e98aaed [^]
2015-11-13 19:41mtaalFile Added: NPE.txt
2015-11-18 16:12migueldejuanaNote Added: 0081959
2015-11-18 16:12migueldejuanaStatusresolved => closed

Notes
(0081840)
hgbot   
2015-11-13 19:41   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 9a3cdbc358a8d6dacd65bdcde7205f929e98aaed
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Nov 13 19:40:41 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/9a3cdbc358a8d6dacd65bdcde7205f929e98aaed [^]

Fixes issue 31476: NPE when login request does not contain appname
Check if parameter is passed, if so then prevent adding to a map

---
M src/org/openbravo/mobile/core/login/MobileCoreLoginHandler.java
---
(0081959)
migueldejuana   
2015-11-18 16:12   
Tested and reviewed in c174b1eb5637