0031476: NPE when login request does not contain appname

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0031476

Retail Modules

Web POS

public

2015-11-13 19:35

2015-11-18 16:12

Reporter

mtaal

Assigned To

mtaal

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

RR16Q1

Fixed in Version

Merge Request Status

Review Assigned To

migueldejuana

OBNetwork customer

Support ticket

Regression level

Automated tests

Regression date

2015-11-04

Regression introduced in release

Regression introduced by commit

4dc7b52e6cfa726273b469fec4eef24a022acce3

Triggers an Emergency Pack

Summary

0031476: NPE when login request does not contain appname

Description

A code change was done for the related issue which caused a null value to be put in the parameters hashmap for the key _appName. This caused then a NPE later in the logic.

See the attached file.

Caused by this change:
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4dc7b52e6cfa726273b469fec4eef24a022acce3#l1.7 [^]

Steps To Reproduce

See the code change, revert it and run the orderloader.jmx from the performance project.
https://code.openbravo.com/retail/tools/ci-perf-regressiontest [^]

Proposed Solution

if the parameter _appName is not passed then don't add it to the parameters map.

No automated test needed for this, it is already covered (accidentally) by the performance test.

Additional Information

Tags

No tags attached.

Relationships

caused by

defect

0031309

closed

migueldejuana

[Multiserver] When Store server is up again code changed pop up is shown.

Attached Files