Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0031446 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Openbravo ERP] A. Platform | major | have not tried | 2015-11-10 09:03 | 2015-11-16 08:53 | |||
| Reporter | mtaal | View Status | public | |||||
| Assigned To | mtaal | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR15Q3.4 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 12dfd7922c07 | ||||
| Projection | none | ETA | none | Target Version | 3.0PR15Q3.4 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | marvintm | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0031446: Import entry process can have a stopped but not deregistered thread: tickets remain in the queue | |||||||
| Description | If a low-level error occurs when processing import entries there is a possibility that the run method ([1]) in the ImportEntryProcessRunnable is exited without deregistering. [1] https://code.openbravo.com/erp/devel/pi/file/710400f71264/src/org/openbravo/service/importprocess/ImportEntryProcessor.java#l274 [^] | |||||||
| Steps To Reproduce | Force a low level exception, for example throw an exception around this line: https://code.openbravo.com/erp/devel/pi/file/710400f71264/src/org/openbravo/service/importprocess/ImportEntryProcessor.java#l375 [^] | |||||||
| Proposed Solution | Add a catch (Throwable logIt) before the finally block in this location: https://code.openbravo.com/erp/devel/pi/file/710400f71264/src/org/openbravo/service/importprocess/ImportEntryProcessor.java#l381 [^] Also add more logging statements to log errors/exceptions. Backend threads shallow exceptions/they are not logged. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0081853) hgbot (developer) 2015-11-15 12:57 |
Repository: erp/backports/3.0PR15Q3.4 Changeset: 12dfd7922c07f1b9692932cfcb1942dab0007e8d Author: Martin Taal <martin.taal <at> openbravo.com> Date: Sun Nov 15 12:49:47 2015 +0100 URL: http://code.openbravo.com/erp/backports/3.0PR15Q3.4/rev/12dfd7922c07f1b9692932cfcb1942dab0007e8d [^] Fixes issue 31446: Import entry process can have a stopped but not deregistered thread: tickets remain in the queue Added logging statements, add wait in ImportEntryManager loop, also make sure that the wait time computation does not round, add a catch block in ImportEntryProcessorRunnable, moved the inner loop to a separate method for readability --- M src/org/openbravo/service/importprocess/ImportEntryManager.java M src/org/openbravo/service/importprocess/ImportEntryProcessor.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2015-11-12 11:14 | mtaal | Type | defect => backport |
| 2015-11-12 11:14 | mtaal | Target Version | 3.0PR16Q1 => 3.0PR15Q3.4 |
| 2015-11-15 12:51 | mtaal | Review Assigned To | => marvintm |
| 2015-11-15 12:57 | hgbot | Checkin | |
| 2015-11-15 12:57 | hgbot | Note Added: 0081853 | |
| 2015-11-15 12:57 | hgbot | Status | scheduled => resolved |
| 2015-11-15 12:57 | hgbot | Resolution | open => fixed |
| 2015-11-15 12:57 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/backports/3.0PR15Q3.4/rev/12dfd7922c07f1b9692932cfcb1942dab0007e8d [^] |
| 2015-11-16 08:53 | marvintm | Status | resolved => closed |
| 2015-11-16 08:53 | marvintm | Fixed in Version | => 3.0PR15Q3.4 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |