Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031446Openbravo ERPA. Platformpublic2015-11-10 09:032015-11-16 08:53
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q3.4Fixed in Version3.0PR15Q3.4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031446: Import entry process can have a stopped but not deregistered thread: tickets remain in the queue
DescriptionIf a low-level error occurs when processing import entries there is a possibility that the run method ([1]) in the ImportEntryProcessRunnable is exited without deregistering.

[1] https://code.openbravo.com/erp/devel/pi/file/710400f71264/src/org/openbravo/service/importprocess/ImportEntryProcessor.java#l274 [^]
Steps To ReproduceForce a low level exception, for example throw an exception around this line:
https://code.openbravo.com/erp/devel/pi/file/710400f71264/src/org/openbravo/service/importprocess/ImportEntryProcessor.java#l375 [^]
Proposed SolutionAdd a catch (Throwable logIt) before the finally block in this location:
https://code.openbravo.com/erp/devel/pi/file/710400f71264/src/org/openbravo/service/importprocess/ImportEntryProcessor.java#l381 [^]

Also add more logging statements to log errors/exceptions. Backend threads shallow exceptions/they are not logged.
Additional Information
TagsNo tags attached.
Relationships
blocks defect 00314103.0PR16Q1 closed mtaal Import entry process can have a stopped but not deregistered thread: tickets remain in the queue 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-11-12 11:14mtaalTypedefect => backport
2015-11-12 11:14mtaalTarget Version3.0PR16Q1 => 3.0PR15Q3.4
2015-11-15 12:51mtaalReview Assigned To => marvintm
2015-11-15 12:57hgbotCheckin
2015-11-15 12:57hgbotNote Added: 0081853
2015-11-15 12:57hgbotStatusscheduled => resolved
2015-11-15 12:57hgbotResolutionopen => fixed
2015-11-15 12:57hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q3.4/rev/12dfd7922c07f1b9692932cfcb1942dab0007e8d [^]
2015-11-16 08:53marvintmStatusresolved => closed
2015-11-16 08:53marvintmFixed in Version => 3.0PR15Q3.4

Notes
(0081853)
hgbot   
2015-11-15 12:57   
Repository: erp/backports/3.0PR15Q3.4
Changeset: 12dfd7922c07f1b9692932cfcb1942dab0007e8d
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Nov 15 12:49:47 2015 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR15Q3.4/rev/12dfd7922c07f1b9692932cfcb1942dab0007e8d [^]

Fixes issue 31446: Import entry process can have a stopped but not deregistered thread: tickets remain in the queue
Added logging statements, add wait in ImportEntryManager loop, also make sure that the wait time computation does not round, add a catch block in ImportEntryProcessorRunnable,
moved the inner loop to a separate method for readability

---
M src/org/openbravo/service/importprocess/ImportEntryManager.java
M src/org/openbravo/service/importprocess/ImportEntryProcessor.java
---