Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0031437
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Retail Modules] Web POSminorhave not tried2015-11-12 00:352015-11-20 09:34
ReportermtaalView Statuspublic 
Assigned Tomtaal 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision31ec1b334a57
ProjectionnoneETAnoneTarget VersionRR16Q1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned ToSandrahuguet
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0031437: Do not load brand remotely, small js change

DescriptionSee commit
Steps To ReproduceSmall code change, no reproduction needed
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0081808)
hgbot (developer)
2015-11-13 10:28

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 69d99b0260b7cf8fa5fd604b923a3dd02225c315
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Thu Nov 12 00:35:37 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/69d99b0260b7cf8fa5fd604b923a3dd02225c315 [^]

Fixes issue 31437: Do not load brand remotely, small js change

---
M web/org.openbravo.retail.posterminal/js/model/brand.js
---
(0081832)
mtaal (manager)
2015-11-13 17:03

Not sure if this change is correct after all.
With this change the HV testcase starts to fail:
https://ci.openbravo.com/view/retail/job/ret-test-pgsql/lastCompletedBuild/testReport/org.openbravo.test.mobile.retail.pack.selenium.tests.highvolume/ProductCharacteristicsSearchProductChangesCharacteristic_HV/test/ [^]

Afaics brand needs to be remote as the valid brands are based on the products in the selection, and this query can only done on the server, reverting the change.
(0081833)
hgbot (developer)
2015-11-13 17:05

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 31ec1b334a57a6a19ae19098b943245d704a19ac
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Nov 13 17:04:52 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/31ec1b334a57a6a19ae19098b943245d704a19ac [^]

Fixes issue 31437: Do not load brand remotely, small js change
Reverting the change in a separate commit as it seems necessary.

---
M web/org.openbravo.retail.posterminal/js/model/brand.js
---
(0082007)
Sandrahuguet (developer)
2015-11-20 09:34

Code review + testing OK

- Issue History
Date Modified Username Field Change
2015-11-12 00:35 mtaal New Issue
2015-11-12 00:35 mtaal Assigned To => mtaal
2015-11-12 00:35 mtaal Triggers an Emergency Pack => No
2015-11-13 10:28 hgbot Checkin
2015-11-13 10:28 hgbot Note Added: 0081808
2015-11-13 10:28 hgbot Status new => resolved
2015-11-13 10:28 hgbot Resolution open => fixed
2015-11-13 10:28 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/69d99b0260b7cf8fa5fd604b923a3dd02225c315 [^]
2015-11-13 10:50 mtaal Review Assigned To => Sandrahuguet
2015-11-13 17:03 mtaal Note Added: 0081832
2015-11-13 17:03 mtaal Status resolved => new
2015-11-13 17:03 mtaal Resolution fixed => open
2015-11-13 17:05 hgbot Checkin
2015-11-13 17:05 hgbot Note Added: 0081833
2015-11-13 17:05 hgbot Status new => resolved
2015-11-13 17:05 hgbot Resolution open => fixed
2015-11-13 17:05 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/69d99b0260b7cf8fa5fd604b923a3dd02225c315 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/31ec1b334a57a6a19ae19098b943245d704a19ac [^]
2015-11-20 09:34 Sandrahuguet Note Added: 0082007
2015-11-20 09:34 Sandrahuguet Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker