Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031437Retail ModulesWeb POSpublic2015-11-12 00:352015-11-20 09:34
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q1Fixed in Version 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031437: Do not load brand remotely, small js change
DescriptionSee commit
Steps To ReproduceSmall code change, no reproduction needed
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-11-12 00:35mtaalNew Issue
2015-11-12 00:35mtaalAssigned To => mtaal
2015-11-12 00:35mtaalOBNetwork customer => No
2015-11-12 00:35mtaalTriggers an Emergency Pack => No
2015-11-13 10:28hgbotCheckin
2015-11-13 10:28hgbotNote Added: 0081808
2015-11-13 10:28hgbotStatusnew => resolved
2015-11-13 10:28hgbotResolutionopen => fixed
2015-11-13 10:28hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/69d99b0260b7cf8fa5fd604b923a3dd02225c315 [^]
2015-11-13 10:50mtaalReview Assigned To => Sandrahuguet
2015-11-13 17:03mtaalNote Added: 0081832
2015-11-13 17:03mtaalStatusresolved => new
2015-11-13 17:03mtaalResolutionfixed => open
2015-11-13 17:05hgbotCheckin
2015-11-13 17:05hgbotNote Added: 0081833
2015-11-13 17:05hgbotStatusnew => resolved
2015-11-13 17:05hgbotResolutionopen => fixed
2015-11-13 17:05hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/69d99b0260b7cf8fa5fd604b923a3dd02225c315 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/31ec1b334a57a6a19ae19098b943245d704a19ac [^]
2015-11-20 09:34SandrahuguetNote Added: 0082007
2015-11-20 09:34SandrahuguetStatusresolved => closed

Notes
(0081808)
hgbot   
2015-11-13 10:28   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 69d99b0260b7cf8fa5fd604b923a3dd02225c315
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Thu Nov 12 00:35:37 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/69d99b0260b7cf8fa5fd604b923a3dd02225c315 [^]

Fixes issue 31437: Do not load brand remotely, small js change

---
M web/org.openbravo.retail.posterminal/js/model/brand.js
---
(0081832)
mtaal   
2015-11-13 17:03   
Not sure if this change is correct after all.
With this change the HV testcase starts to fail:
https://ci.openbravo.com/view/retail/job/ret-test-pgsql/lastCompletedBuild/testReport/org.openbravo.test.mobile.retail.pack.selenium.tests.highvolume/ProductCharacteristicsSearchProductChangesCharacteristic_HV/test/ [^]

Afaics brand needs to be remote as the valid brands are based on the products in the selection, and this query can only done on the server, reverting the change.
(0081833)
hgbot   
2015-11-13 17:05   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 31ec1b334a57a6a19ae19098b943245d704a19ac
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Nov 13 17:04:52 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/31ec1b334a57a6a19ae19098b943245d704a19ac [^]

Fixes issue 31437: Do not load brand remotely, small js change
Reverting the change in a separate commit as it seems necessary.

---
M web/org.openbravo.retail.posterminal/js/model/brand.js
---
(0082007)
Sandrahuguet   
2015-11-20 09:34   
Code review + testing OK