Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0031398
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminorhave not tried2015-11-08 08:512015-12-30 23:49
ReportermtaalView Statuspublic 
Assigned Tomigueldejuana 
PrioritynormalResolutionfixedFixed in VersionRR16Q1
StatusclosedFix in branchFixed in SCM revision93cd2520e1fc
ProjectionnoneETAnoneTarget VersionRR16Q1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomtaal
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0031398: remote data queries for product and business partner show one more than the data limit

DescriptionWhen doing a remote query for product and business partners the query result is one more than the data limit.

This is probably done on the server side to check that there is more data available. But in this case the last search result should be truncated/removed, otherwise the message that there is more data can be meaningless.
Steps To ReproduceSet the limit data preferences for product and business partner to a value of 1. Search for products/bps, 2 are shown.

https://issues.openbravo.com/view.php?id=31212 [^]

http://wiki.openbravo.com/wiki/Retail:Configuration_Guide#Querying_performance [^]
Proposed SolutionSearch for one more on the server but return only the expected number
TagsNo tags attached.
Attached Filespng file icon Selection_009.png [^] (71,584 bytes) 2015-12-07 12:10

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to feature request 0031212RR16Q1 closedmigueldejuana Add a preference to control how many products/bp/address/tickets are loaded when searching 
related to defect 0031807RR16Q2 closedmigueldejuana Remote data queries for product and business partner show one more than the data limit 

-  Notes
(0081642)
hgbot (developer)
2015-11-10 12:30

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 4f1c579cd5e1ad1548cefece73d17cf24cccf370
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Nov 10 08:27:53 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4f1c579cd5e1ad1548cefece73d17cf24cccf370 [^]

Fixed issue 0031398: remote data queries for product and business partner show one more than the data limit

Remove limit+1 in ob-dal done for hgvol. It is no longer needed.

---
M web/org.openbravo.mobile.core/source/data/ob-dal.js
---
(0081847)
mtaal (manager)
2015-11-14 17:49

 Tested and reviewed
(0081848)
mtaal (manager)
2015-11-14 17:50

 I closed to quickly. I miss the message that there are more products available on the server.

I tested it by setting the limit preference to 2. But if there are more available on the server than this message should be shown.
(0082005)
hgbot (developer)
2015-11-20 09:04

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: ade47b4af9ef3de27f0a8b2afc79422e40aa8bc0
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Nov 19 12:50:20 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ade47b4af9ef3de27f0a8b2afc79422e40aa8bc0 [^]

Fixed issue 0031398: remote data queries for product and business partner show one more than the data limit

- Set limit + 1 to be able to know if there are more items to retrieve in order to show the message: Narrow the query
- Set temporal limit in the model to be able to slice the scrollabletable with that limit and show message to narrow query if is neccessary

---
M web/org.openbravo.retail.posterminal/js/components/modalpaidreceipts.js
---
(0082023)
hgbot (developer)
2015-11-20 12:38

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 904779cf159234aa8e518804c896577e578ca57f
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Nov 19 12:47:57 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/904779cf159234aa8e518804c896577e578ca57f [^]

Fixed issue 0031398: remote data queries for product and business partner show one more than the data limit

- Remove one old trigger that is not needed because previous line already launched that event
- Create a temporal limit in the model and slice the scrollabletable with that limit and show message to narrow query if is neccessary

---
M web/org.openbravo.mobile.core/source/component/ob-scrollabletable.js
M web/org.openbravo.mobile.core/source/data/ob-dal.js
M web/org.openbravo.mobile.core/source/retail/component/ob-retail-searchproductcharacteristic.js
---
(0082057)
hgbot (developer)
2015-11-23 09:26

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 93cd2520e1fcc3b7cf03d57a54a9d8acfda8f53f
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Nov 20 13:53:23 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/93cd2520e1fcc3b7cf03d57a54a9d8acfda8f53f [^]

Fixed issue 0031398: remote data queries for product and business partner show one more than the data limit

- Take into account no hgvol cases, just to show correctly narrow query message
- In case of dataLimit is -1 do not slice the collection

---
M web/org.openbravo.mobile.core/source/component/ob-scrollabletable.js
M web/org.openbravo.mobile.core/source/data/ob-dal.js
---
(0082593)
mtaal (manager)
2015-12-07 12:10

 I see the noted behavior still for customer search, so showing one too many and no message is displayed.

See the attachment. I set data limit for customers to 1 and remote customers to Y.

For products it works fine, although I don't like the message is too technical..

Please change the message to:
There is more data in the search results than can be displayed, narrow your search to get more precise results.
(or something similar, although this message is much longer so might give spacing issues, I don't think we should spend to much time on it)
(0083090)
mtaal (manager)
2015-12-30 23:48

 Fixed mostly, remaining will be done in next version
(0083091)
mtaal (manager)
2015-12-30 23:49

 Reviewed/tested, remaining topic will be done in related issue for Q2

- Issue History
Date Modified Username Field Change
2015-11-08 08:51 mtaal New Issue
2015-11-08 08:51 mtaal Assigned To => migueldejuana
2015-11-08 08:51 mtaal Triggers an Emergency Pack => No
2015-11-08 08:52 mtaal Relationship added related to 0031212
2015-11-10 12:30 hgbot Checkin
2015-11-10 12:30 hgbot Note Added: 0081642
2015-11-10 12:30 hgbot Status new => resolved
2015-11-10 12:30 hgbot Resolution open => fixed
2015-11-10 12:30 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4f1c579cd5e1ad1548cefece73d17cf24cccf370 [^]
2015-11-10 12:34 migueldejuana Review Assigned To => mtaal
2015-11-14 17:49 mtaal Note Added: 0081847
2015-11-14 17:49 mtaal Status resolved => closed
2015-11-14 17:49 mtaal Fixed in Version => RR16Q1
2015-11-14 17:50 mtaal Note Added: 0081848
2015-11-14 17:50 mtaal Status closed => new
2015-11-14 17:50 mtaal Resolution fixed => open
2015-11-14 17:50 mtaal Fixed in Version RR16Q1 =>
2015-11-20 09:04 hgbot Checkin
2015-11-20 09:04 hgbot Note Added: 0082005
2015-11-20 09:04 hgbot Status new => resolved
2015-11-20 09:04 hgbot Resolution open => fixed
2015-11-20 09:04 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4f1c579cd5e1ad1548cefece73d17cf24cccf370 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ade47b4af9ef3de27f0a8b2afc79422e40aa8bc0 [^]
2015-11-20 09:08 migueldejuana Review Assigned To mtaal => marvintm
2015-11-20 12:38 hgbot Checkin
2015-11-20 12:38 hgbot Note Added: 0082023
2015-11-20 12:38 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ade47b4af9ef3de27f0a8b2afc79422e40aa8bc0 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/904779cf159234aa8e518804c896577e578ca57f [^]
2015-11-23 09:26 hgbot Checkin
2015-11-23 09:26 hgbot Note Added: 0082057
2015-11-23 09:26 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/904779cf159234aa8e518804c896577e578ca57f [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/93cd2520e1fcc3b7cf03d57a54a9d8acfda8f53f [^]
2015-12-07 12:10 mtaal Note Added: 0082593
2015-12-07 12:10 mtaal Status resolved => new
2015-12-07 12:10 mtaal Resolution fixed => open
2015-12-07 12:10 mtaal Review Assigned To marvintm => mtaal
2015-12-07 12:10 mtaal File Added: Selection_009.png
2015-12-21 18:17 Orekaria Target Version RR16Q1 =>
2015-12-28 12:04 Orekaria Status new => scheduled
2015-12-30 16:05 Orekaria Target Version => RR16Q1
2015-12-30 23:48 mtaal Relationship added related to 0031807
2015-12-30 23:48 mtaal Note Added: 0083090
2015-12-30 23:48 mtaal Status scheduled => resolved
2015-12-30 23:48 mtaal Fixed in Version => RR16Q1
2015-12-30 23:48 mtaal Resolution open => fixed
2015-12-30 23:49 mtaal Note Added: 0083091
2015-12-30 23:49 mtaal Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker