Openbravo Issue Tracking System - Retail Modules
View Issue Details
0031398Retail ModulesWeb POSpublic2015-11-08 08:512015-12-30 23:49
mtaal 
migueldejuana 
normalminorhave not tried
closedfixed 
5
 
RR16Q1RR16Q1 
mtaal
No
0031398: remote data queries for product and business partner show one more than the data limit
When doing a remote query for product and business partners the query result is one more than the data limit.

This is probably done on the server side to check that there is more data available. But in this case the last search result should be truncated/removed, otherwise the message that there is more data can be meaningless.
Set the limit data preferences for product and business partner to a value of 1. Search for products/bps, 2 are shown.

https://issues.openbravo.com/view.php?id=31212 [^]

http://wiki.openbravo.com/wiki/Retail:Configuration_Guide#Querying_performance [^]
Search for one more on the server but return only the expected number
No tags attached.
related to feature request 0031212RR16Q1 closed migueldejuana Add a preference to control how many products/bp/address/tickets are loaded when searching 
related to defect 0031807RR16Q2 closed migueldejuana Remote data queries for product and business partner show one more than the data limit 
png Selection_009.png (71,584) 2015-12-07 12:10
https://issues.openbravo.com/file_download.php?file_id=8782&type=bug
png
Issue History
2015-11-08 08:51mtaalNew Issue
2015-11-08 08:51mtaalAssigned To => migueldejuana
2015-11-08 08:51mtaalTriggers an Emergency Pack => No
2015-11-08 08:52mtaalRelationship addedrelated to 0031212
2015-11-10 12:30hgbotCheckin
2015-11-10 12:30hgbotNote Added: 0081642
2015-11-10 12:30hgbotStatusnew => resolved
2015-11-10 12:30hgbotResolutionopen => fixed
2015-11-10 12:30hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4f1c579cd5e1ad1548cefece73d17cf24cccf370 [^]
2015-11-10 12:34migueldejuanaReview Assigned To => mtaal
2015-11-14 17:49mtaalNote Added: 0081847
2015-11-14 17:49mtaalStatusresolved => closed
2015-11-14 17:49mtaalFixed in Version => RR16Q1
2015-11-14 17:50mtaalNote Added: 0081848
2015-11-14 17:50mtaalStatusclosed => new
2015-11-14 17:50mtaalResolutionfixed => open
2015-11-14 17:50mtaalFixed in VersionRR16Q1 =>
2015-11-20 09:04hgbotCheckin
2015-11-20 09:04hgbotNote Added: 0082005
2015-11-20 09:04hgbotStatusnew => resolved
2015-11-20 09:04hgbotResolutionopen => fixed
2015-11-20 09:04hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4f1c579cd5e1ad1548cefece73d17cf24cccf370 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ade47b4af9ef3de27f0a8b2afc79422e40aa8bc0 [^]
2015-11-20 09:08migueldejuanaReview Assigned Tomtaal => marvintm
2015-11-20 12:38hgbotCheckin
2015-11-20 12:38hgbotNote Added: 0082023
2015-11-20 12:38hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ade47b4af9ef3de27f0a8b2afc79422e40aa8bc0 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/904779cf159234aa8e518804c896577e578ca57f [^]
2015-11-23 09:26hgbotCheckin
2015-11-23 09:26hgbotNote Added: 0082057
2015-11-23 09:26hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/904779cf159234aa8e518804c896577e578ca57f [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/93cd2520e1fcc3b7cf03d57a54a9d8acfda8f53f [^]
2015-12-07 12:10mtaalNote Added: 0082593
2015-12-07 12:10mtaalStatusresolved => new
2015-12-07 12:10mtaalResolutionfixed => open
2015-12-07 12:10mtaalReview Assigned Tomarvintm => mtaal
2015-12-07 12:10mtaalFile Added: Selection_009.png
2015-12-21 18:17OrekariaTarget VersionRR16Q1 =>
2015-12-28 12:04OrekariaStatusnew => scheduled
2015-12-30 16:05OrekariaTarget Version => RR16Q1
2015-12-30 23:48mtaalRelationship addedrelated to 0031807
2015-12-30 23:48mtaalNote Added: 0083090
2015-12-30 23:48mtaalStatusscheduled => resolved
2015-12-30 23:48mtaalFixed in Version => RR16Q1
2015-12-30 23:48mtaalResolutionopen => fixed
2015-12-30 23:49mtaalNote Added: 0083091
2015-12-30 23:49mtaalStatusresolved => closed

Notes
(0081642)
hgbot   
2015-11-10 12:30   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 4f1c579cd5e1ad1548cefece73d17cf24cccf370
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Nov 10 08:27:53 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4f1c579cd5e1ad1548cefece73d17cf24cccf370 [^]

Fixed issue 0031398: remote data queries for product and business partner show one more than the data limit

Remove limit+1 in ob-dal done for hgvol. It is no longer needed.

---
M web/org.openbravo.mobile.core/source/data/ob-dal.js
---
(0081847)
mtaal   
2015-11-14 17:49   
Tested and reviewed
(0081848)
mtaal   
2015-11-14 17:50   
I closed to quickly. I miss the message that there are more products available on the server.

I tested it by setting the limit preference to 2. But if there are more available on the server than this message should be shown.
(0082005)
hgbot   
2015-11-20 09:04   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: ade47b4af9ef3de27f0a8b2afc79422e40aa8bc0
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Nov 19 12:50:20 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ade47b4af9ef3de27f0a8b2afc79422e40aa8bc0 [^]

Fixed issue 0031398: remote data queries for product and business partner show one more than the data limit

- Set limit + 1 to be able to know if there are more items to retrieve in order to show the message: Narrow the query
- Set temporal limit in the model to be able to slice the scrollabletable with that limit and show message to narrow query if is neccessary

---
M web/org.openbravo.retail.posterminal/js/components/modalpaidreceipts.js
---
(0082023)
hgbot   
2015-11-20 12:38   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 904779cf159234aa8e518804c896577e578ca57f
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Nov 19 12:47:57 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/904779cf159234aa8e518804c896577e578ca57f [^]

Fixed issue 0031398: remote data queries for product and business partner show one more than the data limit

- Remove one old trigger that is not needed because previous line already launched that event
- Create a temporal limit in the model and slice the scrollabletable with that limit and show message to narrow query if is neccessary

---
M web/org.openbravo.mobile.core/source/component/ob-scrollabletable.js
M web/org.openbravo.mobile.core/source/data/ob-dal.js
M web/org.openbravo.mobile.core/source/retail/component/ob-retail-searchproductcharacteristic.js
---
(0082057)
hgbot   
2015-11-23 09:26   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 93cd2520e1fcc3b7cf03d57a54a9d8acfda8f53f
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Nov 20 13:53:23 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/93cd2520e1fcc3b7cf03d57a54a9d8acfda8f53f [^]

Fixed issue 0031398: remote data queries for product and business partner show one more than the data limit

- Take into account no hgvol cases, just to show correctly narrow query message
- In case of dataLimit is -1 do not slice the collection

---
M web/org.openbravo.mobile.core/source/component/ob-scrollabletable.js
M web/org.openbravo.mobile.core/source/data/ob-dal.js
---
(0082593)
mtaal   
2015-12-07 12:10   
I see the noted behavior still for customer search, so showing one too many and no message is displayed.

See the attachment. I set data limit for customers to 1 and remote customers to Y.

For products it works fine, although I don't like the message is too technical..

Please change the message to:
There is more data in the search results than can be displayed, narrow your search to get more precise results.
(or something similar, although this message is much longer so might give spacing issues, I don't think we should spend to much time on it)
(0083090)
mtaal   
2015-12-30 23:48   
Fixed mostly, remaining will be done in next version
(0083091)
mtaal   
2015-12-30 23:49   
Reviewed/tested, remaining topic will be done in related issue for Q2