Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0031351
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Retail Modules] Web POSminorhave not tried2015-11-03 16:382015-11-05 14:05
ReportermtaalView Statuspublic 
Assigned ToRetail 
PrioritynormalResolutionfixedFixed in VersionRR15Q3.2
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget VersionRR15Q3.2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0031351: Many warnings in log generated by import entry code when a cashup can not be processed

DescriptionSee this log:

f760168d 2015-11-03 11:20:06,095 [Import Entry - 3] WARN org.openbravo.retail.posterminal.importprocess.CashUpImportEntryProcessor$CashUpRunnable - Session handler present after processing import entry, this indicates that the processing code does not correctly clean/close the session after its last actions. This should be fixed.
f760168d 2015-11-03 11:20:06,134 [Import Entry - 1] WARN org.openbravo.retail.posterminal.importprocess.CashUpImportEntryProcessor$CashUpRunnable - Session handler present after processing import entry, this indicates that the processing code does not correctly clean/close the session after its last actions. This should be fixed.
f760168d 2015-11-03 11:20:06,173 [Import Entry - 2] WARN org.openbravo.retail.posterminal.importprocess.CashUpImportEntryProcessor$CashUpRunnable - Session handler present after processing import entry, this indicates that the processing code does not correctly clean/close the session after its last actions. This should be fixed.
f760168d 2015-11-03 11:20:06,212 [Import Entry - 3] WARN org.openbravo.retail.posterminal.importprocess.CashUpImportEntryProcessor$CashUpRunnable - Session handler present after processing import entry, this indicates that the processing code does not correctly clean/close the session after its last actions. This should be fixed.
f760168d 2015-11-03 11:20:06,250 [Import Entry - 1] WARN org.openbravo.retail.posterminal.importprocess.CashUpImportEntryProcessor$CashUpRunnable - Session handler present after processing import entry, this indicates that the processing code does not correctly clean/close the session after its last actions. This should be fixed.
f760168d 2015-11-03 11:20:06,290 [Import Entry - 2] WARN org.openbravo.retail.posterminal.importprocess.CashUpImportEntryProcessor$CashUpRunnable - Session handler present after processing import entry, this indicates that the processing code does not correctly clean/close the session after its last actions. This should be fixed.
f760168d 2015-11-03 11:20:06,329 [Import Entry - 3] WARN org.openbravo.retail.posterminal.importprocess.CashUpImportEntryProcessor$CashUpRunnable - Session handler present after processing import entry, this indicates that the processing code does not correctly clean/close the session after its last actions. This should be fixed.
f760168d 2015-11-03 11:20:06,369 [Import Entry - 1] WARN org.openbravo.retail.posterminal.importprocess.CashUpImportEntryProcessor$CashUpRunnable - Session handler present after processing import entry, this indicates that the processing code does not correctly clean/close the session after its last actions. This should be fixed.
Steps To ReproduceCreate an entry manually in import entry window in error state
Do a cashup in webpos
it won't be processed instead the above message is shown in the code
Proposed SolutionAdd this line:

        // close and commit
        OBDal.getInstance().commitAndClose();

In case the processor code returns without committing in the following classes in the processEntry method:

CashUpImportEntryProcessor
CustomerAddrImportEntryProcessor

See OrderImportEntryProcessor.processEntry as an example
TagsNo tags attached.
Attached Filesdiff file icon 31351.diff [^] (1,410 bytes) 2015-11-04 14:30 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 0031340RR16Q1 closedmtaal Many warnings in log generated by import entry code when a cashup can not be processed 

-  Notes
(0081521)
guilleaer (manager)
2015-11-05 13:51

Repository: retail/backports/3.0RR15Q3.2/org.openbravo.retail.posterminal
Changeset: 257164ce07c59e85690926a54f9e9cb6154e27f2
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Thu Nov 05 13:49:52 2015 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR15Q3.2/org.openbravo.retail.posterminal/rev/257164ce07c59e85690926a54f9e9cb6154e27f2 [^] [^]

Fixes issue 31351: Many warnings in log generated by import entry code when a cashup can not be processed

Commit and close when returning early from processing import entry

---
M src/org/openbravo/retail/posterminal/importprocess/CashUpImportEntryProcessor.java
M src/org/openbravo/retail/posterminal/importprocess/CustomerAddrImportEntryProcessor.java
---

- Issue History
Date Modified Username Field Change
2015-11-04 09:41 mtaal Type defect => backport
2015-11-04 09:41 mtaal Target Version RR16Q1 => RR15Q3.2
2015-11-04 09:42 mtaal Assigned To mtaal => Retail
2015-11-04 14:30 mtaal File Added: 31351.diff
2015-11-05 12:19 mtaal Review Assigned To => mtaal
2015-11-05 13:51 guilleaer Note Added: 0081521
2015-11-05 13:51 guilleaer Status scheduled => resolved
2015-11-05 13:51 guilleaer Fixed in Version => RR15Q3.2
2015-11-05 13:51 guilleaer Resolution open => fixed
2015-11-05 14:05 marvintm Review Assigned To mtaal => marvintm
2015-11-05 14:05 marvintm Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker