Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031351Retail ModulesWeb POSpublic2015-11-03 16:382015-11-05 14:05
Reportermtaal 
Assigned ToRetail 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR15Q3.2Fixed in VersionRR15Q3.2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031351: Many warnings in log generated by import entry code when a cashup can not be processed
DescriptionSee this log:

f760168d 2015-11-03 11:20:06,095 [Import Entry - 3] WARN org.openbravo.retail.posterminal.importprocess.CashUpImportEntryProcessor$CashUpRunnable - Session handler present after processing import entry, this indicates that the processing code does not correctly clean/close the session after its last actions. This should be fixed.
f760168d 2015-11-03 11:20:06,134 [Import Entry - 1] WARN org.openbravo.retail.posterminal.importprocess.CashUpImportEntryProcessor$CashUpRunnable - Session handler present after processing import entry, this indicates that the processing code does not correctly clean/close the session after its last actions. This should be fixed.
f760168d 2015-11-03 11:20:06,173 [Import Entry - 2] WARN org.openbravo.retail.posterminal.importprocess.CashUpImportEntryProcessor$CashUpRunnable - Session handler present after processing import entry, this indicates that the processing code does not correctly clean/close the session after its last actions. This should be fixed.
f760168d 2015-11-03 11:20:06,212 [Import Entry - 3] WARN org.openbravo.retail.posterminal.importprocess.CashUpImportEntryProcessor$CashUpRunnable - Session handler present after processing import entry, this indicates that the processing code does not correctly clean/close the session after its last actions. This should be fixed.
f760168d 2015-11-03 11:20:06,250 [Import Entry - 1] WARN org.openbravo.retail.posterminal.importprocess.CashUpImportEntryProcessor$CashUpRunnable - Session handler present after processing import entry, this indicates that the processing code does not correctly clean/close the session after its last actions. This should be fixed.
f760168d 2015-11-03 11:20:06,290 [Import Entry - 2] WARN org.openbravo.retail.posterminal.importprocess.CashUpImportEntryProcessor$CashUpRunnable - Session handler present after processing import entry, this indicates that the processing code does not correctly clean/close the session after its last actions. This should be fixed.
f760168d 2015-11-03 11:20:06,329 [Import Entry - 3] WARN org.openbravo.retail.posterminal.importprocess.CashUpImportEntryProcessor$CashUpRunnable - Session handler present after processing import entry, this indicates that the processing code does not correctly clean/close the session after its last actions. This should be fixed.
f760168d 2015-11-03 11:20:06,369 [Import Entry - 1] WARN org.openbravo.retail.posterminal.importprocess.CashUpImportEntryProcessor$CashUpRunnable - Session handler present after processing import entry, this indicates that the processing code does not correctly clean/close the session after its last actions. This should be fixed.
Steps To ReproduceCreate an entry manually in import entry window in error state
Do a cashup in webpos
it won't be processed instead the above message is shown in the code
Proposed SolutionAdd this line:

        // close and commit
        OBDal.getInstance().commitAndClose();

In case the processor code returns without committing in the following classes in the processEntry method:

CashUpImportEntryProcessor
CustomerAddrImportEntryProcessor

See OrderImportEntryProcessor.processEntry as an example
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0031340RR16Q1 closed mtaal Many warnings in log generated by import entry code when a cashup can not be processed 
Attached Filesdiff 31351.diff (1,410) 2015-11-04 14:30
https://issues.openbravo.com/file_download.php?file_id=8687&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-11-04 09:41mtaalTypedefect => backport
2015-11-04 09:41mtaalTarget VersionRR16Q1 => RR15Q3.2
2015-11-04 09:42mtaalAssigned Tomtaal => Retail
2015-11-04 14:30mtaalFile Added: 31351.diff
2015-11-05 12:19mtaalReview Assigned To => mtaal
2015-11-05 13:51guilleaerNote Added: 0081521
2015-11-05 13:51guilleaerStatusscheduled => resolved
2015-11-05 13:51guilleaerFixed in Version => RR15Q3.2
2015-11-05 13:51guilleaerResolutionopen => fixed
2015-11-05 14:05marvintmReview Assigned Tomtaal => marvintm
2015-11-05 14:05marvintmStatusresolved => closed

Notes
(0081521)
guilleaer   
2015-11-05 13:51   
Repository: retail/backports/3.0RR15Q3.2/org.openbravo.retail.posterminal
Changeset: 257164ce07c59e85690926a54f9e9cb6154e27f2
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Thu Nov 05 13:49:52 2015 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR15Q3.2/org.openbravo.retail.posterminal/rev/257164ce07c59e85690926a54f9e9cb6154e27f2 [^] [^]

Fixes issue 31351: Many warnings in log generated by import entry code when a cashup can not be processed

Commit and close when returning early from processing import entry

---
M src/org/openbravo/retail/posterminal/importprocess/CashUpImportEntryProcessor.java
M src/org/openbravo/retail/posterminal/importprocess/CustomerAddrImportEntryProcessor.java
---