Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0031307 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | trivial | always | 2015-10-30 09:10 | 2015-11-12 17:34 | |||
| Reporter | guilleaer | View Status | public | |||||
| Assigned To | guilleaer | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR16Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 961043cf2c0e | ||||
| Projection | none | ETA | none | Target Version | RR16Q1 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | Orekaria | |||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0031307: GetOrderDescription method should give more info about the order | |||||||
| Description | GetOrderDescription method should give more info about the order | |||||||
| Steps To Reproduce | N/A | |||||||
| Proposed Solution | extend method to give more details | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0081396) hgbot (developer) 2015-10-30 09:15 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 961043cf2c0e00c507185d19d90b148b79f5c80a Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com> Date: Fri Oct 30 09:13:32 2015 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/961043cf2c0e00c507185d19d90b148b79f5c80a [^] fixed issue 31307: Improve order info provided by getOrderDescription method --- M web/org.openbravo.retail.posterminal/js/data/dataordersave.js M web/org.openbravo.retail.posterminal/js/model/order.js --- |
|
(0081693) Orekaria (viewer) 2015-11-11 11:22 |
A) Instead of OB.error(enyo.format("%s: [" + this.get('documentNo') + "] total gross does not equal the sum of the gross of each line. event: '%s', gross: %s, difference: %s", errorHeader, eventParams, gross, difference)); Use the enyo.format helper OB.error(enyo.format("%s: [%s] total gross does not equal the sum of the gross of each line. event: '%s', gross: %s, difference: %s", errorHeader, this.get('documentNo'), eventParams, gross, difference)); B) Please do not use \', use " instead for easier visualization or enyo.format example: instead of var desc = '{id: \'' + this.get('id') + '\', Docno: \'' + this.get('documentNo') + '\', Total gross: ' + this.get('gross') + ', Lines: ['; use var desc = "{id: '" + this.get('id') + "', Docno: '" + this.get('documentNo') + "', Total gross: " + this.get('gross') + ", Lines: ["; or var desc = enyo.format("{id: '%s', Docno: '%s', Total gross: %s, Lines: [", this.get('id'), this.get('documentNo'), this.get('gross')); |
|
(0081733) hgbot (developer) 2015-11-12 08:38 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 4b03f65025eb018aad2124f28afd765bd748191a Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com> Date: Wed Nov 11 12:20:16 2015 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4b03f65025eb018aad2124f28afd765bd748191a [^] Related to issue 31307: improve code readability --- M web/org.openbravo.retail.posterminal/js/data/dataordersave.js M web/org.openbravo.retail.posterminal/js/model/order.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2015-10-30 09:10 | guilleaer | New Issue | |
| 2015-10-30 09:10 | guilleaer | Assigned To | => guilleaer |
| 2015-10-30 09:10 | guilleaer | OBNetwork customer | => No |
| 2015-10-30 09:10 | guilleaer | Triggers an Emergency Pack | => No |
| 2015-10-30 09:15 | hgbot | Checkin | |
| 2015-10-30 09:15 | hgbot | Note Added: 0081396 | |
| 2015-10-30 09:15 | hgbot | Status | new => resolved |
| 2015-10-30 09:15 | hgbot | Resolution | open => fixed |
| 2015-10-30 09:15 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/961043cf2c0e00c507185d19d90b148b79f5c80a [^] |
| 2015-10-30 11:13 | guilleaer | Review Assigned To | => Orekaria |
| 2015-11-11 11:22 | Orekaria | Note Added: 0081693 | |
| 2015-11-11 11:22 | Orekaria | Status | resolved => new |
| 2015-11-11 11:22 | Orekaria | Resolution | fixed => open |
| 2015-11-12 08:38 | hgbot | Checkin | |
| 2015-11-12 08:38 | hgbot | Note Added: 0081733 | |
| 2015-11-12 17:34 | Orekaria | Status | new => acknowledged |
| 2015-11-12 17:34 | Orekaria | Status | acknowledged => scheduled |
| 2015-11-12 17:34 | Orekaria | Status | scheduled => resolved |
| 2015-11-12 17:34 | Orekaria | Fixed in Version | => RR16Q1 |
| 2015-11-12 17:34 | Orekaria | Resolution | open => fixed |
| 2015-11-12 17:34 | Orekaria | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |