Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031307Retail ModulesWeb POSpublic2015-10-30 09:102015-11-12 17:34
Reporterguilleaer 
Assigned Toguilleaer 
PrioritynormalSeveritytrivialReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q1Fixed in VersionRR16Q1 
Merge Request Status
Review Assigned ToOrekaria
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031307: GetOrderDescription method should give more info about the order
DescriptionGetOrderDescription method should give more info about the order
Steps To ReproduceN/A
Proposed Solutionextend method to give more details
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-10-30 09:10guilleaerNew Issue
2015-10-30 09:10guilleaerAssigned To => guilleaer
2015-10-30 09:10guilleaerTriggers an Emergency Pack => No
2015-10-30 09:15hgbotCheckin
2015-10-30 09:15hgbotNote Added: 0081396
2015-10-30 09:15hgbotStatusnew => resolved
2015-10-30 09:15hgbotResolutionopen => fixed
2015-10-30 09:15hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/961043cf2c0e00c507185d19d90b148b79f5c80a [^]
2015-10-30 11:13guilleaerReview Assigned To => Orekaria
2015-11-11 11:22OrekariaNote Added: 0081693
2015-11-11 11:22OrekariaStatusresolved => new
2015-11-11 11:22OrekariaResolutionfixed => open
2015-11-12 08:38hgbotCheckin
2015-11-12 08:38hgbotNote Added: 0081733
2015-11-12 17:34OrekariaStatusnew => acknowledged
2015-11-12 17:34OrekariaStatusacknowledged => scheduled
2015-11-12 17:34OrekariaStatusscheduled => resolved
2015-11-12 17:34OrekariaFixed in Version => RR16Q1
2015-11-12 17:34OrekariaResolutionopen => fixed
2015-11-12 17:34OrekariaStatusresolved => closed

Notes
(0081396)
hgbot   
2015-10-30 09:15   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 961043cf2c0e00c507185d19d90b148b79f5c80a
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Fri Oct 30 09:13:32 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/961043cf2c0e00c507185d19d90b148b79f5c80a [^]

fixed issue 31307: Improve order info provided by getOrderDescription method

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0081693)
Orekaria   
2015-11-11 11:22   
A)
Instead of
  OB.error(enyo.format("%s: [" + this.get('documentNo') + "] total gross does not equal the sum of the gross of each line. event: '%s', gross: %s, difference: %s", errorHeader, eventParams, gross, difference));

Use the enyo.format helper
  OB.error(enyo.format("%s: [%s] total gross does not equal the sum of the gross of each line. event: '%s', gross: %s, difference: %s", errorHeader, this.get('documentNo'), eventParams, gross, difference));

B)
Please do not use \', use " instead for easier visualization or enyo.format
example:
instead of
  var desc = '{id: \'' + this.get('id') + '\', Docno: \'' + this.get('documentNo') + '\', Total gross: ' + this.get('gross') + ', Lines: [';
use
  var desc = "{id: '" + this.get('id') + "', Docno: '" + this.get('documentNo') + "', Total gross: " + this.get('gross') + ", Lines: [";
 or
  var desc = enyo.format("{id: '%s', Docno: '%s', Total gross: %s, Lines: [", this.get('id'), this.get('documentNo'), this.get('gross'));
(0081733)
hgbot   
2015-11-12 08:38   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 4b03f65025eb018aad2124f28afd765bd748191a
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Nov 11 12:20:16 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4b03f65025eb018aad2124f28afd765bd748191a [^]

Related to issue 31307: improve code readability

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---