Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0031249
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminorhave not tried2015-10-26 14:532015-11-13 11:41
ReportermtaalView Statuspublic 
Assigned Tomigueldejuana 
PrioritynormalResolutionfixedFixed in VersionRR16Q1
StatusclosedFix in branchFixed in SCM revisionb40a1c825f77
ProjectionnoneETAnoneTarget VersionRR16Q1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomtaal
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0031249: Address popup does an additional request when selecting an address

DescriptionWhen selecting an address (click on it) the address popup does an extra request when hiding the popup. See this part of the code in the components/bplocation.js

clearAction: function () {
    this.$.bpsLocationSearchfilterText.setValue('');
    this.doSearchAction({
      locName: this.$.bpsLocationSearchfilterText.getValue()
    });
    return true;
  },

which is called from here:
  executeOnHide: function () {
    this.$.body.$.listBpsLoc.$.bpsloclistitemprinter.$.theader.$.modalBpLocScrollableHeader.clearAction();
  },

Probably it is nicer/better to clear the search results in a different way instead of doing an extra request
Steps To Reproduce- Login into webpos
- click on address button in the ticket
- search for addresses
- click on one
- see that an additional request is done
Proposed SolutionPrevent the extra request and clear the result table directly
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0031195RR16Q1 closedmigueldejuana Remote customer: search on address of customer does not return results 
related to defect 0031400RR16Q1 closedmtaal Javascript error when adding a new customer and address in remote product 
depends on backport 0031464RR15Q4 closedmigueldejuana Address popup does an additional request when selecting an address 

-  Notes
(0081393)
hgbot (developer)
2015-10-30 08:29

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 2a60176d2187d5c00c4b3dc20d43e9210750e5b2
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Oct 28 09:31:36 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2a60176d2187d5c00c4b3dc20d43e9210750e5b2 [^]

Fixed issue 0031249: Address popup does an additional request when selecting an address

It is not necessary to search onHide, just clean filter and later onShow will do the search

---
M web/org.openbravo.retail.posterminal/js/components/bplocation.js
---
(0081483)
hgbot (developer)
2015-11-04 16:56

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b40a1c825f77a453c373a1e16552abbd2f12fac1
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Nov 02 15:05:41 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b40a1c825f77a453c373a1e16552abbd2f12fac1 [^]

Fixed issue 0031249: Address popup does an additional request when selecting an address

Change label name
Remove unneeded forceInsert

---
M web/org.openbravo.retail.posterminal/js/components/bplocation.js
M web/org.openbravo.retail.posterminal/js/data/datacustomeraddrsave.js
---
(0081594)
mtaal (manager)
2015-11-08 21:02

 I am reviewing the code. The first commit seems fine and related. What is the purpose of the second commit?

gr. Martin
(0081628)
migueldejuana (developer)
2015-11-09 16:37

 Second commit add a change of a label because the label name was changed.
The other change solves a javascript error, perhaps no related to this issue. We were not saving correctly that item.
(0081638)
mtaal (manager)
2015-11-10 11:59

 Reviewed and tested

- Issue History
Date Modified Username Field Change
2015-10-26 14:53 mtaal New Issue
2015-10-26 14:53 mtaal Assigned To => migueldejuana
2015-10-26 14:53 mtaal Triggers an Emergency Pack => No
2015-10-30 08:29 hgbot Checkin
2015-10-30 08:29 hgbot Note Added: 0081393
2015-10-30 08:29 hgbot Status new => resolved
2015-10-30 08:29 hgbot Resolution open => fixed
2015-10-30 08:29 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2a60176d2187d5c00c4b3dc20d43e9210750e5b2 [^]
2015-11-02 12:35 Orekaria Status resolved => new
2015-11-02 12:35 Orekaria Resolution fixed => open
2015-11-02 12:35 Orekaria Status new => scheduled
2015-11-02 12:35 Orekaria Status scheduled => resolved
2015-11-02 12:35 Orekaria Resolution open => fixed
2015-11-02 12:36 Orekaria Relationship added related to 0031195
2015-11-04 16:56 hgbot Checkin
2015-11-04 16:56 hgbot Note Added: 0081483
2015-11-04 16:56 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2a60176d2187d5c00c4b3dc20d43e9210750e5b2 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b40a1c825f77a453c373a1e16552abbd2f12fac1 [^]
2015-11-08 09:47 mtaal Review Assigned To => mtaal
2015-11-08 21:02 mtaal Note Added: 0081594
2015-11-09 16:37 migueldejuana Note Added: 0081628
2015-11-10 11:59 mtaal Note Added: 0081638
2015-11-10 11:59 mtaal Status resolved => closed
2015-11-10 11:59 mtaal Fixed in Version => RR16Q1
2015-11-12 11:30 migueldejuana Relationship added related to 0031400
2015-11-13 11:41 Orekaria Status closed => new
2015-11-13 11:41 Orekaria Resolution fixed => open
2015-11-13 11:41 Orekaria Fixed in Version RR16Q1 =>
2015-11-13 11:41 Orekaria Status new => scheduled
2015-11-13 11:41 Orekaria Status scheduled => resolved
2015-11-13 11:41 Orekaria Fixed in Version => RR16Q1
2015-11-13 11:41 Orekaria Resolution open => fixed
2015-11-13 11:41 Orekaria Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker