Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031249Retail ModulesWeb POSpublic2015-10-26 14:532015-11-13 11:41
Reportermtaal 
Assigned Tomigueldejuana 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q1Fixed in VersionRR16Q1 
Merge Request Status
Review Assigned Tomtaal
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031249: Address popup does an additional request when selecting an address
DescriptionWhen selecting an address (click on it) the address popup does an extra request when hiding the popup. See this part of the code in the components/bplocation.js

clearAction: function () {
    this.$.bpsLocationSearchfilterText.setValue('');
    this.doSearchAction({
      locName: this.$.bpsLocationSearchfilterText.getValue()
    });
    return true;
  },

which is called from here:
  executeOnHide: function () {
    this.$.body.$.listBpsLoc.$.bpsloclistitemprinter.$.theader.$.modalBpLocScrollableHeader.clearAction();
  },

Probably it is nicer/better to clear the search results in a different way instead of doing an extra request
Steps To Reproduce- Login into webpos
- click on address button in the ticket
- search for addresses
- click on one
- see that an additional request is done
Proposed SolutionPrevent the extra request and clear the result table directly
Additional Information
TagsNo tags attached.
Relationships
related to defect 0031195RR16Q1 closed migueldejuana Remote customer: search on address of customer does not return results 
related to defect 0031400RR16Q1 closed mtaal Javascript error when adding a new customer and address in remote product 
depends on backport 0031464RR15Q4 closed migueldejuana Address popup does an additional request when selecting an address 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-10-26 14:53mtaalNew Issue
2015-10-26 14:53mtaalAssigned To => migueldejuana
2015-10-26 14:53mtaalTriggers an Emergency Pack => No
2015-10-30 08:29hgbotCheckin
2015-10-30 08:29hgbotNote Added: 0081393
2015-10-30 08:29hgbotStatusnew => resolved
2015-10-30 08:29hgbotResolutionopen => fixed
2015-10-30 08:29hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2a60176d2187d5c00c4b3dc20d43e9210750e5b2 [^]
2015-11-02 12:35OrekariaStatusresolved => new
2015-11-02 12:35OrekariaResolutionfixed => open
2015-11-02 12:35OrekariaStatusnew => scheduled
2015-11-02 12:35OrekariaStatusscheduled => resolved
2015-11-02 12:35OrekariaResolutionopen => fixed
2015-11-02 12:36OrekariaRelationship addedrelated to 0031195
2015-11-04 16:56hgbotCheckin
2015-11-04 16:56hgbotNote Added: 0081483
2015-11-04 16:56hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2a60176d2187d5c00c4b3dc20d43e9210750e5b2 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b40a1c825f77a453c373a1e16552abbd2f12fac1 [^]
2015-11-08 09:47mtaalReview Assigned To => mtaal
2015-11-08 21:02mtaalNote Added: 0081594
2015-11-09 16:37migueldejuanaNote Added: 0081628
2015-11-10 11:59mtaalNote Added: 0081638
2015-11-10 11:59mtaalStatusresolved => closed
2015-11-10 11:59mtaalFixed in Version => RR16Q1
2015-11-12 11:30migueldejuanaRelationship addedrelated to 0031400
2015-11-13 11:41OrekariaStatusclosed => new
2015-11-13 11:41OrekariaResolutionfixed => open
2015-11-13 11:41OrekariaFixed in VersionRR16Q1 =>
2015-11-13 11:41OrekariaStatusnew => scheduled
2015-11-13 11:41OrekariaStatusscheduled => resolved
2015-11-13 11:41OrekariaFixed in Version => RR16Q1
2015-11-13 11:41OrekariaResolutionopen => fixed
2015-11-13 11:41OrekariaStatusresolved => closed

Notes
(0081393)
hgbot   
2015-10-30 08:29   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 2a60176d2187d5c00c4b3dc20d43e9210750e5b2
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Oct 28 09:31:36 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2a60176d2187d5c00c4b3dc20d43e9210750e5b2 [^]

Fixed issue 0031249: Address popup does an additional request when selecting an address

It is not necessary to search onHide, just clean filter and later onShow will do the search

---
M web/org.openbravo.retail.posterminal/js/components/bplocation.js
---
(0081483)
hgbot   
2015-11-04 16:56   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b40a1c825f77a453c373a1e16552abbd2f12fac1
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Nov 02 15:05:41 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b40a1c825f77a453c373a1e16552abbd2f12fac1 [^]

Fixed issue 0031249: Address popup does an additional request when selecting an address

Change label name
Remove unneeded forceInsert

---
M web/org.openbravo.retail.posterminal/js/components/bplocation.js
M web/org.openbravo.retail.posterminal/js/data/datacustomeraddrsave.js
---
(0081594)
mtaal   
2015-11-08 21:02   
I am reviewing the code. The first commit seems fine and related. What is the purpose of the second commit?

gr. Martin
(0081628)
migueldejuana   
2015-11-09 16:37   
Second commit add a change of a label because the label name was changed.
The other change solves a javascript error, perhaps no related to this issue. We were not saving correctly that item.
(0081638)
mtaal   
2015-11-10 11:59   
Reviewed and tested