Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0031234
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Modules] SEPA Credit Transfer Customer-to-Bankmajoralways2015-10-23 09:562017-06-21 18:27
ReportermaiteView Statuspublic 
Assigned Toaferraz 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Tovmromanos
Support ticket38916
OBNetwork customerOBPS
Regression introduced in release
Summary

0031234: It would be nice to include not mandatory "NbOfTxs" and "CtrlSum" tags inside "PmtInf"

DescriptionIt would be nice to include not mandatory "NbOfTxs" and "CtrlSum" tags inside "PmtInf"
Steps To ReproduceGenerate remittance file and realize that currently these tags are not included
Proposed Solutionattached diff
TagsNo tags attached.
Attached Filesdiff file icon sepa.diff [^] (1,933 bytes) 2015-10-23 09:56 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to feature request 0036217 closedmarkmm82 Add hooks in SEPA so XML file can be modified by external modules 

-  Notes
(0083843)
vmromanos (viewer)
2016-02-02 13:09

The contribution as it is right now is very dangerous and it's not completed.

Here you have the problems detected and the proposed solutions in order to be accepted.


1. In SEPA modules we only include the mandatory fields as a general rule. The reasons are simple:
* To reduce the number of tags to be maintained to the minimum really required
This also helps us to reduce the risk of incompatibilities between different banks or countries, which has been a headache for us.
* To keep the code as much reduced and simple as possible

This contribution breaks our rule. I may imagine this is done because a concrete bank does require them even they are not set as mandatory in SEPA format. However, if we accept it, we may face the opposite problem: banks already working fine might not accept these 2 new fields.

In this case I would recommend to add a new remittance parameter where you specify whether you want to include both tags as we do for other flows [1].
The process shouldn't include these tags with the default configuration (or when the parameter does not exists because the new dataset hasn't been applied).


2. The change should be done for the two versions of SEPA we support in the module (pain.001.001.03 and pain.001.001.04).

3. It's missing the test plan. In this contribution is specially important to write a test plan that covers all the possible scenarios

4. It's missing a documentation. They should provide the text to be added here [1]




[1] http://wiki.openbravo.com/wiki/SEPA_Credit_Transfer_Customer-to-Bank/User_Documentation#Configuring_the_Remittance_Type_Parameters [^]
(0097566)
aferraz (viewer)
2017-06-21 18:27

Implemented in following module:
http://centralrepository.openbravo.com/openbravo/org.openbravo.forge.ui/sso/ForgeModuleDetail/SEPARemittance-Extensions [^]

- Issue History
Date Modified Username Field Change
2015-10-23 09:56 maite New Issue
2015-10-23 09:56 maite Assigned To => Triage Finance
2015-10-23 09:56 maite File Added: sepa.diff
2015-10-23 09:56 maite Support ticket => 38916
2015-10-23 09:56 maite OBNetwork customer => Yes
2015-10-23 09:56 maite Issue Monitored: networkb
2016-01-30 12:22 vmromanos Assigned To Triage Finance => vmromanos
2016-01-30 12:22 vmromanos Status new => acknowledged
2016-02-02 13:07 vmromanos Status acknowledged => scheduled
2016-02-02 13:09 vmromanos Review Assigned To => vmromanos
2016-02-02 13:09 vmromanos Note Added: 0083843
2016-02-02 13:09 vmromanos Status scheduled => closed
2016-02-02 13:09 vmromanos Resolution open => no change required
2016-09-30 13:56 ngarcia Issue Monitored: ngarcia
2017-05-08 17:02 ngarcia Status closed => new
2017-05-08 17:02 ngarcia Resolution no change required => open
2017-06-09 09:55 vmromanos Relationship added related to 0036217
2017-06-21 18:26 aferraz Status new => scheduled
2017-06-21 18:26 aferraz Assigned To vmromanos => aferraz
2017-06-21 18:26 aferraz Status scheduled => resolved
2017-06-21 18:26 aferraz Resolution open => fixed
2017-06-21 18:27 aferraz Note Added: 0097566
2017-06-21 18:27 aferraz Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker