Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031234ModulesSEPA Credit Transfer Customer-to-Bankpublic2015-10-23 09:562017-06-21 18:27
Reportermaite 
Assigned Toaferraz 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Tovmromanos
Support ticket38916
OBNetwork customerOBPS
Regression introduced in release
Summary0031234: It would be nice to include not mandatory "NbOfTxs" and "CtrlSum" tags inside "PmtInf"
DescriptionIt would be nice to include not mandatory "NbOfTxs" and "CtrlSum" tags inside "PmtInf"
Steps To ReproduceGenerate remittance file and realize that currently these tags are not included
Proposed Solutionattached diff
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0036217 closed markmm82 Add hooks in SEPA so XML file can be modified by external modules 
Attached Filesdiff sepa.diff (1,933) 2015-10-23 09:56
https://issues.openbravo.com/file_download.php?file_id=8626&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-10-23 09:56maiteNew Issue
2015-10-23 09:56maiteAssigned To => Triage Finance
2015-10-23 09:56maiteFile Added: sepa.diff
2015-10-23 09:56maiteSupport ticket => 38916
2015-10-23 09:56maiteOBNetwork customer => Yes
2015-10-23 09:56maiteIssue Monitored: networkb
2016-01-30 12:22vmromanosAssigned ToTriage Finance => vmromanos
2016-01-30 12:22vmromanosStatusnew => acknowledged
2016-02-02 13:07vmromanosStatusacknowledged => scheduled
2016-02-02 13:09vmromanosReview Assigned To => vmromanos
2016-02-02 13:09vmromanosNote Added: 0083843
2016-02-02 13:09vmromanosStatusscheduled => closed
2016-02-02 13:09vmromanosResolutionopen => no change required
2016-09-30 13:56ngarciaIssue Monitored: ngarcia
2017-05-08 17:02ngarciaStatusclosed => new
2017-05-08 17:02ngarciaResolutionno change required => open
2017-06-09 09:55vmromanosRelationship addedrelated to 0036217
2017-06-21 18:26aferrazStatusnew => scheduled
2017-06-21 18:26aferrazAssigned Tovmromanos => aferraz
2017-06-21 18:26aferrazStatusscheduled => resolved
2017-06-21 18:26aferrazResolutionopen => fixed
2017-06-21 18:27aferrazNote Added: 0097566
2017-06-21 18:27aferrazStatusresolved => closed

Notes
(0083843)
vmromanos   
2016-02-02 13:09   
The contribution as it is right now is very dangerous and it's not completed.

Here you have the problems detected and the proposed solutions in order to be accepted.


1. In SEPA modules we only include the mandatory fields as a general rule. The reasons are simple:
* To reduce the number of tags to be maintained to the minimum really required
This also helps us to reduce the risk of incompatibilities between different banks or countries, which has been a headache for us.
* To keep the code as much reduced and simple as possible

This contribution breaks our rule. I may imagine this is done because a concrete bank does require them even they are not set as mandatory in SEPA format. However, if we accept it, we may face the opposite problem: banks already working fine might not accept these 2 new fields.

In this case I would recommend to add a new remittance parameter where you specify whether you want to include both tags as we do for other flows [1].
The process shouldn't include these tags with the default configuration (or when the parameter does not exists because the new dataset hasn't been applied).


2. The change should be done for the two versions of SEPA we support in the module (pain.001.001.03 and pain.001.001.04).

3. It's missing the test plan. In this contribution is specially important to write a test plan that covers all the possible scenarios

4. It's missing a documentation. They should provide the text to be added here [1]




[1] http://wiki.openbravo.com/wiki/SEPA_Credit_Transfer_Customer-to-Bank/User_Documentation#Configuring_the_Remittance_Type_Parameters [^]
(0097566)
aferraz   
2017-06-21 18:27   
Implemented in following module:
http://centralrepository.openbravo.com/openbravo/org.openbravo.forge.ui/sso/ForgeModuleDetail/SEPARemittance-Extensions [^]