Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0031208
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Approval process - onlinemajoralways2015-10-21 16:522016-01-22 15:32
ReporteraaroncaleroView Statuspublic 
Assigned Tomario_castello 
PrioritynormalResolutionfixedFixed in VersionRR16Q1
StatusclosedFix in branchFixed in SCM revision2a3b31384b42
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toguilleaer
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0031208: The CheckApproval process fails when there are preferences with long values

DescriptionWhen the CheckApproval process is executed, a query is performed against the ad_preference table, and the searchKey field is converted via a call to to_char.
If there is any preference with a searchKey/value longer than 4000 characters, the query fails (at least in oracle) with the following error:
ORA-22835: Buffer too small for CLOB to CHAR or BLOB to RAW conversion (actual: 10627, maximum: 4000)
Steps To ReproduceCreate a preference with a value longer than 4000 characters.
Configure some preference for web pos in a way that approval is requested for certain user, and a different user approves it (e.g. deny the Delete Line approval for vallblanca and allow it for Openbravo).
Login in web pos, create a ticket, and follow steps to show the approval popup.
Try to approve the action.
Verify in backend that the CheckApproval process has failed with the error copied above.
Proposed SolutionAttached proposed solution.
TagsNo tags attached.
Attached Filesdiff file icon Issue31208.diff [^] (747 bytes) 2015-10-21 16:52 [Show Content]
diff file icon new_Issue31208.diff [^] (749 bytes) 2015-11-04 09:21 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0081464)
aaroncalero (manager)
2015-11-04 09:22

 Uploaded new proposed solution. First solution was still failing.
(0081717)
hgbot (developer)
2015-11-11 15:35

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e606c76a9a7f35e2b25ac48f686c71651ef466e2
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Wed Nov 11 08:34:55 2015 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e606c76a9a7f35e2b25ac48f686c71651ef466e2 [^]

Fixed issue 31208: Add validation to CheckApproval

---
M src/org/openbravo/retail/posterminal/utility/CheckApproval.java
---
(0083563)
hgbot (developer)
2016-01-22 11:57

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 2a3b31384b42c2f7cbe420d2f496e49af8a5c6c3
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Wed Oct 21 16:53:28 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2a3b31384b42c2f7cbe420d2f496e49af8a5c6c3 [^]

Fixed issue 31208: The CheckApproval process fails when there are preferences with long values

---
M src/org/openbravo/retail/posterminal/utility/CheckApproval.java
---

- Issue History
Date Modified Username Field Change
2015-10-21 16:52 aaroncalero New Issue
2015-10-21 16:52 aaroncalero Assigned To => Retail
2015-10-21 16:52 aaroncalero Resolution time => 1446591600
2015-10-21 16:52 aaroncalero Triggers an Emergency Pack => No
2015-10-21 16:52 aaroncalero File Added: Issue31208.diff
2015-10-21 16:55 Orekaria Status new => acknowledged
2015-11-03 15:59 mario_castello Assigned To Retail => mario_castello
2015-11-03 15:59 mario_castello Status acknowledged => scheduled
2015-11-04 09:21 aaroncalero File Added: new_Issue31208.diff
2015-11-04 09:22 aaroncalero Note Added: 0081464
2015-11-11 15:35 hgbot Checkin
2015-11-11 15:35 hgbot Note Added: 0081717
2015-11-11 15:35 hgbot Status scheduled => resolved
2015-11-11 15:35 hgbot Resolution open => fixed
2015-11-11 15:35 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e606c76a9a7f35e2b25ac48f686c71651ef466e2 [^]
2015-11-13 13:42 guilleaer Review Assigned To => guilleaer
2015-11-13 13:42 guilleaer Status resolved => closed
2015-11-13 13:42 guilleaer Fixed in Version => RR16Q1
2016-01-22 11:57 hgbot Checkin
2016-01-22 11:57 hgbot Note Added: 0083563
2016-01-22 11:57 hgbot Status closed => resolved
2016-01-22 11:57 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e606c76a9a7f35e2b25ac48f686c71651ef466e2 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2a3b31384b42c2f7cbe420d2f496e49af8a5c6c3 [^]
2016-01-22 15:32 marvintm Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker