Openbravo Issue Tracking System - Retail Modules
View Issue Details
0031208Retail ModulesApproval process - onlinepublic2015-10-21 16:522016-01-22 15:32
aaroncalero 
mario_castello 
normalmajoralways
closedfixed 
5
 
RR16Q1 
guilleaer
No
0031208: The CheckApproval process fails when there are preferences with long values
When the CheckApproval process is executed, a query is performed against the ad_preference table, and the searchKey field is converted via a call to to_char.
If there is any preference with a searchKey/value longer than 4000 characters, the query fails (at least in oracle) with the following error:
ORA-22835: Buffer too small for CLOB to CHAR or BLOB to RAW conversion (actual: 10627, maximum: 4000)
Create a preference with a value longer than 4000 characters.
Configure some preference for web pos in a way that approval is requested for certain user, and a different user approves it (e.g. deny the Delete Line approval for vallblanca and allow it for Openbravo).
Login in web pos, create a ticket, and follow steps to show the approval popup.
Try to approve the action.
Verify in backend that the CheckApproval process has failed with the error copied above.
Attached proposed solution.
No tags attached.
diff Issue31208.diff (747) 2015-10-21 16:52
https://issues.openbravo.com/file_download.php?file_id=8615&type=bug
diff new_Issue31208.diff (749) 2015-11-04 09:21
https://issues.openbravo.com/file_download.php?file_id=8686&type=bug
Issue History
2015-10-21 16:52aaroncaleroNew Issue
2015-10-21 16:52aaroncaleroAssigned To => Retail
2015-10-21 16:52aaroncaleroResolution time => 1446591600
2015-10-21 16:52aaroncaleroTriggers an Emergency Pack => No
2015-10-21 16:52aaroncaleroFile Added: Issue31208.diff
2015-10-21 16:55OrekariaStatusnew => acknowledged
2015-11-03 15:59mario_castelloAssigned ToRetail => mario_castello
2015-11-03 15:59mario_castelloStatusacknowledged => scheduled
2015-11-04 09:21aaroncaleroFile Added: new_Issue31208.diff
2015-11-04 09:22aaroncaleroNote Added: 0081464
2015-11-11 15:35hgbotCheckin
2015-11-11 15:35hgbotNote Added: 0081717
2015-11-11 15:35hgbotStatusscheduled => resolved
2015-11-11 15:35hgbotResolutionopen => fixed
2015-11-11 15:35hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e606c76a9a7f35e2b25ac48f686c71651ef466e2 [^]
2015-11-13 13:42guilleaerReview Assigned To => guilleaer
2015-11-13 13:42guilleaerStatusresolved => closed
2015-11-13 13:42guilleaerFixed in Version => RR16Q1
2016-01-22 11:57hgbotCheckin
2016-01-22 11:57hgbotNote Added: 0083563
2016-01-22 11:57hgbotStatusclosed => resolved
2016-01-22 11:57hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e606c76a9a7f35e2b25ac48f686c71651ef466e2 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2a3b31384b42c2f7cbe420d2f496e49af8a5c6c3 [^]
2016-01-22 15:32marvintmStatusresolved => closed

Notes
(0081464)
aaroncalero   
2015-11-04 09:22   
Uploaded new proposed solution. First solution was still failing.
(0081717)
hgbot   
2015-11-11 15:35   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e606c76a9a7f35e2b25ac48f686c71651ef466e2
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Wed Nov 11 08:34:55 2015 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e606c76a9a7f35e2b25ac48f686c71651ef466e2 [^]

Fixed issue 31208: Add validation to CheckApproval

---
M src/org/openbravo/retail/posterminal/utility/CheckApproval.java
---
(0083563)
hgbot   
2016-01-22 11:57   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 2a3b31384b42c2f7cbe420d2f496e49af8a5c6c3
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Wed Oct 21 16:53:28 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2a3b31384b42c2f7cbe420d2f496e49af8a5c6c3 [^]

Fixed issue 31208: The CheckApproval process fails when there are preferences with long values

---
M src/org/openbravo/retail/posterminal/utility/CheckApproval.java
---