Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0031199 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | major | always | 2015-10-21 13:00 | 2015-12-07 13:12 | |||
| Reporter | malsasua | View Status | public | |||||
| Assigned To | fmolina | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | RR16Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 63e3335f533a | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Linux 32 bit | Database | PostgreSQL | Java version | 1.6.0_18 | |||
| OS Version | Community Appliance | Database version | 8.3.9 | Ant version | 1.7.1 | |||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | guilleaer | |||||||
| OBNetwork customer | OBPS | |||||||
| Support ticket | 37908 | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0031199: hooks in OrderLoader are not executed when the receipt is a quotation | |||||||
| Description | in this line https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/3501827e3abf/src/org/openbravo/retail/posterminal/OrderLoader.java#l376 [^] the executeHooks are inside of condition ( if (!isQuotation) ) , so the hooks are not executed when it is a quotation. It should be executed always. The preprocesses hooks (executeHooks(orderPreProcesses, jsonorder, null, null, null);) are executed always: https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/3501827e3abf/src/org/openbravo/retail/posterminal/OrderLoader.java#l161 [^] | |||||||
| Steps To Reproduce | . n/a | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0081388) hgbot (developer) 2015-10-30 00:51 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: cf4ca999ed69a7595346db7cec1e7612b8550c2b Author: Facundo Molina <fmolina <at> koodu.es> Date: Thu Oct 29 09:28:12 2015 -0300 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/cf4ca999ed69a7595346db7cec1e7612b8550c2b [^] Fixes issue 31199: execute hooks in OrderLoader even if the receipt is a quotation --- M src/org/openbravo/retail/posterminal/OrderLoader.java --- |
|
(0081389) hgbot (developer) 2015-10-30 00:53 |
Repository: tools/automation/pi-mobile Changeset: ca3c0d5622d260f176e3cf0e43e4af99ef073632 Author: Facundo Molina <fmolina <at> koodu.es> Date: Thu Oct 29 09:26:36 2015 -0300 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/ca3c0d5622d260f176e3cf0e43e4af99ef073632 [^] Related to issue 31199: test that the hooks are executed in order loader even if the receipt is a quotation --- A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I31199_ExecuteHooksInOrderLoaderEvenForQuotations.java --- |
|
(0081822) guilleaer (viewer) 2015-11-13 11:52 |
Reopened. Two main reasons: -> We cannot change the hook position in that way. It can affect to customers which are extending the application through this hook. Here a new hook should be created to be used just by quotations -> The test is OK but it doesn't cover the order loader hook. It is covering a client side hook. The name of this test is not correct. It should be changed. Apart from that a new test to verify that the new server side hook is working fine. |
|
(0082564) hgbot (developer) 2015-12-03 19:34 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 63e3335f533a3e90ea5cd58297f5fe751f6a8023 Author: Facundo Molina <fmolina <at> koodu.es> Date: Thu Dec 03 14:33:32 2015 -0300 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/63e3335f533a3e90ea5cd58297f5fe751f6a8023 [^] Fixes issue 31199: creates a new hook to be executed in the OrderLoader when the order is a quotation --- M src/org/openbravo/retail/posterminal/OrderLoader.java A src/org/openbravo/retail/posterminal/OrderLoaderHookForQuotations.java --- |
|
(0082577) hgbot (developer) 2015-12-04 17:41 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 86fdb07cad724d94a64cf18cbf87cb09cd8fb0b7 Author: Facundo Molina <fmolina <at> koodu.es> Date: Fri Dec 04 13:40:46 2015 -0300 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/86fdb07cad724d94a64cf18cbf87cb09cd8fb0b7 [^] Related to issue 31199: Corrects licence year --- M src/org/openbravo/retail/posterminal/OrderLoaderHookForQuotations.java --- |
|
(0082578) hgbot (developer) 2015-12-04 18:57 |
Repository: tools/automation/pi-mobile Changeset: 1e6e84ca3fb482b9fc480482b2a9b4a60b42690d Author: Facundo Molina <fmolina <at> koodu.es> Date: Fri Dec 04 14:56:45 2015 -0300 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/1e6e84ca3fb482b9fc480482b2a9b4a60b42690d [^] Related to issue 31199: Remove incorrect test --- R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I31199_ExecuteHooksInOrderLoaderEvenForQuotations.java --- |
|
(0082598) guilleaer (viewer) 2015-12-07 13:12 |
Documentation updated |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2015-10-21 13:00 | malsasua | New Issue | |
| 2015-10-21 13:00 | malsasua | Assigned To | => Retail |
| 2015-10-21 13:00 | malsasua | OBNetwork customer | => Yes |
| 2015-10-21 13:00 | malsasua | Support ticket | => 37908 |
| 2015-10-21 13:00 | malsasua | Resolution time | => 1448665200 |
| 2015-10-21 13:00 | malsasua | Triggers an Emergency Pack | => No |
| 2015-10-21 15:40 | Orekaria | Status | new => acknowledged |
| 2015-10-26 20:04 | fmolina | Status | acknowledged => scheduled |
| 2015-10-26 20:04 | fmolina | Assigned To | Retail => fmolina |
| 2015-10-30 00:51 | hgbot | Checkin | |
| 2015-10-30 00:51 | hgbot | Note Added: 0081388 | |
| 2015-10-30 00:51 | hgbot | Status | scheduled => resolved |
| 2015-10-30 00:51 | hgbot | Resolution | open => fixed |
| 2015-10-30 00:51 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/cf4ca999ed69a7595346db7cec1e7612b8550c2b [^] |
| 2015-10-30 00:53 | hgbot | Checkin | |
| 2015-10-30 00:53 | hgbot | Note Added: 0081389 | |
| 2015-11-02 11:32 | Orekaria | Review Assigned To | => marvintm |
| 2015-11-13 11:52 | guilleaer | Note Added: 0081822 | |
| 2015-11-13 11:52 | guilleaer | Status | resolved => new |
| 2015-11-13 11:52 | guilleaer | Resolution | fixed => open |
| 2015-11-13 11:52 | guilleaer | Status | new => scheduled |
| 2015-12-03 19:34 | hgbot | Checkin | |
| 2015-12-03 19:34 | hgbot | Note Added: 0082564 | |
| 2015-12-03 19:34 | hgbot | Status | scheduled => resolved |
| 2015-12-03 19:34 | hgbot | Resolution | open => fixed |
| 2015-12-03 19:34 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/cf4ca999ed69a7595346db7cec1e7612b8550c2b [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/63e3335f533a3e90ea5cd58297f5fe751f6a8023 [^] |
| 2015-12-04 16:33 | marvintm | Review Assigned To | marvintm => guilleaer |
| 2015-12-04 17:41 | hgbot | Checkin | |
| 2015-12-04 17:41 | hgbot | Note Added: 0082577 | |
| 2015-12-04 18:57 | hgbot | Checkin | |
| 2015-12-04 18:57 | hgbot | Note Added: 0082578 | |
| 2015-12-07 13:12 | guilleaer | Note Added: 0082598 | |
| 2015-12-07 13:12 | guilleaer | Status | resolved => closed |
| 2015-12-07 13:12 | guilleaer | Fixed in Version | => RR16Q1 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |