Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031199Retail ModulesWeb POSpublic2015-10-21 13:002015-12-07 13:12
Reportermalsasua 
Assigned Tofmolina 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Version 
Target VersionFixed in VersionRR16Q1 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerOBPS
Support ticket37908
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031199: hooks in OrderLoader are not executed when the receipt is a quotation
Descriptionin this line
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/3501827e3abf/src/org/openbravo/retail/posterminal/OrderLoader.java#l376 [^]

the executeHooks are inside of condition ( if (!isQuotation) ) , so the hooks are not executed when it is a quotation.

It should be executed always. The preprocesses hooks (executeHooks(orderPreProcesses, jsonorder, null, null, null);) are executed always:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/3501827e3abf/src/org/openbravo/retail/posterminal/OrderLoader.java#l161 [^]
Steps To Reproduce. n/a
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-10-21 13:00malsasuaNew Issue
2015-10-21 13:00malsasuaAssigned To => Retail
2015-10-21 13:00malsasuaOBNetwork customer => Yes
2015-10-21 13:00malsasuaSupport ticket => 37908
2015-10-21 13:00malsasuaResolution time => 1448665200
2015-10-21 13:00malsasuaTriggers an Emergency Pack => No
2015-10-21 15:40OrekariaStatusnew => acknowledged
2015-10-26 20:04fmolinaStatusacknowledged => scheduled
2015-10-26 20:04fmolinaAssigned ToRetail => fmolina
2015-10-30 00:51hgbotCheckin
2015-10-30 00:51hgbotNote Added: 0081388
2015-10-30 00:51hgbotStatusscheduled => resolved
2015-10-30 00:51hgbotResolutionopen => fixed
2015-10-30 00:51hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/cf4ca999ed69a7595346db7cec1e7612b8550c2b [^]
2015-10-30 00:53hgbotCheckin
2015-10-30 00:53hgbotNote Added: 0081389
2015-11-02 11:32OrekariaReview Assigned To => marvintm
2015-11-13 11:52guilleaerNote Added: 0081822
2015-11-13 11:52guilleaerStatusresolved => new
2015-11-13 11:52guilleaerResolutionfixed => open
2015-11-13 11:52guilleaerStatusnew => scheduled
2015-12-03 19:34hgbotCheckin
2015-12-03 19:34hgbotNote Added: 0082564
2015-12-03 19:34hgbotStatusscheduled => resolved
2015-12-03 19:34hgbotResolutionopen => fixed
2015-12-03 19:34hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/cf4ca999ed69a7595346db7cec1e7612b8550c2b [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/63e3335f533a3e90ea5cd58297f5fe751f6a8023 [^]
2015-12-04 16:33marvintmReview Assigned Tomarvintm => guilleaer
2015-12-04 17:41hgbotCheckin
2015-12-04 17:41hgbotNote Added: 0082577
2015-12-04 18:57hgbotCheckin
2015-12-04 18:57hgbotNote Added: 0082578
2015-12-07 13:12guilleaerNote Added: 0082598
2015-12-07 13:12guilleaerStatusresolved => closed
2015-12-07 13:12guilleaerFixed in Version => RR16Q1

Notes
(0081388)
hgbot   
2015-10-30 00:51   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: cf4ca999ed69a7595346db7cec1e7612b8550c2b
Author: Facundo Molina <fmolina <at> koodu.es>
Date: Thu Oct 29 09:28:12 2015 -0300
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/cf4ca999ed69a7595346db7cec1e7612b8550c2b [^]

Fixes issue 31199: execute hooks in OrderLoader even if the receipt is a quotation

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0081389)
hgbot   
2015-10-30 00:53   
Repository: tools/automation/pi-mobile
Changeset: ca3c0d5622d260f176e3cf0e43e4af99ef073632
Author: Facundo Molina <fmolina <at> koodu.es>
Date: Thu Oct 29 09:26:36 2015 -0300
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/ca3c0d5622d260f176e3cf0e43e4af99ef073632 [^]

Related to issue 31199: test that the hooks are executed in order loader even if the receipt is a quotation

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I31199_ExecuteHooksInOrderLoaderEvenForQuotations.java
---
(0081822)
guilleaer   
2015-11-13 11:52   
Reopened.

Two main reasons:
-> We cannot change the hook position in that way. It can affect to customers which are extending the application through this hook.

Here a new hook should be created to be used just by quotations

-> The test is OK but it doesn't cover the order loader hook. It is covering a client side hook.

The name of this test is not correct. It should be changed. Apart from that a new test to verify that the new server side hook is working fine.
(0082564)
hgbot   
2015-12-03 19:34   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 63e3335f533a3e90ea5cd58297f5fe751f6a8023
Author: Facundo Molina <fmolina <at> koodu.es>
Date: Thu Dec 03 14:33:32 2015 -0300
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/63e3335f533a3e90ea5cd58297f5fe751f6a8023 [^]

Fixes issue 31199: creates a new hook to be executed in the OrderLoader when the order is a quotation

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
A src/org/openbravo/retail/posterminal/OrderLoaderHookForQuotations.java
---
(0082577)
hgbot   
2015-12-04 17:41   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 86fdb07cad724d94a64cf18cbf87cb09cd8fb0b7
Author: Facundo Molina <fmolina <at> koodu.es>
Date: Fri Dec 04 13:40:46 2015 -0300
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/86fdb07cad724d94a64cf18cbf87cb09cd8fb0b7 [^]

Related to issue 31199: Corrects licence year

---
M src/org/openbravo/retail/posterminal/OrderLoaderHookForQuotations.java
---
(0082578)
hgbot   
2015-12-04 18:57   
Repository: tools/automation/pi-mobile
Changeset: 1e6e84ca3fb482b9fc480482b2a9b4a60b42690d
Author: Facundo Molina <fmolina <at> koodu.es>
Date: Fri Dec 04 14:56:45 2015 -0300
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/1e6e84ca3fb482b9fc480482b2a9b4a60b42690d [^]

Related to issue 31199: Remove incorrect test

---
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I31199_ExecuteHooksInOrderLoaderEvenForQuotations.java
---
(0082598)
guilleaer   
2015-12-07 13:12   
Documentation updated