Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0031115
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 07. Sales managementmajoralways2015-10-08 18:472015-11-28 15:24
ReporterngarciaView Statuspublic 
Assigned Todmiguelez 
PriorityimmediateResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisionaa0a5c2e4f93
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tovmromanos
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0031115: Ordered Quantity can be modified in delivered but not invoiced sales order line if the price is also changed

DescriptionOrdered Quantity can be modified in delivered but not invoiced sales order line if the price is also changed
Steps To ReproduceAs group admin role:
   Create a Sales Order for a product that has stock and book it
   Create a Goods Shipment from it
   Reactivate the Sales Order, decrease the quantity ordered and try to save the line. The following error message is shown:
      "Saving failed. Cannot modify an order line that has deliveries or invoices"
   Change the Net Unit Price Too and check you are able to save it
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
caused by defect 0012091 closedharikrishnan Is not possible to modify the price of a sales order line if it has been delivered 

-  Notes
(0080906)
ngarcia (developer)
2015-10-08 18:50

Please, check when solving this issue if the error message should be shown when the product is configured as Is Quantity Variable
(0082302)
dmiguelez (developer)
2015-11-24 17:18

As group admin role:
   Create a Sales Order for a product that has stock and book it
   Create a Goods Shipment from it
   Reactivate the Sales Order, decrease the quantity ordered and try to save the line. The following error message is shown:
      "Saving failed. Cannot modify an order line that has deliveries or invoices"
   Change the only Net Unit Price and check you are able to save it
   Change both the quantity and the Net Unit Price and realize that the error message is shown.
(0082430)
hgbot (developer)
2015-11-27 13:58

Repository: erp/devel/pi
Changeset: aa0a5c2e4f93dffc83bb8ae0c3e3f10f70ba0fd5
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Tue Nov 24 16:53:42 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/aa0a5c2e4f93dffc83bb8ae0c3e3f10f70ba0fd5 [^]

Fixes Issue 31115. Allow to change price of a non Invoiced Sales Order.

Previously it was fixed, but when it was done, it was allowing to change
the Sales Order Quantity when the Sales Invoice had a Goods Shipment related
and that is not right.

Changed the restriction to check changes related to prices in another
condition and allow to do this changes when the Sales Order is not
yet Invoiced, even if it has been delivered.

---
M src-db/database/model/triggers/C_ORDLINE_CHK_RESTRICTIONS_TRG.xml
---
(0082431)
vmromanos (manager)
2015-11-27 13:58

Code review + testing OK
(0082451)
hudsonbot (developer)
2015-11-28 15:24

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a30fd74371da [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2015-10-08 18:47 ngarcia New Issue
2015-10-08 18:47 ngarcia Assigned To => Triage Finance
2015-10-08 18:47 ngarcia Modules => Core
2015-10-08 18:47 ngarcia Resolution time => 1447801200
2015-10-08 18:47 ngarcia Triggers an Emergency Pack => No
2015-10-08 18:48 ngarcia Relationship added caused by 0012091
2015-10-08 18:50 ngarcia Note Added: 0080906
2015-10-08 18:57 heccam Issue Monitored: heccam
2015-11-24 17:18 dmiguelez Note Added: 0082302
2015-11-25 11:51 dmiguelez Status new => scheduled
2015-11-27 09:58 vmromanos Assigned To Triage Finance => dmiguelez
2015-11-27 13:58 hgbot Checkin
2015-11-27 13:58 hgbot Note Added: 0082430
2015-11-27 13:58 hgbot Status scheduled => resolved
2015-11-27 13:58 hgbot Resolution open => fixed
2015-11-27 13:58 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/aa0a5c2e4f93dffc83bb8ae0c3e3f10f70ba0fd5 [^]
2015-11-27 13:58 vmromanos Review Assigned To => vmromanos
2015-11-27 13:58 vmromanos Note Added: 0082431
2015-11-27 13:58 vmromanos Status resolved => closed
2015-11-28 15:24 hudsonbot Checkin
2015-11-28 15:24 hudsonbot Note Added: 0082451


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker