Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0031115Openbravo ERP07. Sales managementpublic2015-10-08 18:472015-11-28 15:24
ngarcia 
dmiguelez 
immediatemajoralways
closedfixed 
5
 
 
vmromanos
Core
No
0031115: Ordered Quantity can be modified in delivered but not invoiced sales order line if the price is also changed
Ordered Quantity can be modified in delivered but not invoiced sales order line if the price is also changed
As group admin role:
   Create a Sales Order for a product that has stock and book it
   Create a Goods Shipment from it
   Reactivate the Sales Order, decrease the quantity ordered and try to save the line. The following error message is shown:
      "Saving failed. Cannot modify an order line that has deliveries or invoices"
   Change the Net Unit Price Too and check you are able to save it
No tags attached.
caused by defect 0012091 closed harikrishnan Is not possible to modify the price of a sales order line if it has been delivered 
Issue History
2015-10-08 18:47ngarciaNew Issue
2015-10-08 18:47ngarciaAssigned To => Triage Finance
2015-10-08 18:47ngarciaModules => Core
2015-10-08 18:47ngarciaResolution time => 1447801200
2015-10-08 18:47ngarciaTriggers an Emergency Pack => No
2015-10-08 18:48ngarciaRelationship addedcaused by 0012091
2015-10-08 18:50ngarciaNote Added: 0080906
2015-10-08 18:57heccamIssue Monitored: heccam
2015-11-24 17:18dmiguelezNote Added: 0082302
2015-11-25 11:51dmiguelezStatusnew => scheduled
2015-11-27 09:58vmromanosAssigned ToTriage Finance => dmiguelez
2015-11-27 13:58hgbotCheckin
2015-11-27 13:58hgbotNote Added: 0082430
2015-11-27 13:58hgbotStatusscheduled => resolved
2015-11-27 13:58hgbotResolutionopen => fixed
2015-11-27 13:58hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/aa0a5c2e4f93dffc83bb8ae0c3e3f10f70ba0fd5 [^]
2015-11-27 13:58vmromanosReview Assigned To => vmromanos
2015-11-27 13:58vmromanosNote Added: 0082431
2015-11-27 13:58vmromanosStatusresolved => closed
2015-11-28 15:24hudsonbotCheckin
2015-11-28 15:24hudsonbotNote Added: 0082451

Notes
(0080906)
ngarcia   
2015-10-08 18:50   
Please, check when solving this issue if the error message should be shown when the product is configured as Is Quantity Variable
(0082302)
dmiguelez   
2015-11-24 17:18   
As group admin role:
   Create a Sales Order for a product that has stock and book it
   Create a Goods Shipment from it
   Reactivate the Sales Order, decrease the quantity ordered and try to save the line. The following error message is shown:
      "Saving failed. Cannot modify an order line that has deliveries or invoices"
   Change the only Net Unit Price and check you are able to save it
   Change both the quantity and the Net Unit Price and realize that the error message is shown.
(0082430)
hgbot   
2015-11-27 13:58   
Repository: erp/devel/pi
Changeset: aa0a5c2e4f93dffc83bb8ae0c3e3f10f70ba0fd5
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Tue Nov 24 16:53:42 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/aa0a5c2e4f93dffc83bb8ae0c3e3f10f70ba0fd5 [^]

Fixes Issue 31115. Allow to change price of a non Invoiced Sales Order.

Previously it was fixed, but when it was done, it was allowing to change
the Sales Order Quantity when the Sales Invoice had a Goods Shipment related
and that is not right.

Changed the restriction to check changes related to prices in another
condition and allow to do this changes when the Sales Order is not
yet Invoiced, even if it has been delivered.

---
M src-db/database/model/triggers/C_ORDLINE_CHK_RESTRICTIONS_TRG.xml
---
(0082431)
vmromanos   
2015-11-27 13:58   
Code review + testing OK
(0082451)
hudsonbot   
2015-11-28 15:24   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a30fd74371da [^]
Maturity status: Test