Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0031037 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Retail Modules] Web POS | minor | always | 2015-10-02 14:19 | 2015-10-23 12:39 | |||
| Reporter | aaroncalero | View Status | public | |||||
| Assigned To | marvintm | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR15Q4 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 7920c5770bd8 | ||||
| Projection | none | ETA | none | Target Version | RR15Q4 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | guilleaer | |||||||
| OBNetwork customer | OBPS | |||||||
| Support ticket | ||||||||
| Regression level | Code review | |||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/def6db59d486662f86abaef2ac435dca19c5db5b [^] | |||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0031037: Deprecation messages when logging in web pos | |||||||
| Description | Warning/Deprecation messages are shown on the javascript console, related to the OBPOS_PreCreateNewReceipt and OBPOS_PostCreateNewReceipt hooks. These hooks are using the old hookManager API. | |||||||
| Steps To Reproduce | Login in web pos. Create an empty receipt. Verify that the following messages are shown on the browser console: adead8f74bf0fa2fef815f78f78c7f66_WebPOS.js:2366 Deprecated (since RR14Q4): 'OB.MobileApp.model.hookManager' is a child of the model of the terminal. Please use 'OB.UTIL.HookManager' instead. More info: http://wiki.openbravo.com/wiki/How_to_Add_Hooks. [^] Hook: 'OBPOS_PreCreateNewReceipt'; line: Object.hookManager.executeHooks (https://livebuilds.openbravo.com/retail_pi_pgsql/web/js/gen/adead8f74bf0fa2fef815f78f78c7f66_WebPOS.js:5413:14 [^]) (*,+) 2015-10-02 14:17:49.018 adead8f74bf0fa2fef815f78f78c7f66_WebPOS.js:2366 Deprecated (since RR14Q4): 'OB.MobileApp.model.hookManager' is a child of the model of the terminal. Please use 'OB.UTIL.HookManager' instead. More info: http://wiki.openbravo.com/wiki/How_to_Add_Hooks. [^] Hook: 'OBPOS_PostAddNewReceipt'; line: Object.hookManager.executeHooks (https://livebuilds.openbravo.com/retail_pi_pgsql/web/js/gen/adead8f74bf0fa2fef815f78f78c7f66_WebPOS.js:5413:14 [^]) (*,+) | |||||||
| Proposed Solution | Replace the old API calls: OB.MobileApp.model.hookManager.executeHooks('OBPOS_PreCreateNewReceipt', { OB.MobileApp.model.hookManager.executeHooks('OBPOS_PostAddNewReceipt', { with: OB.UTIL.HookManager.executeHooks('OBPOS_PreCreateNewReceipt', { OB.UTIL.HookManager.executeHooks('OBPOS_PostAddNewReceipt', { | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
Notes |
|
|
(0081206) hgbot (developer) 2015-10-22 12:50 |
Repository: retail/backports/3.0RR15Q4/org.openbravo.retail.posterminal Changeset: 7920c5770bd851a68da084989c42616aa792fd9d Author: Antonio Moreno Perez <antonio.moreno <at> openbravo.com> Date: Thu Oct 22 12:49:35 2015 +0200 URL: http://code.openbravo.com/retail/backports/3.0RR15Q4/org.openbravo.retail.posterminal/rev/7920c5770bd851a68da084989c42616aa792fd9d [^] Fixed issue 31037. Hooks which were created using an old API now are using the current API --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js --- |
|
(0081257) guilleaer (viewer) 2015-10-23 12:39 |
Code reviewed and tested |
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2015-10-02 16:08 | Orekaria | Type | defect => backport |
| 2015-10-02 16:08 | Orekaria | Target Version | => RR15Q4.1 |
| 2015-10-19 14:38 | Orekaria | Target Version | RR15Q4.1 => RR15Q4 |
| 2015-10-22 12:50 | hgbot | Checkin | |
| 2015-10-22 12:50 | hgbot | Note Added: 0081206 | |
| 2015-10-22 12:50 | hgbot | Status | scheduled => resolved |
| 2015-10-22 12:50 | hgbot | Resolution | open => fixed |
| 2015-10-22 12:50 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/retail/backports/3.0RR15Q4/org.openbravo.retail.posterminal/rev/7920c5770bd851a68da084989c42616aa792fd9d [^] |
| 2015-10-22 16:28 | marvintm | Assigned To | guilleaer => marvintm |
| 2015-10-23 12:39 | guilleaer | Review Assigned To | Orekaria => guilleaer |
| 2015-10-23 12:39 | guilleaer | Note Added: 0081257 | |
| 2015-10-23 12:39 | guilleaer | Status | resolved => closed |
| 2015-10-23 12:39 | guilleaer | Fixed in Version | => RR15Q4 |
| Copyright © 2000 - 2009 MantisBT Group |