Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031037Retail ModulesWeb POSpublic2015-10-02 14:192015-10-23 12:39
Reporteraaroncalero 
Assigned Tomarvintm 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR15Q4Fixed in VersionRR15Q4 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression levelCode review
Regression date
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/def6db59d486662f86abaef2ac435dca19c5db5b [^]
Triggers an Emergency PackNo
Summary0031037: Deprecation messages when logging in web pos
DescriptionWarning/Deprecation messages are shown on the javascript console, related to the OBPOS_PreCreateNewReceipt and OBPOS_PostCreateNewReceipt hooks.
These hooks are using the old hookManager API.
Steps To ReproduceLogin in web pos.
Create an empty receipt.
Verify that the following messages are shown on the browser console:
adead8f74bf0fa2fef815f78f78c7f66_WebPOS.js:2366 Deprecated (since RR14Q4): 'OB.MobileApp.model.hookManager' is a child of the model of the terminal. Please use 'OB.UTIL.HookManager' instead. More info: http://wiki.openbravo.com/wiki/How_to_Add_Hooks. [^] Hook: 'OBPOS_PreCreateNewReceipt'; line: Object.hookManager.executeHooks (https://livebuilds.openbravo.com/retail_pi_pgsql/web/js/gen/adead8f74bf0fa2fef815f78f78c7f66_WebPOS.js:5413:14 [^]) (*,+)
2015-10-02 14:17:49.018 adead8f74bf0fa2fef815f78f78c7f66_WebPOS.js:2366 Deprecated (since RR14Q4): 'OB.MobileApp.model.hookManager' is a child of the model of the terminal. Please use 'OB.UTIL.HookManager' instead. More info: http://wiki.openbravo.com/wiki/How_to_Add_Hooks. [^] Hook: 'OBPOS_PostAddNewReceipt'; line: Object.hookManager.executeHooks (https://livebuilds.openbravo.com/retail_pi_pgsql/web/js/gen/adead8f74bf0fa2fef815f78f78c7f66_WebPOS.js:5413:14 [^]) (*,+)
Proposed SolutionReplace the old API calls:
OB.MobileApp.model.hookManager.executeHooks('OBPOS_PreCreateNewReceipt', {
OB.MobileApp.model.hookManager.executeHooks('OBPOS_PostAddNewReceipt', {
with:
OB.UTIL.HookManager.executeHooks('OBPOS_PreCreateNewReceipt', {
OB.UTIL.HookManager.executeHooks('OBPOS_PostAddNewReceipt', {
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0031035RR15Q4 closed dbaz Deprecation messages when logging in web pos 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-10-02 16:08OrekariaTypedefect => backport
2015-10-02 16:08OrekariaTarget Version => RR15Q4.1
2015-10-19 14:38OrekariaTarget VersionRR15Q4.1 => RR15Q4
2015-10-22 12:50hgbotCheckin
2015-10-22 12:50hgbotNote Added: 0081206
2015-10-22 12:50hgbotStatusscheduled => resolved
2015-10-22 12:50hgbotResolutionopen => fixed
2015-10-22 12:50hgbotFixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR15Q4/org.openbravo.retail.posterminal/rev/7920c5770bd851a68da084989c42616aa792fd9d [^]
2015-10-22 16:28marvintmAssigned Toguilleaer => marvintm
2015-10-23 12:39guilleaerReview Assigned ToOrekaria => guilleaer
2015-10-23 12:39guilleaerNote Added: 0081257
2015-10-23 12:39guilleaerStatusresolved => closed
2015-10-23 12:39guilleaerFixed in Version => RR15Q4

Notes
(0081206)
hgbot   
2015-10-22 12:50   
Repository: retail/backports/3.0RR15Q4/org.openbravo.retail.posterminal
Changeset: 7920c5770bd851a68da084989c42616aa792fd9d
Author: Antonio Moreno Perez <antonio.moreno <at> openbravo.com>
Date: Thu Oct 22 12:49:35 2015 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR15Q4/org.openbravo.retail.posterminal/rev/7920c5770bd851a68da084989c42616aa792fd9d [^]

Fixed issue 31037. Hooks which were created using an old API now are using the current API

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0081257)
guilleaer   
2015-10-23 12:39   
Code reviewed and tested