Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0030958
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2015-09-29 11:422016-05-20 15:01
ReportermarvintmView Statuspublic 
Assigned Tomigueldejuana 
PriorityurgentResolutionfixedFixed in VersionRR16Q3
StatusclosedFix in branchFixed in SCM revisionc6a3e9e9bdb0
ProjectionnoneETAnoneTarget VersionRR16Q3
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0030958: Success callbacks in the RunSyncProcess are sometimes not executed even if the process finished successfully

DescriptionThe runSyncProcess function can accept a success callback. This callback should be executed always if the process finished successfully, regardless of whether there was data to be synchronized or not.

There is currently at least one case in which this doesn't happen.
Steps To Reproduce- Create a quotation, and complete it.
- Verify that the quotation is correctly sent to the backend, and saved correctly there, but the success callback of the runSyncProcess is not executed.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0030799RR15Q4 closedmigueldejuana [RR15Q4] A red icon indicating data not synchronised is shown even if nothing needs to be synchronised 
related to defect 0031005RR16Q1 closedjorge-garcia runSyncProcess callback is not executed if last model has no data to synch 
blocks defect 0031004RR16Q3 closedmigueldejuana A red icon indicating data not synchronised is shown even if nothing needs to be synchronised 

-  Notes
(0080694)
hgbot (developer)
2015-09-29 12:26

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 2caa3ccb0a4c3e25a1c4ba86499a16fb3999fa76
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Sep 29 12:26:43 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2caa3ccb0a4c3e25a1c4ba86499a16fb3999fa76 [^]

Fixed issue 30958. Now success callback will be always executed at the end, when all models have been processed correctly.

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0080709)
migueldejuana (developer)
2015-09-29 16:22

 Tested and reviewed in 2caa3ccb0a4c
(0080748)
hgbot (developer)
2015-09-30 14:03

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 2100cc2a0eaf69c80d878a512c183e8328d05420
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Sep 30 14:03:45 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2100cc2a0eaf69c80d878a512c183e8328d05420 [^]

Related to issue 30958. Rolled back change until confirmation that it is fully correct.

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0080749)
marvintm (manager)
2015-09-30 14:04

 Rolled back the fix. It needs to be reviewed to ensure that it is correct in all cases
(0085974)
hgbot (developer)
2016-04-26 11:36

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: e55a2db27e36d3ebaf027a80ecac140f2ba49c8a
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Apr 25 15:52:14 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/e55a2db27e36d3ebaf027a80ecac140f2ba49c8a [^]

Fixed issue 0030958: Success callbacks in the RunSyncProcess are sometimes not executed even if the process finished successfully

Now we execute callback with the last model. It doesn't mind if it has something to synchronize or not.

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0085975)
hgbot (developer)
2016-04-26 11:36

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: c6a3e9e9bdb0e88a240d738d29bc7a1aa12e9217
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Apr 25 16:26:18 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/c6a3e9e9bdb0e88a240d738d29bc7a1aa12e9217 [^]

Fixed issue 0030958: Success callbacks in the RunSyncProcess are sometimes not executed even if the process finished successfully

-Remove emptyModel, it is not used.

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0086344)
dmitry_mezentsev (developer)
2016-05-10 11:50

 Not closed for 14 days

- Issue History
Date Modified Username Field Change
2015-09-29 11:42 marvintm New Issue
2015-09-29 11:42 marvintm Assigned To => marvintm
2015-09-29 11:42 marvintm Triggers an Emergency Pack => No
2015-09-29 12:26 hgbot Checkin
2015-09-29 12:26 hgbot Note Added: 0080694
2015-09-29 12:26 hgbot Status new => resolved
2015-09-29 12:26 hgbot Resolution open => fixed
2015-09-29 12:26 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2caa3ccb0a4c3e25a1c4ba86499a16fb3999fa76 [^]
2015-09-29 12:27 marvintm Review Assigned To => migueldejuana
2015-09-29 16:22 migueldejuana Note Added: 0080709
2015-09-29 16:22 migueldejuana Status resolved => closed
2015-09-29 16:22 migueldejuana Fixed in Version => RR15Q4
2015-09-30 14:03 hgbot Checkin
2015-09-30 14:03 hgbot Note Added: 0080748
2015-09-30 14:04 marvintm Note Added: 0080749
2015-09-30 14:04 marvintm Status closed => new
2015-09-30 14:04 marvintm Resolution fixed => open
2015-09-30 14:04 marvintm Fixed in Version RR15Q4 =>
2015-09-30 14:04 marvintm Target Version RR15Q4 => RR16Q1
2015-09-30 18:18 Orekaria Relationship added related to 0030799
2015-12-21 18:18 Orekaria Target Version RR16Q1 =>
2015-12-21 18:38 Orekaria Target Version => RR16Q2
2015-12-28 12:03 Orekaria Status new => scheduled
2016-03-16 08:44 migueldejuana Relationship added blocks 0031004
2016-03-31 11:52 migueldejuana Target Version RR16Q2 => RR16Q3
2016-04-26 11:36 hgbot Checkin
2016-04-26 11:36 hgbot Note Added: 0085974
2016-04-26 11:36 hgbot Status scheduled => resolved
2016-04-26 11:36 hgbot Resolution open => fixed
2016-04-26 11:36 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2caa3ccb0a4c3e25a1c4ba86499a16fb3999fa76 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/e55a2db27e36d3ebaf027a80ecac140f2ba49c8a [^]
2016-04-26 11:36 hgbot Checkin
2016-04-26 11:36 hgbot Note Added: 0085975
2016-04-26 11:36 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/e55a2db27e36d3ebaf027a80ecac140f2ba49c8a [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/c6a3e9e9bdb0e88a240d738d29bc7a1aa12e9217 [^]
2016-04-26 11:38 migueldejuana Relationship added related to 0031005
2016-04-26 12:30 migueldejuana Review Assigned To migueldejuana => marvintm
2016-04-26 12:30 migueldejuana Assigned To marvintm => migueldejuana
2016-05-10 11:50 dmitry_mezentsev Note Added: 0086344
2016-05-20 15:01 marvintm Status resolved => closed
2016-05-20 15:01 marvintm Fixed in Version => RR16Q3

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker