Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030958Retail ModulesWeb POSpublic2015-09-29 11:422016-05-20 15:01
Reportermarvintm 
Assigned Tomigueldejuana 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q3Fixed in VersionRR16Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0030958: Success callbacks in the RunSyncProcess are sometimes not executed even if the process finished successfully
DescriptionThe runSyncProcess function can accept a success callback. This callback should be executed always if the process finished successfully, regardless of whether there was data to be synchronized or not.

There is currently at least one case in which this doesn't happen.
Steps To Reproduce- Create a quotation, and complete it.
- Verify that the quotation is correctly sent to the backend, and saved correctly there, but the success callback of the runSyncProcess is not executed.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0030799RR15Q4 closed migueldejuana [RR15Q4] A red icon indicating data not synchronised is shown even if nothing needs to be synchronised 
related to defect 0031005RR16Q1 closed jorge-garcia runSyncProcess callback is not executed if last model has no data to synch 
blocks defect 0031004RR16Q3 closed migueldejuana A red icon indicating data not synchronised is shown even if nothing needs to be synchronised 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-09-29 11:42marvintmNew Issue
2015-09-29 11:42marvintmAssigned To => marvintm
2015-09-29 11:42marvintmTriggers an Emergency Pack => No
2015-09-29 12:26hgbotCheckin
2015-09-29 12:26hgbotNote Added: 0080694
2015-09-29 12:26hgbotStatusnew => resolved
2015-09-29 12:26hgbotResolutionopen => fixed
2015-09-29 12:26hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2caa3ccb0a4c3e25a1c4ba86499a16fb3999fa76 [^]
2015-09-29 12:27marvintmReview Assigned To => migueldejuana
2015-09-29 16:22migueldejuanaNote Added: 0080709
2015-09-29 16:22migueldejuanaStatusresolved => closed
2015-09-29 16:22migueldejuanaFixed in Version => RR15Q4
2015-09-30 14:03hgbotCheckin
2015-09-30 14:03hgbotNote Added: 0080748
2015-09-30 14:04marvintmNote Added: 0080749
2015-09-30 14:04marvintmStatusclosed => new
2015-09-30 14:04marvintmResolutionfixed => open
2015-09-30 14:04marvintmFixed in VersionRR15Q4 =>
2015-09-30 14:04marvintmTarget VersionRR15Q4 => RR16Q1
2015-09-30 18:18OrekariaRelationship addedrelated to 0030799
2015-12-21 18:18OrekariaTarget VersionRR16Q1 =>
2015-12-21 18:38OrekariaTarget Version => RR16Q2
2015-12-28 12:03OrekariaStatusnew => scheduled
2016-03-16 08:44migueldejuanaRelationship addedblocks 0031004
2016-03-31 11:52migueldejuanaTarget VersionRR16Q2 => RR16Q3
2016-04-26 11:36hgbotCheckin
2016-04-26 11:36hgbotNote Added: 0085974
2016-04-26 11:36hgbotStatusscheduled => resolved
2016-04-26 11:36hgbotResolutionopen => fixed
2016-04-26 11:36hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2caa3ccb0a4c3e25a1c4ba86499a16fb3999fa76 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/e55a2db27e36d3ebaf027a80ecac140f2ba49c8a [^]
2016-04-26 11:36hgbotCheckin
2016-04-26 11:36hgbotNote Added: 0085975
2016-04-26 11:36hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/e55a2db27e36d3ebaf027a80ecac140f2ba49c8a [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/c6a3e9e9bdb0e88a240d738d29bc7a1aa12e9217 [^]
2016-04-26 11:38migueldejuanaRelationship addedrelated to 0031005
2016-04-26 12:30migueldejuanaReview Assigned Tomigueldejuana => marvintm
2016-04-26 12:30migueldejuanaAssigned Tomarvintm => migueldejuana
2016-05-10 11:50dmitry_mezentsevNote Added: 0086344
2016-05-20 15:01marvintmStatusresolved => closed
2016-05-20 15:01marvintmFixed in Version => RR16Q3

Notes
(0080694)
hgbot   
2015-09-29 12:26   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 2caa3ccb0a4c3e25a1c4ba86499a16fb3999fa76
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Sep 29 12:26:43 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2caa3ccb0a4c3e25a1c4ba86499a16fb3999fa76 [^]

Fixed issue 30958. Now success callback will be always executed at the end, when all models have been processed correctly.

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0080709)
migueldejuana   
2015-09-29 16:22   
Tested and reviewed in 2caa3ccb0a4c
(0080748)
hgbot   
2015-09-30 14:03   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 2100cc2a0eaf69c80d878a512c183e8328d05420
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Sep 30 14:03:45 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2100cc2a0eaf69c80d878a512c183e8328d05420 [^]

Related to issue 30958. Rolled back change until confirmation that it is fully correct.

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0080749)
marvintm   
2015-09-30 14:04   
Rolled back the fix. It needs to be reviewed to ensure that it is correct in all cases
(0085974)
hgbot   
2016-04-26 11:36   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: e55a2db27e36d3ebaf027a80ecac140f2ba49c8a
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Apr 25 15:52:14 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/e55a2db27e36d3ebaf027a80ecac140f2ba49c8a [^]

Fixed issue 0030958: Success callbacks in the RunSyncProcess are sometimes not executed even if the process finished successfully

Now we execute callback with the last model. It doesn't mind if it has something to synchronize or not.

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0085975)
hgbot   
2016-04-26 11:36   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: c6a3e9e9bdb0e88a240d738d29bc7a1aa12e9217
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Apr 25 16:26:18 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/c6a3e9e9bdb0e88a240d738d29bc7a1aa12e9217 [^]

Fixed issue 0030958: Success callbacks in the RunSyncProcess are sometimes not executed even if the process finished successfully

-Remove emptyModel, it is not used.

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0086344)
dmitry_mezentsev   
2016-05-10 11:50   
Not closed for 14 days