Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0030949 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | trivial | have not tried | 2015-09-28 17:20 | 2015-11-23 21:16 | |||
| Reporter | inigosanchez | View Status | public | |||||
| Assigned To | inigosanchez | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | 3.0PR16Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 2bed8a827ab9 | ||||
| Projection | none | ETA | none | Target Version | 3.0PR16Q1 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | alostale | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0030949: Variable shadowing in ConnectionProviderContextListener. | |||||||
| Description | Variable shadowing in ConnectionProviderContextListener. There are two warnings in src-core/src/org/openbravo/base/ConnectionProviderContextListener.java . They are newly introduced in pool project. 'reloadPool' and 'destroyPool' methods have a local variable pool. Besides, there is a static class field with same name too. | |||||||
| Steps To Reproduce | Get all warnings in src-core from IDE. | |||||||
| Proposed Solution | It is proposed to rename the parameter of the methods. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0080862) hgbot (developer) 2015-10-07 16:06 |
Repository: erp/devel/pi Changeset: 2bed8a827ab9924be2b6c3b62abdf578e690064b Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com> Date: Wed Oct 07 16:04:13 2015 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/2bed8a827ab9924be2b6c3b62abdf578e690064b [^] Fixes issue 30949: Variable shadowing in ConnectionProviderContextListener The problem was that ConnectionProviderContextListener.java had static class field with same name than parameters in two methods. Now it has been resolved by renaming the vars in the functions. --- M src-core/src/org/openbravo/base/ConnectionProviderContextListener.java --- |
|
(0081188) alostale (manager) 2015-10-22 09:22 |
code reviewed, tested continues working as it did |
|
(0082114) hudsonbot (developer) 2015-11-23 21:16 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2015-09-28 17:20 | inigosanchez | New Issue | |
| 2015-09-28 17:20 | inigosanchez | Assigned To | => inigosanchez |
| 2015-09-28 17:20 | inigosanchez | Modules | => Core |
| 2015-09-28 17:20 | inigosanchez | Triggers an Emergency Pack | => No |
| 2015-09-30 08:16 | alostale | Status | new => acknowledged |
| 2015-09-30 08:16 | alostale | Priority | low => high |
| 2015-09-30 08:16 | alostale | Target Version | => 3.0PR16Q1 |
| 2015-10-07 16:00 | inigosanchez | Issue Monitored: alostale | |
| 2015-10-07 16:05 | inigosanchez | Review Assigned To | => alostale |
| 2015-10-07 16:06 | hgbot | Checkin | |
| 2015-10-07 16:06 | hgbot | Note Added: 0080862 | |
| 2015-10-07 16:06 | hgbot | Status | acknowledged => resolved |
| 2015-10-07 16:06 | hgbot | Resolution | open => fixed |
| 2015-10-07 16:06 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/2bed8a827ab9924be2b6c3b62abdf578e690064b [^] |
| 2015-10-22 09:22 | alostale | Note Added: 0081188 | |
| 2015-10-22 09:22 | alostale | Status | resolved => closed |
| 2015-10-22 09:22 | alostale | Fixed in Version | => 3.0PR16Q1 |
| 2015-11-14 13:01 | shuehner | Relationship added | blocks 0031477 |
| 2015-11-23 21:16 | hudsonbot | Checkin | |
| 2015-11-23 21:16 | hudsonbot | Note Added: 0082114 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |