Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030949Openbravo ERPA. Platformpublic2015-09-28 17:202015-11-23 21:16
Reporterinigosanchez 
Assigned Toinigosanchez 
PriorityhighSeveritytrivialReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR16Q1Fixed in Version3.0PR16Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0030949: Variable shadowing in ConnectionProviderContextListener.
DescriptionVariable shadowing in ConnectionProviderContextListener. There are two warnings in src-core/src/org/openbravo/base/ConnectionProviderContextListener.java . They are newly introduced in pool project.

'reloadPool' and 'destroyPool' methods have a local variable pool. Besides, there is a static class field with same name too.
Steps To ReproduceGet all warnings in src-core from IDE.
Proposed SolutionIt is proposed to rename the parameter of the methods.
Additional Information
TagsNo tags attached.
Relationships
blocks feature request 0031477 new shuehner Tracking issue to reduce the huge number of eclipse warnings in pi 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-09-28 17:20inigosanchezNew Issue
2015-09-28 17:20inigosanchezAssigned To => inigosanchez
2015-09-28 17:20inigosanchezModules => Core
2015-09-28 17:20inigosanchezTriggers an Emergency Pack => No
2015-09-30 08:16alostaleStatusnew => acknowledged
2015-09-30 08:16alostalePrioritylow => high
2015-09-30 08:16alostaleTarget Version => 3.0PR16Q1
2015-10-07 16:00inigosanchezIssue Monitored: alostale
2015-10-07 16:05inigosanchezReview Assigned To => alostale
2015-10-07 16:06hgbotCheckin
2015-10-07 16:06hgbotNote Added: 0080862
2015-10-07 16:06hgbotStatusacknowledged => resolved
2015-10-07 16:06hgbotResolutionopen => fixed
2015-10-07 16:06hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2bed8a827ab9924be2b6c3b62abdf578e690064b [^]
2015-10-22 09:22alostaleNote Added: 0081188
2015-10-22 09:22alostaleStatusresolved => closed
2015-10-22 09:22alostaleFixed in Version => 3.0PR16Q1
2015-11-14 13:01shuehnerRelationship addedblocks 0031477
2015-11-23 21:16hudsonbotCheckin
2015-11-23 21:16hudsonbotNote Added: 0082114

Notes
(0080862)
hgbot   
2015-10-07 16:06   
Repository: erp/devel/pi
Changeset: 2bed8a827ab9924be2b6c3b62abdf578e690064b
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Wed Oct 07 16:04:13 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2bed8a827ab9924be2b6c3b62abdf578e690064b [^]

Fixes issue 30949: Variable shadowing in ConnectionProviderContextListener

The problem was that ConnectionProviderContextListener.java had static class field with same name than parameters in two methods.

Now it has been resolved by renaming the vars in the functions.

---
M src-core/src/org/openbravo/base/ConnectionProviderContextListener.java
---
(0081188)
alostale   
2015-10-22 09:22   
code reviewed, tested continues working as it did
(0082114)
hudsonbot   
2015-11-23 21:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^]
Maturity status: Test