Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0030841 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Gift cards and gift vouchers | major | always | 2015-09-16 17:11 | 2015-10-20 09:59 | |||
| Reporter | guillermogil | View Status | public | |||||
| Assigned To | fmolina | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | c15b7265b818 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Linux 64 bit | Database | PostgreSQL | Java version | ||||
| OS Version | Database version | 9.3 | Ant version | |||||
| Product Version | RR15Q1.5 | SCM revision | ||||||
| Review Assigned To | marvintm | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0030841: Return line button should not be clickable if the selected line is a Gift Card | |||||||
| Description | Return line button should not be clickable if the selected line is a Gift Card It is possible to generate wrong data if we create a return line of a Gift Card without its own process. | |||||||
| Steps To Reproduce | * Log on WebPOS * Buy a Gift Card * Close the order * Add a Product * Add the previously created Gift Card * Select the Gift Card Line * Click Return Line button | |||||||
| Proposed Solution | Hide that button if the line selected is a Gift Card | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  1.png [^] (225,267 bytes) 2015-09-16 17:11
2.png [^] (230,172 bytes) 2015-09-16 17:11
3.png [^] (104,930 bytes) 2015-09-16 17:11
4.png [^] (87,705 bytes) 2015-09-16 17:12
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0080927) hgbot (developer) 2015-10-10 00:21 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 067080dd7985832d8b1ef85cf2a16b79d894dec0 Author: Facundo Molina <fmolina <at> koodu.es> Date: Fri Oct 09 19:17:27 2015 -0300 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/067080dd7985832d8b1ef85cf2a16b79d894dec0 [^] Fixed issue 30841: return line not clickeable when selected line is gift card --- M web/org.openbravo.retail.posterminal/js/components/renderorderline.js M web/org.openbravo.retail.posterminal/js/pointofsale/view/editline.js M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js --- |
|
(0080928) hgbot (developer) 2015-10-10 00:22 |
Repository: tools/automation/pi-mobile Changeset: ff119ecbcfc5bbe240881c06b0676fa3ac0675ca Author: Facundo Molina <fmolina <at> koodu.es> Date: Fri Oct 09 19:21:44 2015 -0300 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/ff119ecbcfc5bbe240881c06b0676fa3ac0675ca [^] Related to issue 30841: return line not clickeable when selected line is gift card --- A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/giftcards/I30841_ReturnLineButtonNotClickeable.java --- |
|
(0080957) guillermogil (manager) 2015-10-13 12:58 |
In my opinion this is not the proper approach, there should be a new property (e.g.- "hideButton") that can be used in a modular way. Right now there is code based on GiftCards developed on POSterminal |
|
(0080989) marvintm (manager) 2015-10-13 18:49 |
The code should not directly use a property added by an external module. It is good that the event is generic, but there should be a way to call the event in a generic way, so that other modules can also call it if they need to prevent the return button from being used. |
|
(0081061) hgbot (developer) 2015-10-17 01:56 |
Repository: erp/pmods/org.openbravo.retail.giftcards Changeset: c15b7265b8180a4acc87a5d22005e740a7496940 Author: Facundo Molina <fmolina <at> koodu.es> Date: Fri Oct 16 19:27:42 2015 -0300 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/c15b7265b8180a4acc87a5d22005e740a7496940 [^] Fixes issue 30841: hide return line button when selected line is gift card --- M web/org.openbravo.retail.giftcards/js/components/lineproperties.js --- |
|
(0081109) hgbot (developer) 2015-10-20 09:58 |
Repository: erp/pmods/org.openbravo.retail.giftcards Changeset: 0530e630b8dc28bffa0aa32a90959fef8e62f517 Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Tue Oct 20 09:58:28 2015 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/0530e630b8dc28bffa0aa32a90959fef8e62f517 [^] Related to issue 30841. Changed name of hook --- M web/org.openbravo.retail.giftcards/js/components/lineproperties.js --- |
|
(0081110) hgbot (developer) 2015-10-20 09:59 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 2741287b6081fab81c564fc451a3f5623c10e7c3 Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Tue Oct 20 09:59:40 2015 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2741287b6081fab81c564fc451a3f5623c10e7c3 [^] Related to issue 30841. Changed name of hook --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2015-09-16 17:11 | guillermogil | New Issue | |
| 2015-09-16 17:11 | guillermogil | Assigned To | => Retail |
| 2015-09-16 17:11 | guillermogil | Resolution time | => 1443564000 |
| 2015-09-16 17:11 | guillermogil | Triggers an Emergency Pack | => No |
| 2015-09-16 17:11 | guillermogil | File Added: 1.png | |
| 2015-09-16 17:11 | guillermogil | File Added: 2.png | |
| 2015-09-16 17:11 | guillermogil | File Added: 3.png | |
| 2015-09-16 17:12 | guillermogil | File Added: 4.png | |
| 2015-09-17 00:32 | fmolina | Status | new => scheduled |
| 2015-09-17 00:32 | fmolina | Assigned To | Retail => fmolina |
| 2015-10-10 00:21 | hgbot | Checkin | |
| 2015-10-10 00:21 | hgbot | Note Added: 0080927 | |
| 2015-10-10 00:21 | hgbot | Status | scheduled => resolved |
| 2015-10-10 00:21 | hgbot | Resolution | open => fixed |
| 2015-10-10 00:21 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/067080dd7985832d8b1ef85cf2a16b79d894dec0 [^] |
| 2015-10-10 00:22 | hgbot | Checkin | |
| 2015-10-10 00:22 | hgbot | Note Added: 0080928 | |
| 2015-10-13 10:31 | Orekaria | Review Assigned To | => marvintm |
| 2015-10-13 12:58 | guillermogil | Note Added: 0080957 | |
| 2015-10-13 18:49 | marvintm | Note Added: 0080989 | |
| 2015-10-13 18:49 | marvintm | Status | resolved => new |
| 2015-10-13 18:49 | marvintm | Resolution | fixed => open |
| 2015-10-17 01:56 | hgbot | Checkin | |
| 2015-10-17 01:56 | hgbot | Note Added: 0081061 | |
| 2015-10-17 01:56 | hgbot | Status | new => resolved |
| 2015-10-17 01:56 | hgbot | Resolution | open => fixed |
| 2015-10-17 01:56 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/067080dd7985832d8b1ef85cf2a16b79d894dec0 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/c15b7265b8180a4acc87a5d22005e740a7496940 [^] |
| 2015-10-19 11:01 | marvintm | Status | resolved => closed |
| 2015-10-20 09:58 | hgbot | Checkin | |
| 2015-10-20 09:58 | hgbot | Note Added: 0081109 | |
| 2015-10-20 09:59 | hgbot | Checkin | |
| 2015-10-20 09:59 | hgbot | Note Added: 0081110 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |