Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030841Retail ModulesGift cards and gift voucherspublic2015-09-16 17:112015-10-20 09:59
Reporterguillermogil 
Assigned Tofmolina 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS Version
Product VersionRR15Q1.5 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0030841: Return line button should not be clickable if the selected line is a Gift Card
DescriptionReturn line button should not be clickable if the selected line is a Gift Card
It is possible to generate wrong data if we create a return line of a Gift Card without its own process.
Steps To Reproduce* Log on WebPOS
* Buy a Gift Card
* Close the order
* Add a Product
* Add the previously created Gift Card
* Select the Gift Card Line
* Click Return Line button
Proposed SolutionHide that button if the line selected is a Gift Card
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng 1.png (225,267) 2015-09-16 17:11
https://issues.openbravo.com/file_download.php?file_id=8450&type=bug
png

png 2.png (230,172) 2015-09-16 17:11
https://issues.openbravo.com/file_download.php?file_id=8451&type=bug
png

png 3.png (104,930) 2015-09-16 17:11
https://issues.openbravo.com/file_download.php?file_id=8452&type=bug
png

png 4.png (87,705) 2015-09-16 17:12
https://issues.openbravo.com/file_download.php?file_id=8453&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2015-09-16 17:11guillermogilNew Issue
2015-09-16 17:11guillermogilAssigned To => Retail
2015-09-16 17:11guillermogilOBNetwork customer => Yes
2015-09-16 17:11guillermogilResolution time => 1443564000
2015-09-16 17:11guillermogilTriggers an Emergency Pack => No
2015-09-16 17:11guillermogilFile Added: 1.png
2015-09-16 17:11guillermogilFile Added: 2.png
2015-09-16 17:11guillermogilFile Added: 3.png
2015-09-16 17:12guillermogilFile Added: 4.png
2015-09-17 00:32fmolinaStatusnew => scheduled
2015-09-17 00:32fmolinaAssigned ToRetail => fmolina
2015-10-10 00:21hgbotCheckin
2015-10-10 00:21hgbotNote Added: 0080927
2015-10-10 00:21hgbotStatusscheduled => resolved
2015-10-10 00:21hgbotResolutionopen => fixed
2015-10-10 00:21hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/067080dd7985832d8b1ef85cf2a16b79d894dec0 [^]
2015-10-10 00:22hgbotCheckin
2015-10-10 00:22hgbotNote Added: 0080928
2015-10-13 10:31OrekariaReview Assigned To => marvintm
2015-10-13 12:58guillermogilNote Added: 0080957
2015-10-13 18:49marvintmNote Added: 0080989
2015-10-13 18:49marvintmStatusresolved => new
2015-10-13 18:49marvintmResolutionfixed => open
2015-10-17 01:56hgbotCheckin
2015-10-17 01:56hgbotNote Added: 0081061
2015-10-17 01:56hgbotStatusnew => resolved
2015-10-17 01:56hgbotResolutionopen => fixed
2015-10-17 01:56hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/067080dd7985832d8b1ef85cf2a16b79d894dec0 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/c15b7265b8180a4acc87a5d22005e740a7496940 [^]
2015-10-19 11:01marvintmStatusresolved => closed
2015-10-20 09:58hgbotCheckin
2015-10-20 09:58hgbotNote Added: 0081109
2015-10-20 09:59hgbotCheckin
2015-10-20 09:59hgbotNote Added: 0081110

Notes
(0080927)
hgbot   
2015-10-10 00:21   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 067080dd7985832d8b1ef85cf2a16b79d894dec0
Author: Facundo Molina <fmolina <at> koodu.es>
Date: Fri Oct 09 19:17:27 2015 -0300
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/067080dd7985832d8b1ef85cf2a16b79d894dec0 [^]

Fixed issue 30841: return line not clickeable when selected line is gift card

---
M web/org.openbravo.retail.posterminal/js/components/renderorderline.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/editline.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
---
(0080928)
hgbot   
2015-10-10 00:22   
Repository: tools/automation/pi-mobile
Changeset: ff119ecbcfc5bbe240881c06b0676fa3ac0675ca
Author: Facundo Molina <fmolina <at> koodu.es>
Date: Fri Oct 09 19:21:44 2015 -0300
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/ff119ecbcfc5bbe240881c06b0676fa3ac0675ca [^]

Related to issue 30841: return line not clickeable when selected line is gift card

---
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/giftcards/I30841_ReturnLineButtonNotClickeable.java
---
(0080957)
guillermogil   
2015-10-13 12:58   
In my opinion this is not the proper approach, there should be a new property (e.g.- "hideButton") that can be used in a modular way.
Right now there is code based on GiftCards developed on POSterminal
(0080989)
marvintm   
2015-10-13 18:49   
The code should not directly use a property added by an external module. It is good that the event is generic, but there should be a way to call the event in a generic way, so that other modules can also call it if they need to prevent the return button from being used.
(0081061)
hgbot   
2015-10-17 01:56   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: c15b7265b8180a4acc87a5d22005e740a7496940
Author: Facundo Molina <fmolina <at> koodu.es>
Date: Fri Oct 16 19:27:42 2015 -0300
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/c15b7265b8180a4acc87a5d22005e740a7496940 [^]

Fixes issue 30841: hide return line button when selected line is gift card

---
M web/org.openbravo.retail.giftcards/js/components/lineproperties.js
---
(0081109)
hgbot   
2015-10-20 09:58   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 0530e630b8dc28bffa0aa32a90959fef8e62f517
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Oct 20 09:58:28 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/0530e630b8dc28bffa0aa32a90959fef8e62f517 [^]

Related to issue 30841. Changed name of hook

---
M web/org.openbravo.retail.giftcards/js/components/lineproperties.js
---
(0081110)
hgbot   
2015-10-20 09:59   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 2741287b6081fab81c564fc451a3f5623c10e7c3
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Oct 20 09:59:40 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2741287b6081fab81c564fc451a3f5623c10e7c3 [^]

Related to issue 30841. Changed name of hook

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
---