Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0030812
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajoralways2015-09-11 10:302016-03-17 10:55
ReporterumartirenaView Statuspublic 
Assigned ToNaroaIriarte 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision48eb02e9f5f7
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toalostale
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0030812: Multiple filtering not allowed using tree reference selector in a pick and execute window grid.

DescriptionMultiple filtering not allowed using tree reference selector in a pick and execute window grid.
Steps To Reproduce-Define a reference which type is "Tree Reference" and "Ad_org" table as tree reference
-Go to "windows, tabs and fields"
-Select window "Create Purchase Order Lines"
-Go to tab "Lines" and finally select "Organization field"
-Do it visible and change the reference of the column for previously created "Tree reference"

After that, in the ERP as admin:
-Go to purchase order window
-Create a header
-Press in "Create lines button"
-You should see the pick and edit with previously changed reference.

Open the Organization filter and select more than one organization in the tree. Realize that no request is being done, so no filtering is done in the grid.

The issue can be reproduced in our BUT branch. Organization window, CC Warehouse tab.

Use the following guide to install the environment:

https://docs.google.com/document/d/1UF4bQm5-PXDTTJj5HsjxrUQ9Mr0_B4NIAhg3G8gzSPo/edit [^]

Repo: https://code.openbravo.com/private/swf-utils/ [^]

Snapshot: Snapshot_BUT_DEV_TIP
TagsNo tags attached.
Attached Filesdiff file icon issue30812a.diff [^] (1,606 bytes) 2015-09-23 18:03 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to defect 00299783.0PR15Q4 closedNaroaIriarte Not possible to use tree reference selector in a pick and execute window grid 
related to defect 0030933 closedNaroaIriarte Error when using on a new selector a column whose reference is a tree 

-  Notes
(0080634)
hgbot (developer)
2015-09-25 09:37

Repository: erp/devel/pi
Changeset: 316a929ec5762de9e3487d17b0af9a7f4d63440d
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Thu Sep 24 15:50:19 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/316a929ec5762de9e3487d17b0af9a7f4d63440d [^]

Fixed issue 30812:Allow multiple filtering using tree reference.

It was not allowed the multiple filtering using a tree reference in a
pick and execute window's grid.

The ob-formitem-tree-filter.js has been changed for being able to do this.
The problem was in the "filterDialogCallback" funtion in the "this.grid.parentElement.setFilterEditorCriteria(criteria)"
It was not working fine in every case.
It was neccesary to change the criteria for having the following: It was neccesary to delete
the old criteria of the tree filter, taking into account the new criteria of the tree filter
and taking into account the criteria of the rest of the grid of the pick and Execute window.

The new function, "setCurrentCriterion" is the one that updates the criteria of the tree filter, it deletes the
old criteria of the filter and gets the new criteria of the tree filter.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-tree-filter.js
---
(0080643)
hgbot (developer)
2015-09-25 14:33

Repository: erp/devel/pi
Changeset: 0ff625245ab99e67dfd758aee8cb81e9e2bda87f
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Fri Sep 25 14:32:13 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/0ff625245ab99e67dfd758aee8cb81e9e2bda87f [^]

Related to issue 30812: Improve the functions.

The function filterDialogCallback of the "ob-formitem-tree-filter.js" is improved.
This function calls the "updateCriterion" function which updates the criterion of
the tree filter deleting the old criterion and adding the new criterion.
The crieteria of the rest of the columns in the grid is taken into account.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-tree-filter.js
---
(0080653)
hudsonbot (developer)
2015-09-26 17:09

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c198449f8f58 [^]
Maturity status: Test
(0080654)
hudsonbot (developer)
2015-09-26 17:09

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c198449f8f58 [^]
Maturity status: Test
(0080693)
alostale (manager)
2015-09-29 11:49

code reviewed

tested both in P&E and standard windows
(0083556)
hgbot (developer)
2016-01-22 11:50

Repository: erp/devel/pi
Changeset: 48eb02e9f5f739a5617bc53d515dac58f485bad4
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Thu Sep 24 15:50:19 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/48eb02e9f5f739a5617bc53d515dac58f485bad4 [^]

Fixed issue 30812:Allow multiple filtering using tree reference.

It was not allowed the multiple filtering using a tree reference in a
pick and execute window's grid.

The ob-formitem-tree-filter.js has been changed for being able to do this.
The problem was in the "filterDialogCallback" funtion in the "this.grid.parentElement.setFilterEditorCriteria(criteria)"
It was not working fine in every case.
It was neccesary to change the criteria for having the following: It was neccesary to delete
the old criteria of the tree filter, taking into account the new criteria of the tree filter
and taking into account the criteria of the rest of the grid of the pick and Execute window.

The new function, "setCurrentCriterion" is the one that updates the criteria of the tree filter, it deletes the
old criteria of the filter and gets the new criteria of the tree filter.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-tree-filter.js
---
(0083557)
hgbot (developer)
2016-01-22 11:51

Repository: erp/devel/pi
Changeset: 8a4a90af81094804965b6039b29ba1e80732c8fd
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Fri Sep 25 14:32:13 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/8a4a90af81094804965b6039b29ba1e80732c8fd [^]

Related to issue 30812: Improve the functions.

The function filterDialogCallback of the "ob-formitem-tree-filter.js" is improved.
This function calls the "updateCriterion" function which updates the criterion of
the tree filter deleting the old criterion and adding the new criterion.
The crieteria of the rest of the columns in the grid is taken into account.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-tree-filter.js
---
(0083701)
alostale (manager)
2016-01-29 08:32

closed again: was set as resolved incorrectly
(0085075)
hudsonbot (developer)
2016-03-17 10:55

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test
(0085076)
hudsonbot (developer)
2016-03-17 10:55

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2015-09-11 10:30 umartirena New Issue
2015-09-11 10:30 umartirena Assigned To => platform
2015-09-11 10:30 umartirena Modules => Core
2015-09-11 10:30 umartirena Triggers an Emergency Pack => No
2015-09-11 10:31 umartirena Relationship added related to 0029978
2015-09-11 10:49 alostale Status new => scheduled
2015-09-11 10:49 alostale Assigned To platform => NaroaIriarte
2015-09-14 10:34 umartirena Steps to Reproduce Updated View Revisions
2015-09-14 15:48 umartirena Steps to Reproduce Updated View Revisions
2015-09-22 13:01 umartirena Resolution time => 1443132000
2015-09-23 18:01 NaroaIriarte File Added: issue30812.diff
2015-09-23 18:02 NaroaIriarte File Deleted: issue30812.diff
2015-09-23 18:03 NaroaIriarte File Added: issue30812a.diff
2015-09-25 09:37 hgbot Checkin
2015-09-25 09:37 hgbot Note Added: 0080634
2015-09-25 09:37 hgbot Status scheduled => resolved
2015-09-25 09:37 hgbot Resolution open => fixed
2015-09-25 09:37 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/316a929ec5762de9e3487d17b0af9a7f4d63440d [^]
2015-09-25 14:33 hgbot Checkin
2015-09-25 14:33 hgbot Note Added: 0080643
2015-09-26 17:09 hudsonbot Checkin
2015-09-26 17:09 hudsonbot Note Added: 0080653
2015-09-26 17:09 hudsonbot Checkin
2015-09-26 17:09 hudsonbot Note Added: 0080654
2015-09-28 08:47 alostale Relationship added related to 0030933
2015-09-29 07:42 alostale Review Assigned To => alostale
2015-09-29 11:49 alostale Note Added: 0080693
2015-09-29 11:49 alostale Status resolved => closed
2016-01-22 11:50 hgbot Checkin
2016-01-22 11:50 hgbot Note Added: 0083556
2016-01-22 11:50 hgbot Status closed => resolved
2016-01-22 11:50 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/316a929ec5762de9e3487d17b0af9a7f4d63440d [^] => http://code.openbravo.com/erp/devel/pi/rev/48eb02e9f5f739a5617bc53d515dac58f485bad4 [^]
2016-01-22 11:51 hgbot Checkin
2016-01-22 11:51 hgbot Note Added: 0083557
2016-01-29 08:32 alostale Note Added: 0083701
2016-01-29 08:32 alostale Status resolved => closed
2016-03-17 10:55 hudsonbot Checkin
2016-03-17 10:55 hudsonbot Note Added: 0085075
2016-03-17 10:55 hudsonbot Checkin
2016-03-17 10:55 hudsonbot Note Added: 0085076


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker