Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0030811
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 03. Procurement managementmajoralways2015-09-10 16:562015-09-15 15:56
ReportermalsasuaView Statuspublic 
Assigned Todmiguelez 
PriorityimmediateResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision63bf09cfd4a8
ProjectionnoneETAnoneTarget Version
OSLinux 32 bitDatabasePostgreSQLJava version1.6.0_18
OS VersionCommunity ApplianceDatabase version8.3.9Ant version1.7.1
Product VersionpiSCM revision 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket
Regression levelProduction - QA Approved
Regression date2015-04-28
Regression introduced in release3.0PR15Q3
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/annotate/b134bab019fe/src/org/openbravo/erpCommon/ad_process/ExpenseAPInvoice.java#l123 [^]
Triggers an Emergency PackNo
Summary

0030811: process: "Create expense AP Invoice" does not work

Descriptionthe process to create the purchase invoice from expense sheet is not working. Error is returned:
    
Error
java.lang.NullPointerException
Steps To Reproduce. in F&B
 . create a new product (p1) of type Expense and add in Price list Otros servicios
 . configure the BP: Javier Martin:
    . Vendor: true
       PO price list: otros servicios
       PO payment method: anyone
       PO payment termns: anyone
       PO financial account: anyone

 . go to expense sheet:
  new record:
   BP: Javier Martin
   date: 10-08-2015
   new line
     time sheet: no
     product: p1
     net unit price: 10
     date: 10-08-2015
  .process it

. go to "Create expense ap invoice" process
 . bp: javier martin
 . date from: 01-08-2015
 . date to: 31-08-2015
 . date invoice: 31-08-2015

process -> error is returned
java.lang.NullPointerException
Proposed Solution. the problem is in the line
https://code.openbravo.com/erp/devel/pi/file/13211c4cc0a0/src/org/openbravo/erpCommon/ad_process/ExpenseAPInvoice.java#l200 [^]
the insert of invoice header is done with the connection "conn" (and this connection is of type DalConnectionProvider(false).getTransactionConnection()) but after that, in the line
https://code.openbravo.com/erp/devel/pi/file/13211c4cc0a0/src/org/openbravo/erpCommon/utility/AccDefUtility.java#l135 [^]
this invoice is not retrieved, because it is in other session.

I think that the commit that it generated the regression is:
https://code.openbravo.com/erp/devel/pi/annotate/b134bab019fe/src/org/openbravo/erpCommon/ad_process/ExpenseAPInvoice.java#l123 [^]
TagsNo tags attached.
Attached Filesdiff file icon patch.diff [^] (1,532 bytes) 2015-09-14 10:25 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 00308183.0PR15Q3.2 closeddmiguelez Openbravo ERP process: "Create expense AP Invoice" does not work 
caused by defect 0028934 closedinigosanchez Modules Error when launching "Create AP Expense Invoices" related to Openbravo External Connection Pools module. 
has duplicate defect 0030314 closedTriage Omni OMS Openbravo ERP NullPointerException when launching the Create AP Expense Invoices process 
related to defect 0036945 closedAtulOpenbravo Modules Cannot post a document from the Report Not Posted window if an External Connection Pool is not used 

-  Notes
(0080364)
dmiguelez (viewer)
2015-09-14 10:23

 . in F&B
 . create a new product (p1) of type Expense and add in Price list Otros servicios
 . configure the BP: Javier Martin:
    . Vendor: true
       PO price list: otros servicios
       PO payment method: anyone
       PO payment termns: anyone
       PO financial account: anyone

 . go to expense sheet:
  new record:
   BP: Javier Martin
   date: 10-08-2015
   new line
     time sheet: no
     product: p1
     net unit price: 10
     date: 10-08-2015
  .process it

. go to "Create expense ap invoice" process
 . bp: javier martin
 . date from: 01-08-2015
 . date to: 31-08-2015
 . date invoice: 31-08-2015

process -> Process Completed sucessfully

Apply attached patch.
Run the test again.
Realize that it fails with a proper error message, not with a Null Pointer Exception.
(0080383)
hgbot (developer)
2015-09-14 17:55

 Repository: erp/devel/pi
Changeset: 63bf09cfd4a8f2ee5c9668f671a10494d3e99f55
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Sep 14 10:24:52 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/63bf09cfd4a8f2ee5c9668f671a10494d3e99f55 [^]

Fixes Issue 30811: Changes connection used for retrieving data using
xsql files. Uses OBDal Connection and uses OBDal methods for
doing rollback and commit with Close.

---
M src/org/openbravo/erpCommon/ad_process/ExpenseAPInvoice.java
---
(0080384)
vmromanos (viewer)
2015-09-14 17:55

 Code review + testing OK
(0080405)
hudsonbot (viewer)
2015-09-15 15:56

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/27462487da9b [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2015-09-10 16:56 malsasua New Issue
2015-09-10 16:56 malsasua Assigned To => Triage Finance
2015-09-10 16:56 malsasua OBNetwork customer => Yes
2015-09-10 16:56 malsasua Modules => Core
2015-09-10 16:56 malsasua Regression introduced by commit => https://code.openbravo.com/erp/devel/pi/annotate/b134bab019fe/src/org/openbravo/erpCommon/ad_process/ExpenseAPInvoice.java#l123 [^]
2015-09-10 16:56 malsasua Triggers an Emergency Pack => No
2015-09-14 10:20 dmiguelez Status new => scheduled
2015-09-14 10:20 dmiguelez Assigned To Triage Finance => dmiguelez
2015-09-14 10:23 dmiguelez Note Added: 0080364
2015-09-14 10:25 dmiguelez File Added: patch.diff
2015-09-14 13:54 malsasua Resolution time => 1442354400
2015-09-14 15:59 vmromanos Relationship added caused by 0028934
2015-09-14 15:59 vmromanos Status scheduled => acknowledged
2015-09-14 16:02 vmromanos Review Assigned To => vmromanos
2015-09-14 16:02 vmromanos Regression level => Production - QA Approved
2015-09-14 16:02 vmromanos Regression date => 2015-04-28
2015-09-14 16:02 vmromanos Regression introduced in release => 3.0PR15Q3
2015-09-14 16:06 vmromanos Status acknowledged => scheduled
2015-09-14 17:55 hgbot Checkin
2015-09-14 17:55 hgbot Note Added: 0080383
2015-09-14 17:55 hgbot Status scheduled => resolved
2015-09-14 17:55 hgbot Resolution open => fixed
2015-09-14 17:55 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/63bf09cfd4a8f2ee5c9668f671a10494d3e99f55 [^]
2015-09-14 17:55 vmromanos Note Added: 0080384
2015-09-14 17:55 vmromanos Status resolved => closed
2015-09-15 15:56 hudsonbot Checkin
2015-09-15 15:56 hudsonbot Note Added: 0080405
2015-10-05 19:11 ngarcia Relationship added has duplicate 0030314
2017-09-26 10:39 aferraz Relationship added related to 0036945

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker