Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0030691
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajorhave not tried2015-08-27 17:312016-02-01 10:52
ReportermtaalView Statuspublic 
Assigned Tomtaal 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision6b202d11e3e3
ProjectionnoneETAnoneTarget VersionRR15Q4
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned Tomigueldejuana
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0030691: Saving customer address not possible

DescriptionCreate in webpos new customer address and save, see warning/error in log:
OB.Dal.remove: an object without primary key cannot be deleted
Steps To ReproduceCreate new customer address in webpos and save
Proposed Solutioncheck the diff introduced by hgvol merge, accidentally an isNew parameter was added to the save call, preventing an id to be set in the OB.DAL.save method (see the code of that function to understand):

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/diff/f829ed7fe8cc/web/org.openbravo.retail.posterminal/js/data/datacustomeraddrsave.js#l1.114 [^]
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0030738 closedmtaal Creating a new customer and assigning to the current receipt raises an error in taxes calculation 
blocks defect 0030674 closedRetail Tax error when new address are used 

-  Notes
(0079789)
hgbot (developer)
2015-08-28 09:02

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 52c04ab583dc89ba591a6f5e72d53992aeac3897
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Thu Aug 27 17:46:55 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/52c04ab583dc89ba591a6f5e72d53992aeac3897 [^]

Fixes issue 30691: Saving customer address not possible
Remove the isNew as parameter to OB.DAL.save call, let's this function to set the id of the customer address

---
M web/org.openbravo.retail.posterminal/js/data/datacustomeraddrsave.js
---
(0080337)
migueldejuana (developer)
2015-09-11 13:29

Tested and reviewed in 6b56e870b9ca
(0083558)
hgbot (developer)
2016-01-22 11:51

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 6b202d11e3e3e8013231c65000f9f7a9321b7bf4
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Thu Aug 27 17:46:55 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6b202d11e3e3e8013231c65000f9f7a9321b7bf4 [^]

Fixes issue 30691: Saving customer address not possible
Remove the isNew as parameter to OB.DAL.save call, let's this function to set the id of the customer address

---
M web/org.openbravo.retail.posterminal/js/data/datacustomeraddrsave.js
---
(0083775)
mtaal (manager)
2016-02-01 10:52

Unadvertently re-opened by hgbot, reclosing

- Issue History
Date Modified Username Field Change
2015-08-27 17:31 mtaal New Issue
2015-08-27 17:31 mtaal Assigned To => mtaal
2015-08-27 17:31 mtaal Triggers an Emergency Pack => No
2015-08-27 17:46 mtaal Proposed Solution updated
2015-08-28 09:02 hgbot Checkin
2015-08-28 09:02 hgbot Note Added: 0079789
2015-08-28 09:02 hgbot Status new => resolved
2015-08-28 09:02 hgbot Resolution open => fixed
2015-08-28 09:02 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/52c04ab583dc89ba591a6f5e72d53992aeac3897 [^]
2015-09-02 12:42 adrianromero Relationship added blocks 0030674
2015-09-02 12:47 adrianromero Relationship added related to 0030738
2015-09-11 13:29 migueldejuana Review Assigned To => migueldejuana
2015-09-11 13:29 migueldejuana Note Added: 0080337
2015-09-11 13:29 migueldejuana Status resolved => closed
2016-01-22 11:51 hgbot Checkin
2016-01-22 11:51 hgbot Note Added: 0083558
2016-01-22 11:51 hgbot Status closed => resolved
2016-01-22 11:51 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/52c04ab583dc89ba591a6f5e72d53992aeac3897 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6b202d11e3e3e8013231c65000f9f7a9321b7bf4 [^]
2016-02-01 10:52 mtaal Note Added: 0083775
2016-02-01 10:52 mtaal Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker