Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030691Retail ModulesWeb POSpublic2015-08-27 17:312016-02-01 10:52
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionRR15Q4Fixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0030691: Saving customer address not possible
DescriptionCreate in webpos new customer address and save, see warning/error in log:
OB.Dal.remove: an object without primary key cannot be deleted
Steps To ReproduceCreate new customer address in webpos and save
Proposed Solutioncheck the diff introduced by hgvol merge, accidentally an isNew parameter was added to the save call, preventing an id to be set in the OB.DAL.save method (see the code of that function to understand):

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/diff/f829ed7fe8cc/web/org.openbravo.retail.posterminal/js/data/datacustomeraddrsave.js#l1.114 [^]
Additional Information
TagsNo tags attached.
Relationships
related to defect 0030738 closed mtaal Creating a new customer and assigning to the current receipt raises an error in taxes calculation 
blocks defect 0030674 closed Retail Tax error when new address are used 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-08-27 17:31mtaalNew Issue
2015-08-27 17:31mtaalAssigned To => mtaal
2015-08-27 17:31mtaalOBNetwork customer => No
2015-08-27 17:31mtaalTriggers an Emergency Pack => No
2015-08-27 17:46mtaalProposed Solution updated
2015-08-28 09:02hgbotCheckin
2015-08-28 09:02hgbotNote Added: 0079789
2015-08-28 09:02hgbotStatusnew => resolved
2015-08-28 09:02hgbotResolutionopen => fixed
2015-08-28 09:02hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/52c04ab583dc89ba591a6f5e72d53992aeac3897 [^]
2015-09-02 12:42adrianromeroRelationship addedblocks 0030674
2015-09-02 12:47adrianromeroRelationship addedrelated to 0030738
2015-09-11 13:29migueldejuanaReview Assigned To => migueldejuana
2015-09-11 13:29migueldejuanaNote Added: 0080337
2015-09-11 13:29migueldejuanaStatusresolved => closed
2016-01-22 11:51hgbotCheckin
2016-01-22 11:51hgbotNote Added: 0083558
2016-01-22 11:51hgbotStatusclosed => resolved
2016-01-22 11:51hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/52c04ab583dc89ba591a6f5e72d53992aeac3897 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6b202d11e3e3e8013231c65000f9f7a9321b7bf4 [^]
2016-02-01 10:52mtaalNote Added: 0083775
2016-02-01 10:52mtaalStatusresolved => closed

Notes
(0079789)
hgbot   
2015-08-28 09:02   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 52c04ab583dc89ba591a6f5e72d53992aeac3897
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Thu Aug 27 17:46:55 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/52c04ab583dc89ba591a6f5e72d53992aeac3897 [^]

Fixes issue 30691: Saving customer address not possible
Remove the isNew as parameter to OB.DAL.save call, let's this function to set the id of the customer address

---
M web/org.openbravo.retail.posterminal/js/data/datacustomeraddrsave.js
---
(0080337)
migueldejuana   
2015-09-11 13:29   
Tested and reviewed in 6b56e870b9ca
(0083558)
hgbot   
2016-01-22 11:51   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 6b202d11e3e3e8013231c65000f9f7a9321b7bf4
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Thu Aug 27 17:46:55 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6b202d11e3e3e8013231c65000f9f7a9321b7bf4 [^]

Fixes issue 30691: Saving customer address not possible
Remove the isNew as parameter to OB.DAL.save call, let's this function to set the id of the customer address

---
M web/org.openbravo.retail.posterminal/js/data/datacustomeraddrsave.js
---
(0083775)
mtaal   
2016-02-01 10:52   
Unadvertently re-opened by hgbot, reclosing