Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0030684
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 00. Application dictionarymajoralways2015-08-27 12:112015-09-01 18:22
ReportergorkaionView Statuspublic 
Assigned Tocaristu 
PrioritynormalResolutionfixedFixed in Version3.0PR15Q4
StatusclosedFix in branchFixed in SCM revisioneb72b8a596ae
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned ToAugustoMauch
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0030684: Form field of characteristic description reference fails when added as property field

DescriptionWhen the characteristic description column of a product is added in a tab using a property path field it is not working correctly.

The grid view is correct and filter works as expected.

The form view is incorrect as the field is always hidden.
Steps To ReproduceAs System Admin with a module in development.

Go to Window, Tab and Fields window and open the "Discounts and Promotions" window definition.

On the "Products" tab add a new field with the property "product.characteristicDescription". Make sure that it is flagged to be visible in form and grid views.

As Openbravo Admin
Create a new Characteristic not variant with a single value.
Go to Product window and add the characteristic to an existing product.
Assign the characteristic value using the "Update Characteristics" button.
Go to "Discounts and Promotions" and create a new one.
Go to "Products" tab and insert the product with the characteristics.

Check that in grid view the characteristic description columns is there with the correct value.
Check that in form view there isn't any field with the characteristic.
Proposed SolutionThe CharacteristicsUIDefinition getFieldProperties() method is not taking into account that the field could be a property path field.
TagsNo tags attached.
Attached Filespatch file icon issue-30684-tentative.patch [^] (1,512 bytes) 2015-08-27 12:14 [Show Content]
diff file icon patchIssue30684.diff [^] (1,280 bytes) 2015-08-28 15:22 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0079777)
gorkaion (developer)
2015-08-27 12:16

 Attached a patch that solves the reported steps to reproduce issue.

It is not tested if that would also fix the scenario where the Product field is also added as a Property Path.

It could be tested in the Invoice Line tabs adding the "Product" field and its "Characteristic Description" field of the related Order Line.
(0079801)
caristu (developer)
2015-08-28 15:23
edited on: 2015-08-31 09:26

 Attached another possible solution. It has been pushed to try.
(0079988)
hgbot (developer)
2015-09-01 11:53

 Repository: erp/devel/pi
Changeset: eb72b8a596aeba7e97007ada347ee07e3efb5cc9
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue Sep 01 11:52:09 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/eb72b8a596aeba7e97007ada347ee07e3efb5cc9 [^]

Fixes issue 30684: Characteristic description fails with property field in form

The problem was that the column value was not being retrieved properly for property fields, because in this case the correct name for the property field in the request information was not being used.

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/CharacteristicsUIDefinition.java
---
(0079991)
AugustoMauch (manager)
2015-09-01 13:30

 Code reviewed and verified in pi@eb72b8a596ae
(0080004)
hudsonbot (developer)
2015-09-01 18:22

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/3a096b275cba [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2015-08-27 12:11 gorkaion New Issue
2015-08-27 12:11 gorkaion Assigned To => platform
2015-08-27 12:11 gorkaion Modules => Core
2015-08-27 12:11 gorkaion Triggers an Emergency Pack => No
2015-08-27 12:11 gorkaion Steps to Reproduce Updated View Revisions
2015-08-27 12:14 gorkaion File Added: issue-30684-tentative.patch
2015-08-27 12:16 gorkaion Note Added: 0079777
2015-08-28 08:46 gorkaion Severity critical => major
2015-08-28 15:22 caristu File Added: patchIssue30684.diff
2015-08-28 15:23 caristu Note Added: 0079801
2015-08-31 09:25 caristu Note Edited: 0079801 View Revisions
2015-08-31 09:26 caristu Note Edited: 0079801 View Revisions
2015-09-01 10:58 caristu Assigned To platform => caristu
2015-09-01 10:59 caristu Status new => scheduled
2015-09-01 11:52 caristu Review Assigned To => AugustoMauch
2015-09-01 11:52 caristu Issue Monitored: AugustoMauch
2015-09-01 11:53 hgbot Checkin
2015-09-01 11:53 hgbot Note Added: 0079988
2015-09-01 11:53 hgbot Status scheduled => resolved
2015-09-01 11:53 hgbot Resolution open => fixed
2015-09-01 11:53 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/eb72b8a596aeba7e97007ada347ee07e3efb5cc9 [^]
2015-09-01 13:30 AugustoMauch Note Added: 0079991
2015-09-01 13:30 AugustoMauch Status resolved => closed
2015-09-01 13:30 AugustoMauch Fixed in Version => 3.0PR15Q4
2015-09-01 18:22 hudsonbot Checkin
2015-09-01 18:22 hudsonbot Note Added: 0080004

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker