Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0030684 | Openbravo ERP | 00. Application dictionary | public | 2015-08-27 12:11 | 2015-09-01 18:22 |
|
| Reporter | gorkaion | |
| Assigned To | caristu | |
| Priority | normal | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | 3.0PR15Q4 | |
| Merge Request Status | |
| Review Assigned To | AugustoMauch |
| OBNetwork customer | No |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0030684: Form field of characteristic description reference fails when added as property field |
| Description | When the characteristic description column of a product is added in a tab using a property path field it is not working correctly.
The grid view is correct and filter works as expected.
The form view is incorrect as the field is always hidden. |
| Steps To Reproduce | As System Admin with a module in development.
Go to Window, Tab and Fields window and open the "Discounts and Promotions" window definition.
On the "Products" tab add a new field with the property "product.characteristicDescription". Make sure that it is flagged to be visible in form and grid views.
As Openbravo Admin
Create a new Characteristic not variant with a single value.
Go to Product window and add the characteristic to an existing product.
Assign the characteristic value using the "Update Characteristics" button.
Go to "Discounts and Promotions" and create a new one.
Go to "Products" tab and insert the product with the characteristics.
Check that in grid view the characteristic description columns is there with the correct value.
Check that in form view there isn't any field with the characteristic. |
| Proposed Solution | The CharacteristicsUIDefinition getFieldProperties() method is not taking into account that the field could be a property path field. |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files |  issue-30684-tentative.patch (1,512) 2015-08-27 12:14
https://issues.openbravo.com/file_download.php?file_id=8387&type=bug
patchIssue30684.diff (1,280) 2015-08-28 15:22
https://issues.openbravo.com/file_download.php?file_id=8389&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2015-08-27 12:11 | gorkaion | New Issue | |
| 2015-08-27 12:11 | gorkaion | Assigned To | => platform |
| 2015-08-27 12:11 | gorkaion | OBNetwork customer | => No |
| 2015-08-27 12:11 | gorkaion | Modules | => Core |
| 2015-08-27 12:11 | gorkaion | Triggers an Emergency Pack | => No |
| 2015-08-27 12:11 | gorkaion | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=9278#r9278 |
| 2015-08-27 12:14 | gorkaion | File Added: issue-30684-tentative.patch | |
| 2015-08-27 12:16 | gorkaion | Note Added: 0079777 | |
| 2015-08-28 08:46 | gorkaion | Severity | critical => major |
| 2015-08-28 15:22 | caristu | File Added: patchIssue30684.diff | |
| 2015-08-28 15:23 | caristu | Note Added: 0079801 | |
| 2015-08-31 09:25 | caristu | Note Edited: 0079801 | bug_revision_view_page.php?bugnote_id=0079801#r9289 |
| 2015-08-31 09:26 | caristu | Note Edited: 0079801 | bug_revision_view_page.php?bugnote_id=0079801#r9290 |
| 2015-09-01 10:58 | caristu | Assigned To | platform => caristu |
| 2015-09-01 10:59 | caristu | Status | new => scheduled |
| 2015-09-01 11:52 | caristu | Review Assigned To | => AugustoMauch |
| 2015-09-01 11:52 | caristu | Issue Monitored: AugustoMauch | |
| 2015-09-01 11:53 | hgbot | Checkin | |
| 2015-09-01 11:53 | hgbot | Note Added: 0079988 | |
| 2015-09-01 11:53 | hgbot | Status | scheduled => resolved |
| 2015-09-01 11:53 | hgbot | Resolution | open => fixed |
| 2015-09-01 11:53 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/eb72b8a596aeba7e97007ada347ee07e3efb5cc9 [^] |
| 2015-09-01 13:30 | AugustoMauch | Note Added: 0079991 | |
| 2015-09-01 13:30 | AugustoMauch | Status | resolved => closed |
| 2015-09-01 13:30 | AugustoMauch | Fixed in Version | => 3.0PR15Q4 |
| 2015-09-01 18:22 | hudsonbot | Checkin | |
| 2015-09-01 18:22 | hudsonbot | Note Added: 0080004 | |
|
Notes |
|
|
|
Attached a patch that solves the reported steps to reproduce issue.
It is not tested if that would also fix the scenario where the Product field is also added as a Property Path.
It could be tested in the Invoice Line tabs adding the "Product" field and its "Characteristic Description" field of the related Order Line. |
|
|
|
(0079801)
|
|
caristu
|
2015-08-28 15:23
(edited on: 2015-08-31 09:26) |
|
Attached another possible solution. It has been pushed to try.
|
|
|
|
(0079988)
|
|
hgbot
|
|
2015-09-01 11:53
|
|
Repository: erp/devel/pi
Changeset: eb72b8a596aeba7e97007ada347ee07e3efb5cc9
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue Sep 01 11:52:09 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/eb72b8a596aeba7e97007ada347ee07e3efb5cc9 [^]
Fixes issue 30684: Characteristic description fails with property field in form
The problem was that the column value was not being retrieved properly for property fields, because in this case the correct name for the property field in the request information was not being used.
---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/CharacteristicsUIDefinition.java
---
|
|
|
|
|
|
Code reviewed and verified in pi@eb72b8a596ae |
|
|
|
|
|